tree 75d345235ffbd968134f8a25f08b492e39d4c1d5
parent 5a72caa4935913882ea2ab7e985c4fc5b6af0afc
author Jonah Williams <jonahwilliams@google.com> 1685750644 -0700
committer GitHub <noreply@github.com> 1685750644 +0000
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJkeoN0CRBK7hj4Ov3rIwAA/CMIAEnEWY0gEY9sfYdQMaK61qCQ
 gfv8LP5WwC1bJr9E4/ioBOxgqpd7DTV0t9CDgre1EG6h0hGDFQRCZekG9iyrltHV
 55/gZwK+1Mda+FBOBwMSpphoZhvrvU8OBsqbo93Xc99U1eo5fBsoTmilywNWdZyd
 kurkttY3S8lRQMOF3OC46l1kJzLkEFDh7dBDMzSeh5wpgQcWvwrcboBMKPzhsQqs
 Bbk7crNEF4cuQZ/ZiGlzCObrUQlCqcx3DTsS4UqchQoUKRSAH7vcPEzQ7hP7K12l
 PnBtLT5FWiPSs9gQyl0dFvEkIJxnW82we8fFiegcb7ElxHQABRoX4sXK+DSylV4=
 =AE5y
 -----END PGP SIGNATURE-----
 

[Impeller] Fix 1-d grid computation for compute (#42516)

Note that the 2d grid case is still incorrect. Consider: the grid size should be the number of compute units required, but the threadgroup size is a minimum number of compute units.

If I need to process a 50x50 image, I should be able to set a grid size of 50x50. Since the minimum threadgroup size is probably bigger (say 1024), this should turn into one dispatch of size (1, 1, 1). However with the current implementation, we will make a dispatch of (50, 50, 1), which essentially squares the amount of work - doing one thread group per unit of compute.

The correct implementation for 2d compute should take the mod of each grid dimension with the threadgroup size in that dimension. I did not fix this case as we do not have a use for 2d compute yet.