Remove use of stringstream in NormalizeUniformKey (#37826)
This showed up as a hotspot in profiles.
diff --git a/impeller/renderer/backend/gles/buffer_bindings_gles.cc b/impeller/renderer/backend/gles/buffer_bindings_gles.cc
index 018e70a..3861765 100644
--- a/impeller/renderer/backend/gles/buffer_bindings_gles.cc
+++ b/impeller/renderer/backend/gles/buffer_bindings_gles.cc
@@ -60,15 +60,14 @@
}
static std::string NormalizeUniformKey(const std::string& key) {
- std::stringstream stream;
- for (size_t i = 0, count = key.length(); i < count; i++) {
- auto ch = key.data()[i];
- if (ch == '_') {
- continue;
+ std::string result;
+ result.reserve(key.length());
+ for (char ch : key) {
+ if (ch != '_') {
+ result.push_back(toupper(ch));
}
- stream << static_cast<char>(toupper(ch));
}
- return stream.str();
+ return result;
}
static std::string CreateUnifiormMemberKey(const std::string& struct_name,
