| commit | 3348fb0ca30286d370d6b816dd866ba5de795df6 | [log] [tgz] |
|---|---|---|
| author | Matan Lurey <matanlurey@users.noreply.github.com> | Mon Nov 20 16:43:28 2023 -0800 |
| committer | GitHub <noreply@github.com> | Mon Nov 20 16:43:28 2023 -0800 |
| tree | 6c550bbce273c8b1006dfd8ac8ea405c245cbc51 | |
| parent | f3e9b38a25884704e391a3381487a353e9dcaa69 [diff] |
[Impeller] Try replacing `*desc` with value/is_valid checks. (#48194) Some discussion here: https://discord.com/channels/608014603317936148/1175215129135153202. In short, `*<std::optional>` is [undefined behavior](https://en.cppreference.com/w/cpp/utility/optional/operator*). After talking to @bdero we are considering that this should never happen. I thought of a few different approaches here, none of them are great. However given that this class is used quite minimally, this seems to jive with similar patterns we're using in scene/scene_context. --- Feel free to push back or suggest alternatives, mostly proposing this to get brain juices flowing.
Flutter is Google's SDK for crafting beautiful, fast user experiences for mobile, web, and desktop from a single codebase. Flutter works with existing code, is used by developers and organizations around the world, and is free and open source.
The Flutter Engine is a portable runtime for hosting Flutter applications. It implements Flutter's core libraries, including animation and graphics, file and network I/O, accessibility support, plugin architecture, and a Dart runtime and compile toolchain. Most developers will interact with Flutter via the Flutter Framework, which provides a modern, reactive framework, and a rich set of platform, layout and foundation widgets.
If you want to run/contribute to Flutter Web engine, more tooling can be found at felt. This is a tool written to make web engine development experience easy.
If you are new to Flutter, then you will find more general information on the Flutter project, including tutorials and samples, on our Web site at Flutter.dev. For specific information about Flutter's APIs, consider our API reference which can be found at the docs.flutter.dev.
Flutter is a fully open source project, and we welcome contributions. Information on how to get started can be found at our contributor guide.