commit | 6e4a15d3176980e810508c6f59c3109ee75dfe57 | [log] [tgz] |
---|---|---|
author | Tong Mu <dkwingsmt@users.noreply.github.com> | Thu Apr 18 15:05:01 2024 -0700 |
committer | GitHub <noreply@github.com> | Thu Apr 18 15:05:01 2024 -0700 |
tree | e2d26571cf8f1b2d6cd1faaa33466a858f41f7a3 | |
parent | 61bf47d129bbb985faf0125bb6cca681fa12932d [diff] |
[macOS] Rename viewId to viewIdentifier (#52202) This PR adds `FlutterViewController` with new API `viewIdentifier` and renames all occasions that mention "viewId" to "viewIdentifier", to align with the requirement for the iOS shell. A new typedef `FlutterViewIdentifier` is also added. ~~The problem is, we don't have a file to contain this typedef. Currently I put them in a new file called `common.h`. I'm open to other suggestions.~~ It has been moved to `FlutterViewController.h`. * Another alternative is to not use the type def, but use `int64_t` directly. I'm ok with this choice too, since honestly it's just a 64 int. Also, macOS's definition for `kFlutterImplicitViewId` has been removed in favor of the one in `common/constants.h`. ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I signed the [CLA]. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
Flutter is Google's SDK for crafting beautiful, fast user experiences for mobile, web, and desktop from a single codebase. Flutter works with existing code, is used by developers and organizations around the world, and is free and open source.
The Flutter Engine is a portable runtime for hosting Flutter applications. It implements Flutter's core libraries, including animation and graphics, file and network I/O, accessibility support, plugin architecture, and a Dart runtime and compile toolchain. Most developers will interact with Flutter via the Flutter Framework, which provides a modern, reactive framework, and a rich set of platform, layout and foundation widgets.
If you want to run/contribute to Flutter Web engine, more tooling can be found at felt. This is a tool written to make web engine development experience easy.
If you are new to Flutter, then you will find more general information on the Flutter project, including tutorials and samples, on our Web site at Flutter.dev. For specific information about Flutter's APIs, consider our API reference which can be found at the docs.flutter.dev.
Flutter is a fully open source project, and we welcome contributions. Information on how to get started can be found at our contributor guide.