Google Git
Sign in
flutter / mirrors / engine / 9100d326475a4e5c8373612b237e99022ef1f2f0
commit9100d326475a4e5c8373612b237e99022ef1f2f0[log] [tgz]
authorBruno Leroux <leroux_bruno@yahoo.fr>Wed Feb 21 06:37:08 2024 +0100
committerGitHub <noreply@github.com>Wed Feb 21 05:37:08 2024 +0000
treeacf5b692ea4c7e0b89e6f11cb2c5bf5fcb27ae6e
parent3c2c3a04b6b27b502eed2b8706dba16d011ad626 [diff]
[Web] Update modifier state when Meta key is seen as Process key (#50779)

## Description

On Web, browsers can emit key events with a logical key sets to `Process` when the physical key is MetaLeft. Because the modifier state is 0 despite Meta key being pressed this will trigger an assert.
This PR adds some logic for this specific case. Maybe a more slightly broader solution will be needed (using the same logic for all modifiers ?). I focused on MetaLeft because it was directly reported on  https://github.com/flutter/flutter/issues/141186.

## Related Issue

Fixes https://github.com/flutter/flutter/issues/141186.

## Tests

Adds 1 test.
2 files changed
tree: acf5b692ea4c7e0b89e6f11cb2c5bf5fcb27ae6e
  1. .github/
  2. assets/
  3. benchmarking/
  4. bin/
  5. build/
  6. ci/
  7. common/
  8. display_list/
  9. docs/
  10. examples/
  11. flow/
  12. flutter_frontend_server/
  13. flutter_vma/
  14. fml/
  15. impeller/
  16. lib/
  17. runtime/
  18. shell/
  19. skia/
  20. sky/
  21. testing/
  22. third_party/
  23. tools/
  24. vulkan/
  25. wasm/
  26. web_sdk/
  27. .ci.yaml
  28. .clang-format
  29. .clang-tidy
  30. .gitattributes
  31. .gitignore
  32. .pylintrc
  33. .style.yapf
  34. analysis_options.yaml
  35. AUTHORS
  36. BUILD.gn
  37. CODEOWNERS
  38. CONTRIBUTING.md
  39. DEPS
  40. Doxyfile
  41. LICENSE
  42. README.md
README.md

Flutter Engine

Flutter CI Status OpenSSF Scorecard SLSA 1

Flutter is Google's SDK for crafting beautiful, fast user experiences for mobile, web, and desktop from a single codebase. Flutter works with existing code, is used by developers and organizations around the world, and is free and open source.

The Flutter Engine is a portable runtime for hosting Flutter applications. It implements Flutter's core libraries, including animation and graphics, file and network I/O, accessibility support, plugin architecture, and a Dart runtime and compile toolchain. Most developers will interact with Flutter via the Flutter Framework, which provides a modern, reactive framework, and a rich set of platform, layout and foundation widgets.

If you want to run/contribute to Flutter Web engine, more tooling can be found at felt. This is a tool written to make web engine development experience easy.

If you are new to Flutter, then you will find more general information on the Flutter project, including tutorials and samples, on our Web site at Flutter.dev. For specific information about Flutter's APIs, consider our API reference which can be found at the docs.flutter.dev.

Flutter is a fully open source project, and we welcome contributions. Information on how to get started can be found at our contributor guide.