tree eddb59a00a95f04e8a5c829800b3bff8e303f84c
parent f459a8661001b281ec906321899e717df3f22ffa
author Chinmay Garde <chinmaygarde@google.com> 1603358450 -0700
committer GitHub <noreply@github.com> 1603358450 -0700
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJfkU7yCRBK7hj4Ov3rIwAAdHIIACbuZObRCqLvjt/kAxtHm5X4
 hMVqOhVz1X7dxOyjtXqQkTNpEvYyTsyPOaBRqro/MsLQAuxDe1nlDcw87yfhBbgY
 u9+neUqH0YdUOWebfPhPSdLImRW3I8hMHxb6MsV0gxfy0GxQeQs9ezrKy/u82GJQ
 JurkbtYJIeQhjjXMSLt3xYZlu9rIe5sm0WXXuc6RHqpV4acPWJOOq8U1iUmB0WV4
 WD6XbQN7X9Z1XMjWSmyvRqB/oq4yI6AHSwpeMJ8U4SZPpwgJz1SgAsPD9xmee5iJ
 /MyavZIhM6X6GN0RJvQQTEniqyhLLU1Sop6ZXiVmC/ljRGbnT48nPlwMBYBp95k=
 =MBe/
 -----END PGP SIGNATURE-----
 

Isolates launched by the engine instance use the settings of that instance. (#22052)

This regression was introduced in https://github.com/flutter/engine/pull/21820
for sound-null safety. The settings used to launch the VM were incorrectly used
to determine the isolate lifecycle callbacks. Since the first shell/engine in
the process also starts the VM, these objects are usually identical. However,
for subsequent engine shell/engine launches, the callbacks attached to the new
settings object would be ignored. The unit-test harness is also structured in
such a way that each test case tears down the VM before the next. So all
existing tests created a bespoke VM for the test run, and, the tests that did
create multiple isolates did not also test attaching callbacks to the settings
object.

Fixes https://github.com/flutter/engine/pull/22041