| commit | 3a453f2ccb774f6f30f8e457aa689e1764f001b8 | [log] [tgz] |
|---|---|---|
| author | Jim Graham <flar@google.com> | Thu Jun 01 10:44:04 2023 -0700 |
| committer | GitHub <noreply@github.com> | Thu Jun 01 17:44:04 2023 +0000 |
| tree | 13f74158890b78a03c83cb7640c3f1c3b136b417 | |
| parent | 7c0a639efd0a0f6c9e260da739a80089be75e17b [diff] |
Reland "add non-rendering operation culling to DisplayListBuilder" (#41463) (#42330) The original PR caused some golden test failures down the line, likely due to bad analysis of when the combined BlendMode and color would result in a NOP situation. This PR adds tests that go through every BlandMode and pair it with a variety of colors and Color/ImageFilters to verify that the operations are only omitted when they actually produce no change in the output. It also checks the validity of the "modifies_transparent_black" property of DisplayLists which can be used in place of the current CanvasSpy/DlOpSpy classes. The description from the [previous PR](https://github.com/flutter/engine/pull/41463) updated with the new name of the DL property: --------------------------------- This optimization avoids recording unnecessary render operations that will not affect the output and also eliminates the need for "draw detection" mechanisms like `DlOpSpy` and `CanvasSpy` by remembering if any non-transparent operations were included. The `DlOpSpy` unit tests were updated to check if the results from that object match the new `DisplayList::modifies_transparent_black()` method. Fixes https://github.com/flutter/flutter/issues/125338 In addition, this change will unblock some other Issues: - https://github.com/flutter/flutter/issues/125318 - https://github.com/flutter/flutter/issues/125403
Flutter is Google's SDK for crafting beautiful, fast user experiences for mobile, web, and desktop from a single codebase. Flutter works with existing code, is used by developers and organizations around the world, and is free and open source.
The Flutter Engine is a portable runtime for hosting Flutter applications. It implements Flutter's core libraries, including animation and graphics, file and network I/O, accessibility support, plugin architecture, and a Dart runtime and compile toolchain. Most developers will interact with Flutter via the Flutter Framework, which provides a modern, reactive framework, and a rich set of platform, layout and foundation widgets.
If you want to run/contribute to Flutter Web engine, more tooling can be found at felt. This is a tool written to make web engine development experience easy.
If you are new to Flutter, then you will find more general information on the Flutter project, including tutorials and samples, on our Web site at Flutter.dev. For specific information about Flutter's APIs, consider our API reference which can be found at the docs.flutter.dev.
Flutter is a fully open source project, and we welcome contributions. Information on how to get started can be found at our contributor guide.