Google Git
Sign in
flutter / mirrors / engine / refs/tags/3.10.2
commit90fa3ae28fe6ddaee1af2c120f01e50201c1401b[log] [tgz]
authorDavid Iglesias <ditman@gmail.com>Tue May 23 19:06:20 2023 -0700
committerGitHub <noreply@github.com>Wed May 24 02:06:20 2023 +0000
tree63829a4b3ce894d133cbc287d1c537b0a1b754fc
parent4de22df7505308073b1522ebba7d4ec567712060 [diff]
[CP][web] Fix event offset on transformed widgets. (#42171)

This cherry-pick backports flutter/engine#41870 to Flutter 3.10.

* git cherry-pick 4f3f7bb (+ conflict fixes)

Original commit message below:

[web] Fix event offset for transformed widgets (and text input nodes). (#41870)

Text inputs have moved outside of the shadowDOM and are now using the pointer event offset calculation algorithm that platform views use.  However, transforms (e.g. scaling) applied to the input element aren't currently accounted for, which leads to incorrect offsets and clicks being registered inaccurately.

This PR attempts to transform those offset coordinates using the transform matrix data that is included in the geometry information sent over to `text_editing.dart` from the framework.

* Fixes https://github.com/flutter/flutter/issues/125948 (text editing)
* Fixes https://github.com/flutter/flutter/issues/126661 (platform view scaling)
* Fixes https://github.com/flutter/flutter/issues/126754

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2 files changed
tree: 63829a4b3ce894d133cbc287d1c537b0a1b754fc
  1. .github/
  2. assets/
  3. benchmarking/
  4. build/
  5. ci/
  6. common/
  7. display_list/
  8. docs/
  9. examples/
  10. flow/
  11. flutter_frontend_server/
  12. flutter_vma/
  13. fml/
  14. impeller/
  15. lib/
  16. runtime/
  17. shell/
  18. sky/
  19. testing/
  20. third_party/
  21. tools/
  22. vulkan/
  23. wasm/
  24. web_sdk/
  25. .ci.yaml
  26. .clang-format
  27. .clang-tidy
  28. .gitattributes
  29. .gitignore
  30. .pylintrc
  31. .style.yapf
  32. analysis_options.yaml
  33. AUTHORS
  34. BUILD.gn
  35. CODEOWNERS
  36. CONTRIBUTING.md
  37. DEPS
  38. Doxyfile
  39. LICENSE
  40. README.md
README.md

Flutter Engine

OpenSSF Scorecard

Flutter is Google's SDK for crafting beautiful, fast user experiences for mobile, web, and desktop from a single codebase. Flutter works with existing code, is used by developers and organizations around the world, and is free and open source.

The Flutter Engine is a portable runtime for hosting Flutter applications. It implements Flutter's core libraries, including animation and graphics, file and network I/O, accessibility support, plugin architecture, and a Dart runtime and compile toolchain. Most developers will interact with Flutter via the Flutter Framework, which provides a modern, reactive framework, and a rich set of platform, layout and foundation widgets.

If you want to run/contribute to Flutter Web engine, more tooling can be found at felt. This is a tool written to make web engine development experience easy.

If you are new to Flutter, then you will find more general information on the Flutter project, including tutorials and samples, on our Web site at Flutter.dev. For specific information about Flutter's APIs, consider our API reference which can be found at the docs.flutter.dev.

Flutter is a fully open source project, and we welcome contributions. Information on how to get started can be found at our contributor guide.