[Impeller] defer construction of VkCommandBuffer until encoding begins. (#43605)

VkCommandBuffers are allocated out of a thread local VkCommandPool. THis command buffer is only safe to use on the thread which allocates it.

We'd like to attempt concurrent encoding on Vulkan like we've done for iOS, which means the worker threads will be accessing the VkCommandBuffer. In order for this to be safe, the VkCommandBuffer must be allocated out of a VkCommandPool from that worker thread. As a simple fix, we make the Impeller CommandBuffer defer construction of the VkCommandBuffer object, allowing us to record impeller commands on the raster thread, move the command buffer to a worker thread, create the VkCommandBuffer, and then begin encoding.
22 files changed
tree: d26470f9d41074b3245d5342cc482cb16bfaf2d4
  1. .github/
  2. assets/
  3. benchmarking/
  4. build/
  5. ci/
  6. common/
  7. display_list/
  8. docs/
  9. examples/
  10. flow/
  11. flutter_frontend_server/
  12. flutter_vma/
  13. fml/
  14. impeller/
  15. lib/
  16. runtime/
  17. shell/
  18. sky/
  19. testing/
  20. third_party/
  21. tools/
  22. vulkan/
  23. wasm/
  24. web_sdk/
  25. .ci.yaml
  26. .clang-format
  27. .clang-tidy
  28. .gitattributes
  29. .gitignore
  30. .pylintrc
  31. .style.yapf
  32. analysis_options.yaml
  33. AUTHORS
  34. BUILD.gn
  35. CODEOWNERS
  36. CONTRIBUTING.md
  37. DEPS
  38. Doxyfile
  39. LICENSE
  40. README.md
README.md

Flutter Engine

OpenSSF Scorecard

Flutter is Google's SDK for crafting beautiful, fast user experiences for mobile, web, and desktop from a single codebase. Flutter works with existing code, is used by developers and organizations around the world, and is free and open source.

The Flutter Engine is a portable runtime for hosting Flutter applications. It implements Flutter's core libraries, including animation and graphics, file and network I/O, accessibility support, plugin architecture, and a Dart runtime and compile toolchain. Most developers will interact with Flutter via the Flutter Framework, which provides a modern, reactive framework, and a rich set of platform, layout and foundation widgets.

If you want to run/contribute to Flutter Web engine, more tooling can be found at felt. This is a tool written to make web engine development experience easy.

If you are new to Flutter, then you will find more general information on the Flutter project, including tutorials and samples, on our Web site at Flutter.dev. For specific information about Flutter's APIs, consider our API reference which can be found at the docs.flutter.dev.

Flutter is a fully open source project, and we welcome contributions. Information on how to get started can be found at our contributor guide.