tree 6c550bbce273c8b1006dfd8ac8ea405c245cbc51
parent f3e9b38a25884704e391a3381487a353e9dcaa69
author Matan Lurey <matanlurey@users.noreply.github.com> 1700527408 -0800
committer GitHub <noreply@github.com> 1700527408 -0800
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJlW/0wCRBK7hj4Ov3rIwAAN+EIAGK0Z1LSnxw8UQ+gvHpDZTI9
 r0WBYGURk5PbFte0kIOnvFhOdhNAiNFtuUFzsy06riTcsBjZigYCa/5K+r7Ch6xk
 cQaO3TFmcUMhCcuYcBhs4eiPW20ionG00B3p1Mwvqv10+8jzbWFuojSGMnVvp7te
 9U0c3sLYJMX3gRzHXxzDS8ODrDSoOCg/JcGFxgQzdcXwenEwywp3LmroJAUtcwAX
 xic3x6IG0Ao8TRHabgZLkadr+gyOahbxA0F2nwwJktDcD4ty4mzxaEldi4c+f0gH
 nmNZwvFEix7/L4wDCQ53Q/GdkrVg+a0llyffNouU0aNpbq09JlYo8im/Z4/9jy4=
 =uIdF
 -----END PGP SIGNATURE-----
 

[Impeller] Try replacing `*desc` with value/is_valid checks. (#48194)

Some discussion here:
https://discord.com/channels/608014603317936148/1175215129135153202.

In short, `*<std::optional>` is [undefined
behavior](https://en.cppreference.com/w/cpp/utility/optional/operator*).
After talking to @bdero we are considering that this should never
happen.

I thought of a few different approaches here, none of them are great.
However given that this class is used quite minimally, this seems to
jive with similar patterns we're using in scene/scene_context.

---

Feel free to push back or suggest alternatives, mostly proposing this to
get brain juices flowing.