tree c02c679f91fc1ee074b8fd092fe609bbc7702537
parent fc011960a2b3260d49b64823b90fe292440c78ee
author flutteractionsbot <154381524+flutteractionsbot@users.noreply.github.com> 1733529891 -0800
committer GitHub <noreply@github.com> 1733529891 -0800
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJnU5EjCRC1aQ7uu5UhlAAAEhUQABkvp8hATKbIpfBH/hNu3+Jo
 3YIprZ5KA4IWuwMSpqO3p4zmhdA0IeRcUG6wT/4uv2J06mvyNY2iJLF0KAjopas5
 AUEh6KU8QnfVnlSPoX2qNMP/zM9X2Qf/XHwZrLtyot8AnEFmrs9gcUbL8YH5h7t2
 /3veG7xd3KNaoi03QHP+byO4Fz0hhBvVsjVeoAj7NYCWr77MjzPDgFehcbSjl9s3
 w1NA/+zGoyzwliSA8SzMNjXYiya6rsyUQHw3m4P2HVKrO8/fq7ixA8rBsz/+ybZZ
 JHypeXlPKBUbsAysp5Dg5z+rMgq4YvIBtsjmcTNZzh3IHP4pDtgu8Viq2amyifOg
 J/+w4KQHIsvZZsQwJy6qI/SAtwAeakSE4C5o4eatqpAOdKERlnHoNED9gZJwY1HU
 IK52BqmyZLem0jc5xaMv4KAHyBk+5vichB6cUPhQIaI7IR+/sjvxPB+F538UoRgj
 vXOv9zYpsVgqxqpkO6kXsJ4xpg5qFXI8AL0h89GNACPp068K7lNThRf4dBEkNclx
 EKrSbTi04zds1RsMXgfI8YatZZdDLk/clrpmOE2olUoQ2uMN+ID3MH6t9/VGUTDS
 hrik+I94AK9UY+oNLv2fFFVW05soFz/l9q4IdC9EFJy6pAiv67olwBXVRXuM4DnJ
 VZcyw3IAdCdwZMYOkSWn
 =Pcjz
 -----END PGP SIGNATURE-----
 

[CP-beta][ tool ] Don't throw StateError when DDS fails to start (#159079)

This pull request is created by [automatic cherry pick
workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request)
Please fill in the form below, and a flutter domain expert will evaluate
this cherry pick request.

### Issue Link:
What is the link to the issue this cherry-pick is addressing?

https://github.com/flutter/flutter/issues/158537

### Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter
developers. See [best
practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md)
for examples

Avoid rethrowing `DartDevelopmentServiceException`s as `StateError`s
when the Dart Development Service fails to start due to the target
shutting down.

### Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot
ship an iOS app)? Does it impact development (ex. flutter doctor crashes
when Android Studio is installed), or the shipping production app (the
app crashes on launch)

Currently one of the top tool crashers on the beta branch. The crash is
harmless and shouldn't impact user workflows, but causes significant
noise.

### Workaround:
Is there a workaround for this issue?

No workaround available.

### Risk:
What is the risk level of this cherry-pick?

  - [x] Low
  - [ ] Medium
  - [ ] High

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?

  - [x] Yes
  - [ ] No

### Validation Steps:
What are the steps to validate that this fix works?

Hard to replicate the original issue consistently, but in theory: start
applications and immediately shut them down before DDS can finish
starting.

Co-authored-by: Ben Konyi <bkonyi@google.com>