tree 8fc90b8ccbb627fbf69e2e1f96854bc2af377bfd
parent 8f2e7b71d76477e32eadbd4da50a19638c55b56d
author Srujan Gaddam <58529443+srujzs@users.noreply.github.com> 1772492967 -0800
committer GitHub <noreply@github.com> 1772492967 +0000
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJpphpJCRC1aQ7uu5UhlAAAOGgQAC66bcoHuuVISEv954Qv7GgA
 jzhkfmdEU4Pb+ZLD3sZkQ1sPjetm34452WZCylx15y8DdIGFuMZgqq1RrqeUD/z2
 ksVgO66sY5qTt/TrEEHMR1mgzovQWlfSrYOvzS/YOTtEqtWepfzI4HLbo1IEzFyN
 pZT16blvoEy4WqDPfA6qzavPn1j2KmSyF7NiV5oxkcpe6Bqr9kPQUrKcuCUt6pds
 v1fXUhckVBanl71I/hX4AoeMq8KRA9zA9PElbrEzXuIGACtTtdQZ1HqNa/UPY88P
 hXrG29D/54iHoQH8fuxw8gaHJ5dbxOBH3FEA4L6VaPcNaAiLp8PmNNAsSaK3dwsJ
 JR0D+AW9chN+2NcoNQY3ktoPzkf7aa8QgMhc+Iy0fZWxpZI7FIbS0Nv4rR+3u5dF
 5xVh8+HWpoem1nW4B2xqaDtdgliQgnAkh0E8Z8I5wi+D4oh3eOjIM0jvbh0GurW6
 IYmxVBTsOjfgarnAUb02LLnjC8P92JBF7DsFswQXEbKK5qhvoN0dWB3Vv/GQ8BX9
 vq04P9/EakLJ9fey7XIWWsxTOem3bePRQcXEQjHYslDLLBD9CeOepx1nBzjXEu6k
 3d4qH/vpl8cAKYc8m+B9omFzWc+81asRmwtpnLyIiPu+1HdBJrS4DOByageh6PVU
 Ar/IRrrOFCieEndVPzzV
 =voB+
 -----END PGP SIGNATURE-----
 

Use isA to test for exceptions (#183129)

This code was never testing that the exception was a DOMException. When
compiling to JS, this is just checking if it is a JS object and when
compiling to Wasm, this is just checking if the value is a JS value.
With recent [lint
changes](https://dart-review.googlesource.com/c/sdk/+/483960), this will
now be linted and will therefore block the SDK roll.

Instead, we should catch the exception without a type, do an isA check
(now that it supports arbitrary values), and then rethrow if it isn't
the exception we were looking for.

Note that this does mean if this code was accidentally catching a
different JS value before, it now rethrows it.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].