Make forward calls run interactively (#39052)
diff --git a/packages/flutter_tools/lib/src/commands/packages.dart b/packages/flutter_tools/lib/src/commands/packages.dart index 510e9bf..cbcdd61 100644 --- a/packages/flutter_tools/lib/src/commands/packages.dart +++ b/packages/flutter_tools/lib/src/commands/packages.dart
@@ -237,7 +237,7 @@ @override Future<FlutterCommandResult> runCommand() async { Cache.releaseLockEarly(); - await pub(<String>[_commandName, ...argResults.rest], context: PubContext.pubForward, retry: false); + await pubInteractively(<String>[_commandName, ...argResults.rest]); return null; }
diff --git a/packages/flutter_tools/test/general.shard/commands/packages_test.dart b/packages/flutter_tools/test/general.shard/commands/packages_test.dart index e92e9a7..426bc61 100644 --- a/packages/flutter_tools/test/general.shard/commands/packages_test.dart +++ b/packages/flutter_tools/test/general.shard/commands/packages_test.dart
@@ -396,10 +396,9 @@ testUsingContext('deps', () async { await createTestCommandRunner(PackagesCommand()).run(<String>['packages', 'deps']); final List<String> commands = mockProcessManager.commands; - expect(commands, hasLength(3)); + expect(commands, hasLength(2)); expect(commands[0], matches(r'dart-sdk[\\/]bin[\\/]pub')); - expect(commands[1], '--trace'); - expect(commands[2], 'deps'); + expect(commands[1], 'deps'); }, overrides: <Type, Generator>{ ProcessManager: () => mockProcessManager, Stdio: () => mockStdio, @@ -409,10 +408,9 @@ testUsingContext('cache', () async { await createTestCommandRunner(PackagesCommand()).run(<String>['packages', 'cache']); final List<String> commands = mockProcessManager.commands; - expect(commands, hasLength(3)); + expect(commands, hasLength(2)); expect(commands[0], matches(r'dart-sdk[\\/]bin[\\/]pub')); - expect(commands[1], '--trace'); - expect(commands[2], 'cache'); + expect(commands[1], 'cache'); }, overrides: <Type, Generator>{ ProcessManager: () => mockProcessManager, Stdio: () => mockStdio, @@ -422,10 +420,9 @@ testUsingContext('version', () async { await createTestCommandRunner(PackagesCommand()).run(<String>['packages', 'version']); final List<String> commands = mockProcessManager.commands; - expect(commands, hasLength(3)); + expect(commands, hasLength(2)); expect(commands[0], matches(r'dart-sdk[\\/]bin[\\/]pub')); - expect(commands[1], '--trace'); - expect(commands[2], 'version'); + expect(commands[1], 'version'); }, overrides: <Type, Generator>{ ProcessManager: () => mockProcessManager, Stdio: () => mockStdio, @@ -435,10 +432,9 @@ testUsingContext('uploader', () async { await createTestCommandRunner(PackagesCommand()).run(<String>['packages', 'uploader']); final List<String> commands = mockProcessManager.commands; - expect(commands, hasLength(3)); + expect(commands, hasLength(2)); expect(commands[0], matches(r'dart-sdk[\\/]bin[\\/]pub')); - expect(commands[1], '--trace'); - expect(commands[2], 'uploader'); + expect(commands[1], 'uploader'); }, overrides: <Type, Generator>{ ProcessManager: () => mockProcessManager, Stdio: () => mockStdio, @@ -448,11 +444,10 @@ testUsingContext('global', () async { await createTestCommandRunner(PackagesCommand()).run(<String>['packages', 'global', 'list']); final List<String> commands = mockProcessManager.commands; - expect(commands, hasLength(4)); + expect(commands, hasLength(3)); expect(commands[0], matches(r'dart-sdk[\\/]bin[\\/]pub')); - expect(commands[1], '--trace'); - expect(commands[2], 'global'); - expect(commands[3], 'list'); + expect(commands[1], 'global'); + expect(commands[2], 'list'); }, overrides: <Type, Generator>{ ProcessManager: () => mockProcessManager, Stdio: () => mockStdio,