tree dc1835387806f3c8999181080502314940578416
parent 9f359aeee2a474fe9c565b3b59cf1d504b919b4d
author Chris Bracken <chris@bracken.jp> 1537232097 -0700
committer GitHub <noreply@github.com> 1537232097 -0700
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJboEzhCRBK7hj4Ov3rIwAAdHIIACvtyoQ6D3lzQeq0wyJPpTxP
 4oNRQOdLyaQVmLRx7ck59iAWVLeJoMi1zKjw2uuyu3KMRQQjPfc/0Zsk6/YqYF/O
 mTNCxNBf6aeRScpFXY/E8j/ugFfor2vXLZo5IO7ym3KZNHrlbsvAW1uWC174vFwE
 UjWDvnlOOkRQBwFa97aNK1qRnAdEhoLAot5gAKLAW/prCavljd2x7VSIiNwv0Mi0
 xvKG0aWj5S3FKErG8SKBVt7fGoJLp8VFlvU58d/73MSOFMt070dyn2jW+vm7NgW4
 7xD4NCjeB0lqFm/lc0szB5mxbxzWTorMfk65sVi/vZ/fLhhKzlZuZdELMn1Rb4Q=
 =AGTD
 -----END PGP SIGNATURE-----
 

Use Xcode legacy build system for iOS builds (#21901)

Xcode 10 introduces a new build system which includes stricter checks on
duplicate build outputs.

When plugins are in use, there are two competing build actions that copy
Flutter.framework into the build application Frameworks directory:

  1. The Embed Frameworks build phase for the Runner project
  2. The [CP] Embed Pods Frameworks build phase that pod install creates
     in the project.

Item (1) is there to ensure the framework is copied into the built app
in the case where there are no plugins (and therefore no CocoaPods
integration in the Xcode project). Item (2) is there because Flutter's
podspec declares Flutter.framework as a vended_framework, and CocoaPods
automatically adds a copy step for each such vended_framework in the
transitive closure of CocoaPods dependencies.

As an immediate fix, we opt back into the build system used by Xcode 9
and earlier. Longer term, we need to update our templates and
flutter_tools to correctly handle this situation.

See: https://github.com/flutter/flutter/issues/20685