tree 4db2187ea0c4aa1d996643f777a97bdd5cfd1c8a
parent 5322c6f860639a724839c7da19a381d78585d883
author Nathan Walker <nathanwalker1208@gmail.com> 1611113293 -0800
committer GitHub <noreply@github.com> 1611113293 -0800
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJgB6NNCRBK7hj4Ov3rIwAAdHIIAILHBHq4sExt7DEU8Qy5w2Kg
 JfqopcaacKOXN7mfjj29gNfPSGhtWf5hDSP6qSKKJsMjWKxtl4ebpH1YbxfErK70
 3G9wUX0s0Th2vpXHd6AAqfL4vPiK5RNs/SxAYSpCHIqJumzuG37kss6dRrom36+r
 N3fP4AMf3dukUSul9pIhEWASvg8Agr/PkhEwAvPDWCUOdQIL09hotUqFtrf/qijN
 5qKshFu631Yx0bwADzKLsCwk+qnYqC94RYg52PdMmff00JE+daowu8xirfSXYXqR
 y8DEPgM1KvgUlI8EmBeBgDdR8gZeVNjNtBV/zh25wKtts9DVMn7tECjpl5D86W0=
 =hrEh
 -----END PGP SIGNATURE-----
 

ListTile Material Ripple and Shape Patch (#73618)

This PR replaces the ColoredBox that ListTile uses with an Ink widget. That Ink widget is given a ShapeDecoration with the ListTile's color and shape. This fixes issues where the ListTile color would obscure material ripple effects, and cause the specified shape to not be respected.

List which issues are fixed by this PR. You must list at least one issue.

Fixes #73616
Fixes #63877
Fixes #67117

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

I modified a handful of tests related to ListTiles. The tests I changed had implementation-specific ways of checking the ListTile color. I have rewritten those so that instead of checking for a ColoredBox with a specific color, they check that a path is painted with the correct color.

I added the following tests to list_tile_test.dart:

"ListTile shows Material ripple effects on top of tileColor" (Regression test for #73616)
"ListTile shape is painted correctly" (Regression test for #63877)
I added the following test to sliver_prototype_item_extent_test.dart:

"SliverPrototypeExtentList prototypeItem paint transform is zero" (Regression test for #67117)