enable lint prefer_equal_for_default_values (#18156)
diff --git a/packages/flutter_tools/test/base/build_test.dart b/packages/flutter_tools/test/base/build_test.dart index 7012112..754af83 100644 --- a/packages/flutter_tools/test/base/build_test.dart +++ b/packages/flutter_tools/test/base/build_test.dart
@@ -28,7 +28,7 @@ class _FakeGenSnapshot implements GenSnapshot { _FakeGenSnapshot({ - this.succeed: true, + this.succeed = true, }); final bool succeed; @@ -136,7 +136,7 @@ } void expectFingerprintHas({ - String entryPoint: 'main.dart', + String entryPoint = 'main.dart', Map<String, String> checksums = const <String, String>{}, }) { final Map<String, dynamic> jsonObject = json.decode(fs.file('output.snapshot.d.fingerprint').readAsStringSync());
diff --git a/packages/flutter_tools/test/cache_test.dart b/packages/flutter_tools/test/cache_test.dart index 9d53dcd..0b227e5 100644 --- a/packages/flutter_tools/test/cache_test.dart +++ b/packages/flutter_tools/test/cache_test.dart
@@ -124,7 +124,7 @@ class MockFile extends Mock implements File { @override - Future<RandomAccessFile> open({FileMode mode: FileMode.READ}) async { // ignore: deprecated_member_use + Future<RandomAccessFile> open({FileMode mode = FileMode.READ}) async { // ignore: deprecated_member_use return new MockRandomAccessFile(); } }
diff --git a/packages/flutter_tools/test/commands/analyze_continuously_test.dart b/packages/flutter_tools/test/commands/analyze_continuously_test.dart index 2a67faa..850efb9 100644 --- a/packages/flutter_tools/test/commands/analyze_continuously_test.dart +++ b/packages/flutter_tools/test/commands/analyze_continuously_test.dart
@@ -109,7 +109,7 @@ }); } -void _createSampleProject(Directory directory, { bool brokenCode: false }) { +void _createSampleProject(Directory directory, { bool brokenCode = false }) { final File pubspecFile = fs.file(fs.path.join(directory.path, 'pubspec.yaml')); pubspecFile.writeAsStringSync(''' name: foo_project
diff --git a/packages/flutter_tools/test/commands/analyze_once_test.dart b/packages/flutter_tools/test/commands/analyze_once_test.dart index d14fe98..e721ac6 100644 --- a/packages/flutter_tools/test/commands/analyze_once_test.dart +++ b/packages/flutter_tools/test/commands/analyze_once_test.dart
@@ -224,7 +224,7 @@ List<String> arguments, List<String> statusTextContains, List<String> errorTextContains, - bool toolExit: false, + bool toolExit = false, String exitMessageContains, }) async { try {
diff --git a/packages/flutter_tools/test/commands/create_test.dart b/packages/flutter_tools/test/commands/create_test.dart index a893d95..4666080 100644 --- a/packages/flutter_tools/test/commands/create_test.dart +++ b/packages/flutter_tools/test/commands/create_test.dart
@@ -503,9 +503,9 @@ List<dynamic> command, { String workingDirectory, Map<String, String> environment, - bool includeParentEnvironment: true, - bool runInShell: false, - ProcessStartMode mode: ProcessStartMode.NORMAL, // ignore: deprecated_member_use + bool includeParentEnvironment = true, + bool runInShell = false, + ProcessStartMode mode = ProcessStartMode.NORMAL, // ignore: deprecated_member_use }) { commands.add(command); return super.start(
diff --git a/packages/flutter_tools/test/commands/daemon_test.dart b/packages/flutter_tools/test/commands/daemon_test.dart index 1a8a45e..037c123 100644 --- a/packages/flutter_tools/test/commands/daemon_test.dart +++ b/packages/flutter_tools/test/commands/daemon_test.dart
@@ -326,14 +326,14 @@ bool _isConnectedEvent(Map<String, dynamic> map) => map['event'] == 'daemon.connected'; class MockAndroidWorkflow extends AndroidWorkflow { - MockAndroidWorkflow({ this.canListDevices: true }); + MockAndroidWorkflow({ this.canListDevices = true }); @override final bool canListDevices; } class MockIOSWorkflow extends IOSWorkflow { - MockIOSWorkflow({ this.canListDevices:true }); + MockIOSWorkflow({ this.canListDevices =true }); @override final bool canListDevices;
diff --git a/packages/flutter_tools/test/commands/devices_test.dart b/packages/flutter_tools/test/commands/devices_test.dart index 333fe19..395d310 100644 --- a/packages/flutter_tools/test/commands/devices_test.dart +++ b/packages/flutter_tools/test/commands/devices_test.dart
@@ -46,10 +46,10 @@ List<dynamic> command, { String workingDirectory, Map<String, String> environment, - bool includeParentEnvironment: true, - bool runInShell: false, - Encoding stdoutEncoding: SYSTEM_ENCODING, // ignore: deprecated_member_use - Encoding stderrEncoding: SYSTEM_ENCODING, // ignore: deprecated_member_use + bool includeParentEnvironment = true, + bool runInShell = false, + Encoding stdoutEncoding = SYSTEM_ENCODING, // ignore: deprecated_member_use + Encoding stderrEncoding = SYSTEM_ENCODING, // ignore: deprecated_member_use }) async { return new ProcessResult(0, 0, '', ''); } @@ -59,10 +59,10 @@ List<dynamic> command, { String workingDirectory, Map<String, String> environment, - bool includeParentEnvironment: true, - bool runInShell: false, - Encoding stdoutEncoding: SYSTEM_ENCODING, // ignore: deprecated_member_use - Encoding stderrEncoding: SYSTEM_ENCODING, // ignore: deprecated_member_use + bool includeParentEnvironment = true, + bool runInShell = false, + Encoding stdoutEncoding = SYSTEM_ENCODING, // ignore: deprecated_member_use + Encoding stderrEncoding = SYSTEM_ENCODING, // ignore: deprecated_member_use }) { return new ProcessResult(0, 0, '', ''); }
diff --git a/packages/flutter_tools/test/commands/fuchsia_reload_test.dart b/packages/flutter_tools/test/commands/fuchsia_reload_test.dart index 600b839..7fdcb60 100644 --- a/packages/flutter_tools/test/commands/fuchsia_reload_test.dart +++ b/packages/flutter_tools/test/commands/fuchsia_reload_test.dart
@@ -36,10 +36,10 @@ List<dynamic> command, { String workingDirectory, Map<String, String> environment, - bool includeParentEnvironment: true, - bool runInShell: false, - Encoding stdoutEncoding: SYSTEM_ENCODING, // ignore: deprecated_member_use - Encoding stderrEncoding: SYSTEM_ENCODING, // ignore: deprecated_member_use + bool includeParentEnvironment = true, + bool runInShell = false, + Encoding stdoutEncoding = SYSTEM_ENCODING, // ignore: deprecated_member_use + Encoding stderrEncoding = SYSTEM_ENCODING, // ignore: deprecated_member_use }) async { return new ProcessResult(0, 0, '1234\n5678\n5', ''); }
diff --git a/packages/flutter_tools/test/commands/ide_config_test.dart b/packages/flutter_tools/test/commands/ide_config_test.dart index f1bfa64..a12eb79 100644 --- a/packages/flutter_tools/test/commands/ide_config_test.dart +++ b/packages/flutter_tools/test/commands/ide_config_test.dart
@@ -40,7 +40,7 @@ return contents; } - Map<String, String> _getManifest(Directory base, String marker, {bool isTemplate: false}) { + Map<String, String> _getManifest(Directory base, String marker, {bool isTemplate = false}) { final String basePath = fs.path.relative(base.path, from: temp.absolute.path); final String suffix = isTemplate ? Template.copyTemplateExtension : ''; return <String, String>{
diff --git a/packages/flutter_tools/test/commands/test_test.dart b/packages/flutter_tools/test/commands/test_test.dart index c423eae..1bed1d5 100644 --- a/packages/flutter_tools/test/commands/test_test.dart +++ b/packages/flutter_tools/test/commands/test_test.dart
@@ -146,7 +146,7 @@ String testName, String workingDirectory, String testDirectory, { - List<String> extraArgs: const <String>[], + List<String> extraArgs = const <String>[], }) async { final String testFilePath = fs.path.join(testDirectory, '${testName}_test.dart');
diff --git a/packages/flutter_tools/test/dart/pub_get_test.dart b/packages/flutter_tools/test/dart/pub_get_test.dart index 550429c..f9c2b7a 100644 --- a/packages/flutter_tools/test/dart/pub_get_test.dart +++ b/packages/flutter_tools/test/dart/pub_get_test.dart
@@ -162,9 +162,9 @@ List<dynamic> command, { String workingDirectory, Map<String, String> environment, - bool includeParentEnvironment: true, - bool runInShell: false, - ProcessStartMode mode: ProcessStartMode.NORMAL, // ignore: deprecated_member_use + bool includeParentEnvironment = true, + bool runInShell = false, + ProcessStartMode mode = ProcessStartMode.NORMAL, // ignore: deprecated_member_use }) { lastPubEnvironment = environment['PUB_ENVIRONMENT']; lastPubCache = environment['PUB_CACHE']; @@ -237,7 +237,7 @@ class MockFile implements File { @override - Future<RandomAccessFile> open({FileMode mode: FileMode.READ}) async { // ignore: deprecated_member_use + Future<RandomAccessFile> open({FileMode mode = FileMode.READ}) async { // ignore: deprecated_member_use return new MockRandomAccessFile(); }
diff --git a/packages/flutter_tools/test/devfs_test.dart b/packages/flutter_tools/test/devfs_test.dart index 223587a..2f165a3 100644 --- a/packages/flutter_tools/test/devfs_test.dart +++ b/packages/flutter_tools/test/devfs_test.dart
@@ -443,9 +443,9 @@ @override Future<Map<String, dynamic>> invokeRpcRaw(String method, { - Map<String, dynamic> params: const <String, dynamic>{}, + Map<String, dynamic> params = const <String, dynamic>{}, Duration timeout, - bool timeoutFatal: true, + bool timeoutFatal = true, }) async { _service.messages.add('$method $params'); return <String, dynamic>{'success': true}; @@ -471,7 +471,7 @@ } } -Future<Null> _createPackage(FileSystem fs, String pkgName, String pkgFileName, { bool doubleSlash: false }) async { +Future<Null> _createPackage(FileSystem fs, String pkgName, String pkgFileName, { bool doubleSlash = false }) async { final Directory pkgTempDir = _newTempDir(fs); String pkgFilePath = fs.path.join(pkgTempDir.path, pkgName, 'lib', pkgFileName); if (doubleSlash) {
diff --git a/packages/flutter_tools/test/ios/ios_workflow_test.dart b/packages/flutter_tools/test/ios/ios_workflow_test.dart index fb71785..ba3bae0 100644 --- a/packages/flutter_tools/test/ios/ios_workflow_test.dart +++ b/packages/flutter_tools/test/ios/ios_workflow_test.dart
@@ -310,8 +310,8 @@ class MockIMobileDevice extends IMobileDevice { MockIMobileDevice({ - this.isInstalled: true, - bool isWorking: true, + this.isInstalled = true, + bool isWorking = true, }) : isWorking = new Future<bool>.value(isWorking); @override @@ -327,11 +327,11 @@ class IOSWorkflowTestTarget extends IOSWorkflow { IOSWorkflowTestTarget({ - this.hasPythonSixModule: true, - this.hasHomebrew: true, - bool hasIosDeploy: true, - String iosDeployVersionText: '1.9.2', - bool hasIDeviceInstaller: true, + this.hasPythonSixModule = true, + this.hasHomebrew = true, + bool hasIosDeploy = true, + String iosDeployVersionText = '1.9.2', + bool hasIDeviceInstaller = true, }) : hasIosDeploy = new Future<bool>.value(hasIosDeploy), iosDeployVersionText = new Future<String>.value(iosDeployVersionText), hasIDeviceInstaller = new Future<bool>.value(hasIDeviceInstaller);
diff --git a/packages/flutter_tools/test/resident_runner_test.dart b/packages/flutter_tools/test/resident_runner_test.dart index 44e88c9..ebe65cd 100644 --- a/packages/flutter_tools/test/resident_runner_test.dart +++ b/packages/flutter_tools/test/resident_runner_test.dart
@@ -38,7 +38,7 @@ Completer<DebugConnectionInfo> connectionInfoCompleter, Completer<dynamic> appStartedCompleter, String route, - bool shouldBuild: true, + bool shouldBuild = true, }) => null; }
diff --git a/packages/flutter_tools/test/runner/flutter_command_test.dart b/packages/flutter_tools/test/runner/flutter_command_test.dart index 3e6fb46..6366eb0 100644 --- a/packages/flutter_tools/test/runner/flutter_command_test.dart +++ b/packages/flutter_tools/test/runner/flutter_command_test.dart
@@ -149,8 +149,8 @@ class DummyFlutterCommand extends FlutterCommand { DummyFlutterCommand({ - this.shouldUpdateCache : false, - this.noUsagePath : false, + this.shouldUpdateCache = false, + this.noUsagePath = false, this.commandFunction, });
diff --git a/packages/flutter_tools/test/src/context.dart b/packages/flutter_tools/test/src/context.dart index 260d708..32a5e23 100644 --- a/packages/flutter_tools/test/src/context.dart +++ b/packages/flutter_tools/test/src/context.dart
@@ -41,8 +41,8 @@ @isTest void testUsingContext(String description, dynamic testMethod(), { Timeout timeout, - Map<Type, Generator> overrides: const <Type, Generator>{}, - bool initializeFlutterRoot: true, + Map<Type, Generator> overrides = const <Type, Generator>{}, + bool initializeFlutterRoot = true, String testOn, bool skip, // should default to `false`, but https://github.com/dart-lang/test/issues/545 doesn't allow this }) {
diff --git a/packages/flutter_tools/test/src/mocks.dart b/packages/flutter_tools/test/src/mocks.dart index de59e59..fe732a9 100644 --- a/packages/flutter_tools/test/src/mocks.dart +++ b/packages/flutter_tools/test/src/mocks.dart
@@ -38,10 +38,10 @@ /// An SDK installation with several SDK levels (19, 22, 23). class MockAndroidSdk extends Mock implements AndroidSdk { static Directory createSdkDirectory({ - bool withAndroidN: false, + bool withAndroidN = false, String withNdkDir, - bool withNdkSysroot: false, - bool withSdkManager: true, + bool withNdkSysroot = false, + bool withSdkManager = true, }) { final Directory dir = fs.systemTempDirectory.createTempSync('android-sdk'); @@ -120,9 +120,9 @@ List<dynamic> command, { String workingDirectory, Map<String, String> environment, - bool includeParentEnvironment: true, - bool runInShell: false, - ProcessStartMode mode: ProcessStartMode.NORMAL, // ignore: deprecated_member_use + bool includeParentEnvironment = true, + bool runInShell = false, + ProcessStartMode mode = ProcessStartMode.NORMAL, // ignore: deprecated_member_use }) { if (!succeed) { final String executable = command[0]; @@ -141,11 +141,11 @@ /// A process that exits successfully with no output and ignores all input. class MockProcess extends Mock implements Process { MockProcess({ - this.pid: 1, + this.pid = 1, Future<int> exitCode, Stream<List<int>> stdin, - this.stdout: const Stream<List<int>>.empty(), - this.stderr: const Stream<List<int>>.empty(), + this.stdout = const Stream<List<int>>.empty(), + this.stderr = const Stream<List<int>>.empty(), }) : exitCode = exitCode ?? new Future<int>.value(0), stdin = stdin ?? new MemoryIOSink();
diff --git a/packages/flutter_tools/test/version_test.dart b/packages/flutter_tools/test/version_test.dart index 51fbcca..9770ef9 100644 --- a/packages/flutter_tools/test/version_test.dart +++ b/packages/flutter_tools/test/version_test.dart
@@ -361,9 +361,9 @@ DateTime remoteCommitDate, VersionCheckStamp stamp, String stampJson, - bool errorOnFetch: false, - bool expectSetStamp: false, - bool expectServerPing: false, + bool errorOnFetch = false, + bool expectSetStamp = false, + bool expectServerPing = false, }) { ProcessResult success(String standardOutput) { return new ProcessResult(1, 0, standardOutput, '');