[WebParagraph] Fixing edge cases for wrapping text (with newlines) (#189858) ### Summary Fixes newline (`\n`) handling and caret/selection geometry in `WebParagraph` to match `SkParagraph` behavior, resolving misplaced cursor issues in multiline text fields on the web. Fixes https://github.com/flutter/flutter/issues/188320 --- ### Background In Flutter text editing (`RenderEditable`), caret positioning, line navigation, and selection rely directly on `Paragraph` query APIs (`getPositionForOffset`, `getBoxesForRange`, `getLineBoundary`, `getLineNumberAt`, and `getGlyphInfoAt`). Previously, `WebParagraph` diverged from `SkParagraph` in several key newline edge cases: 1. **Physical vs. Logical Width:** Browser Canvas/DOM text measurement treats `\n` as whitespace with positive advance width. In `SkParagraph`, newlines occupy zero physical width while retaining their logical text ranges. 2. **Trailing Newlines:** Text ending in a newline (e.g. `"Hello\n"`) must generate an additional empty line where the cursor resides after pressing Enter. 3. **Query Parity:** Hit-testing and boundary queries on lines ending with or consisting entirely of newlines returned incorrect offsets or collapsed bounds. --- ### Changes - **Explicit Hard Line Break Tracking (`wrapper.dart`):** - Separated hard line breaks (`\n`) from collapsible whitespace in `_LineBuilder`. - Added support for generating the trailing empty line when text terminates with a hard line break. - **Logical vs. Physical Text Ranges (`layout.dart`, `paragraph.dart`):** - Introduced `physicalTextRange` on `TextBlock` to exclude `\n` from physical geometry calculations (bounds, selection rects, line widths) while preserving `textRange` for logical text operations. - Adjusted `getGlyphInfoAt` to report zero layout width for `\n` and synthesize end-of-line glyph bounds for newlines outside visual blocks. - Aligned `getPositionForOffset` and `getLineBoundary` with `SkParagraph` hit-testing rules, correctly handling empty trailing lines and cluster boundary affinity. - Implemented `SkParagraph`-matching binary search in `getLineNumberAt`. --- ### Testing - Added `test/webparagraph/paragraph_edge_cases_test.dart` (newline wrapping and empty line creation). - Added `test/webparagraph/paragraph_selection_caret_test.dart` (caret hit-testing, affinities, and selection bounding boxes across multiline text). - Added `test/webparagraph/paragraph_line_metrics_test.dart` (line geometry and width validation). - Updated existing `webparagraph` unit tests to ensure 1:1 parity with `SkParagraph`. --------- Co-authored-by: Mouad Debbar <mouad.debbar@gmail.com> Co-authored-by: Jackson Gardner <jacksongardner@google.com>
Flutter is Google's SDK for crafting beautiful, fast user experiences for mobile, web, and desktop from a single codebase. Flutter works with existing code, is used by developers and organizations around the world, and is free and open source.
For release and other announcements, join the flutter-announce mailing list. Our documentation also tracks breaking changes across releases.
The Flutter tool may occasionally download resources from Google servers. By downloading or using the Flutter SDK, you agree to the Google Terms of Service: https://policies.google.com/terms
For example, when installed from GitHub (as opposed to from a prepackaged archive), the Flutter tool will download the Dart SDK from Google servers immediately when first run, as it is used to execute the flutter tool itself. This will also occur when Flutter is upgraded (e.g. by running the flutter upgrade command).
We think Flutter will help you create beautiful, fast apps, with a productive, extensible and open development model, whether you're targeting iOS or Android, web, Windows, macOS, Linux or embedding it as the UI toolkit for a platform of your choice.
We want to enable designers to deliver their full creative vision without being forced to water it down due to limitations of the underlying framework. Flutter‘s layered architecture gives you control over every pixel on the screen and its powerful compositing capabilities let you overlay and animate graphics, video, text, and controls without limitation. Flutter includes a full set of widgets that deliver pixel-perfect experiences whether you’re building for iOS (Cupertino) or other platforms (Material), along with support for customizing or creating entirely new visual components.
Flutter is fast. It's powered by hardware-accelerated 2D graphics libraries like Skia (which underpins Chrome and Android) and Impeller. We architected Flutter to support glitch-free, jank-free graphics at the native speed of your device.
Flutter code is powered by the world-class Dart programming language, which enables compilation to 32-bit and 64-bit ARM machine code for iOS and Android, JavaScript and WebAssembly for the web, as well as Intel x64 and ARM for desktop devices.
Flutter offers stateful hot reload, allowing you to make changes to your code and see the results instantly without restarting your app or losing its state.
Flutter works with any development tool (or none at all), and also includes editor plug-ins for both Visual Studio Code and IntelliJ / Android Studio. Flutter provides tens of thousands of packages to speed your development, regardless of your target platform. And accessing other native code is easy, with support for both FFI (on Android, on iOS, on macOS, on Linux, and on Windows) as well as platform-specific APIs.
Flutter is a fully open-source project, and we welcome contributions. Information on how to get started can be found in our contributor guide.