commit 1ffd5f02d641823c3799cf84b11623ee546f32e3
author Joshua Seaton <josh.a.seaton@gmail.com> Mon Mar 04 10:52:58 2019 -0800
committer Zachary Anderson <zanderso@users.noreply.github.com> Mon Mar 04 13:52:58 2019 -0500
tree 6131aa36d856252d7812c56ef4c63ba4d9462290
parent cb704dfd9681ab5c8424d61259e8edd1d6e03536

[fuchsia] Permit relative entries to the fuchsia_tester (#28821)

This change permits
(1) a relative --flutter-shell
(2) relative (source, dill) entries within the test JSON file

and enables portability in the invocation scripts produced by fuchsia's
dart test GN template.

packages/flutter_tools/bin/fuchsia_tester.dart

diff --git a/packages/flutter_tools/bin/fuchsia_tester.dart b/packages/flutter_tools/bin/fuchsia_tester.dart
index 7943d51..dd3756e 100644
--- a/packages/flutter_tools/bin/fuchsia_tester.dart
+++ b/packages/flutter_tools/bin/fuchsia_tester.dart
@@ -75,7 +75,7 @@
   try {
     Cache.flutterRoot = tempDir.path;
 
-    final String shellPath = argResults[_kOptionShell];
+    final String shellPath = fs.file(argResults[_kOptionShell]).resolveSymbolicLinksSync();
     if (!fs.isFileSync(shellPath)) {
       throwToolExit('Cannot find Flutter shell at $shellPath');
     }
@@ -128,7 +128,9 @@
     final List<Map<String, dynamic>> jsonList = List<Map<String, dynamic>>.from(
       json.decode(fs.file(argResults[_kOptionTests]).readAsStringSync()));
     for (Map<String, dynamic> map in jsonList) {
-      tests[map['source']] = map['dill'];
+      final String source = fs.file(map['source']).resolveSymbolicLinksSync();
+      final String dill = fs.file(map['dill']).resolveSymbolicLinksSync();
+      tests[source] = dill;
     }
 
     exitCode = await runTests(