)]}'
{
  "commit": "28cc211fcd70e5abe6fcbf1d3b5fb19db06cd064",
  "tree": "eeab2c5e0e3779ccefea3e18e0ad52daa1424fc7",
  "parents": [
    "a4b5a502d0abfb99f7e00077b0201951850ff8d3"
  ],
  "author": {
    "name": "auto-submit[bot]",
    "email": "98614782+auto-submit[bot]@users.noreply.github.com",
    "time": "Fri Apr 11 21:35:18 2025 +0000"
  },
  "committer": {
    "name": "GitHub",
    "email": "noreply@github.com",
    "time": "Fri Apr 11 21:35:18 2025 +0000"
  },
  "message": "Reverts \"Fix regression in NDK version checking (#166998)\" (#167007)\n\n\u003c!-- start_original_pr_link --\u003e\nReverts: flutter/flutter#166998\n\u003c!-- end_original_pr_link --\u003e\n\u003c!-- start_initiating_author --\u003e\nInitiated by: gmackall\n\u003c!-- end_initiating_author --\u003e\n\u003c!-- start_revert_reason --\u003e\nReason for reverting:\nhttps://github.com/flutter/flutter/pull/166998#issuecomment-2798030501\n\u003c!-- end_revert_reason --\u003e\n\u003c!-- start_original_pr_author --\u003e\nOriginal PR Author: gmackall\n\u003c!-- end_original_pr_author --\u003e\n\n\u003c!-- start_reviewers --\u003e\nReviewed By: {stuartmorgan-g}\n\u003c!-- end_reviewers --\u003e\n\n\u003c!-- start_revert_body --\u003e\nThis change reverts the following previous change:\nFixes a regression from https://github.com/flutter/flutter/pull/166727/,\nsee\nhttps://discord.com/channels/608014603317936148/846507907876257822/1360306682999210204\n\nAdds a dependency on `shared_preferences_android` to the smoke tests we\nhave that run across the range of AGP/Gradle versions we support. Chosen\nrandomly, just to recreate the error. Hopefully this doesn\u0027t push the\ntest target into timeout range, it was already a kind of long running\none.\n\nThe IDE suggestion here was misleading, as this value switched from\nnullable to non nullable in AGP 8.1/8.2. Unfortunately the IDE makes\nthese suggestions based on one AGP version, specified in the project\nlevel `build.gradle.kts`. I checked all other files with our minimum\nsupported AGP version, and this was the only error.\n\n## Pre-launch Checklist\n\n- [x] I read the [Contributor Guide] and followed the process outlined\nthere for submitting PRs.\n- [x] I read the [Tree Hygiene] wiki page, which explains my\nresponsibilities.\n- [x] I read and followed the [Flutter Style Guide], including [Features\nwe expect every widget to implement].\n- [x] I signed the [CLA].\n- [ ] I listed at least one issue that this PR fixes in the description\nabove.\n- [x] I updated/added relevant documentation (doc comments with `///`).\n- [x] I added new tests to check the change I am making, or this PR is\n[test-exempt].\n- [x] I followed the [breaking change policy] and added [Data Driven\nFixes] where supported.\n- [x] All existing and new tests are passing.\n\nIf you need help, consider asking for advice on the #hackers-new channel\non [Discord].\n\n\u003c!-- Links --\u003e\n[Contributor Guide]:\nhttps://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview\n[Tree Hygiene]:\nhttps://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md\n[test-exempt]:\nhttps://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests\n[Flutter Style Guide]:\nhttps://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md\n[Features we expect every widget to implement]:\nhttps://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement\n[CLA]: https://cla.developers.google.com/\n[flutter/tests]: https://github.com/flutter/tests\n[breaking change policy]:\nhttps://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes\n[Discord]:\nhttps://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md\n[Data Driven Fixes]:\nhttps://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md\n\n\u003c!-- end_revert_body --\u003e\n\nCo-authored-by: auto-submit[bot] \u003cflutter-engprod-team@google.com\u003e",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "b20fddb41b3b1953b0bc844aba6ae16f0cb18f48",
      "old_mode": 33188,
      "old_path": "dev/devicelab/lib/framework/dependency_smoke_test_task_definition.dart",
      "new_id": "d333046fffe2961723715722cfc09e69a4ceab78",
      "new_mode": 33188,
      "new_path": "dev/devicelab/lib/framework/dependency_smoke_test_task_definition.dart"
    },
    {
      "type": "modify",
      "old_id": "e6ec439ba6d95505001e95bbe577ee06001ef4c9",
      "old_mode": 33188,
      "old_path": "packages/flutter_tools/gradle/src/main/kotlin/FlutterPluginUtils.kt",
      "new_id": "2b622591eb8efc44d125741e1da197a675678497",
      "new_mode": 33188,
      "new_path": "packages/flutter_tools/gradle/src/main/kotlin/FlutterPluginUtils.kt"
    }
  ]
}