commit 35af0d7b1b015b9b0341f6ae6b3ef7732b78a86f
author YeungKC <I@YeungKC.com> Thu Jan 07 00:19:04 2021 +0800
committer GitHub <noreply@github.com> Wed Jan 06 08:19:04 2021 -0800
tree 4e4ff9e633c25106c7dba6c53e2f9edd6107d04b
parent d0e9959a46e95b88572d38a3ecf2f589f042f64f

Fix dateAndTime and time modes of CupertinoDatePicker. (#73276)

packages/flutter/lib/src/cupertino/date_picker.dart

diff --git a/packages/flutter/lib/src/cupertino/date_picker.dart b/packages/flutter/lib/src/cupertino/date_picker.dart
index c89b45d..314e2a4 100644
--- a/packages/flutter/lib/src/cupertino/date_picker.dart
+++ b/packages/flutter/lib/src/cupertino/date_picker.dart
@@ -719,6 +719,7 @@
             Text(dateText, style: _themeTextStyle(context)),
           );
         },
+        selectionOverlay: selectionOverlay,
       ),
     );
   }
@@ -802,6 +803,7 @@
           );
         }),
         looping: true,
+        selectionOverlay: selectionOverlay,
       )
     );
   }

packages/flutter/test/cupertino/date_picker_test.dart

diff --git a/packages/flutter/test/cupertino/date_picker_test.dart b/packages/flutter/test/cupertino/date_picker_test.dart
index a00a0a2..5eafa3c 100644
--- a/packages/flutter/test/cupertino/date_picker_test.dart
+++ b/packages/flutter/test/cupertino/date_picker_test.dart
@@ -1147,24 +1147,38 @@
     });
 
     testWidgets('DatePicker golden tests', (WidgetTester tester) async {
-      await tester.pumpWidget(
-        CupertinoApp(
+      Widget _buildApp(CupertinoDatePickerMode mode) {
+        return CupertinoApp(
           home: Center(
             child: SizedBox(
               width: 500,
               height: 400,
               child: RepaintBoundary(
                 child: CupertinoDatePicker(
-                  mode: CupertinoDatePickerMode.dateAndTime,
-                  initialDateTime: DateTime(2019, 1, 1, 4),
+                  key: ValueKey<CupertinoDatePickerMode>(mode),
+                  mode: mode,
+                  initialDateTime: DateTime(2019, 1, 1, 4, 12, 30),
                   onDateTimeChanged: (_) {},
                 ),
               ),
             ),
           ),
-        ),
+        );
+      }
+
+      await tester.pumpWidget(_buildApp(CupertinoDatePickerMode.time));
+      await expectLater(
+        find.byType(CupertinoDatePicker),
+        matchesGoldenFile('date_picker_test.time.initial.png'),
       );
 
+      await tester.pumpWidget(_buildApp(CupertinoDatePickerMode.date));
+      await expectLater(
+        find.byType(CupertinoDatePicker),
+        matchesGoldenFile('date_picker_test.date.initial.png'),
+      );
+
+      await tester.pumpWidget(_buildApp(CupertinoDatePickerMode.dateAndTime));
       await expectLater(
         find.byType(CupertinoDatePicker),
         matchesGoldenFile('date_picker_test.datetime.initial.png'),