commit 35c364053bd3db906a6c9f9bd85745943e5fc5bf
author Jonah Williams <jonahwilliams@google.com> Thu Oct 15 19:03:28 2020 -0700
committer GitHub <noreply@github.com> Thu Oct 15 19:03:28 2020 -0700
tree e58cc38fda7ef6a6cadd131dbb935f192a286a4d
parent d7f80fcdd3789e42f206c3ac87cb81cc2883bde0

Fix screenshotting code (#68261)

dev/devicelab/lib/framework/utils.dart

diff --git a/dev/devicelab/lib/framework/utils.dart b/dev/devicelab/lib/framework/utils.dart
index e60753c..ad29d3f 100644
--- a/dev/devicelab/lib/framework/utils.dart
+++ b/dev/devicelab/lib/framework/utils.dart
@@ -280,12 +280,12 @@
   final String finalWorkingDirectory = workingDirectory ?? cwd;
   print('\nExecuting: $command in $finalWorkingDirectory'
       + (environment != null ? ' with environment $environment' : ''));
-  environment ??= <String, String>{};
-  environment['BOT'] = isBot ? 'true' : 'false';
-  environment['FLUTTER_IOS_SCREENSHOT_ON_CONNECTION_FAILURE'] = 'true';
+  final Map<String, String> newEnvironment = Map<String, String>.from(environment ?? <String, String>{});
+  newEnvironment['BOT'] = isBot ? 'true' : 'false';
+  newEnvironment['FLUTTER_IOS_SCREENSHOT_ON_CONNECTION_FAILURE'] = 'true';
   final Process process = await _processManager.start(
     <String>[executable, ...arguments],
-    environment: environment,
+    environment: newEnvironment,
     workingDirectory: finalWorkingDirectory,
   );
   final ProcessInfo processInfo = ProcessInfo(command, process);