Make Felt unzip Chrome into a temporary directory next to the final location of the files (flutter/engine#57109)
The Web Felt script downloads a Chrome zip archive, extracts it to a temporary directory, and then moves the files to a location expected by the script.
Previously Felt used a temporary directory based on io.Directory.systemTemp. This may not work because the FileSystemEntity.rename operation used to move the files can fail if the system temp directory is located in a different filesystem from the destination directory.
diff --git a/engine/src/flutter/lib/web_ui/dev/chrome_installer.dart b/engine/src/flutter/lib/web_ui/dev/chrome_installer.dart
index e8dda99..a044ba4 100644
--- a/engine/src/flutter/lib/web_ui/dev/chrome_installer.dart
+++ b/engine/src/flutter/lib/web_ui/dev/chrome_installer.dart
@@ -218,7 +218,7 @@
// version directory. However, the zip file contains a top-level directory
// named e.g. 'chrome-linux'. We need to copy the files out of that
// directory and into the version directory.
- final io.Directory tmpDir = await io.Directory.systemTemp.createTemp();
+ final io.Directory tmpDir = await chromeInstallationDir.createTemp();
final io.Directory unzipDir = tmpDir;
final io.ProcessResult unzipResult =
await io.Process.run('unzip', <String>[
