| commit | 3e9ab91e39f1a634f8d0159437d4067240b9901a | [log] [tgz] |
|---|---|---|
| author | gaaclarke <30870216+gaaclarke@users.noreply.github.com> | Fri Jul 11 09:03:42 2025 -0700 |
| committer | GitHub <noreply@github.com> | Fri Jul 11 16:03:42 2025 +0000 |
| tree | 09dc5c1f5a939979abc92b1109c1296537820f54 | |
| parent | cb4bedd58e21c4d66d11b9823d719231a87f7d57 [diff] |
Started querying the app state for the gpu disabled sync switch (#171785) Started querying the app state for the gpu disabled sync switch when starting an engine without a view controller fixes https://github.com/flutter/flutter/issues/166668 Testing: Integration test is not possible since it would require manipulation of the operating system and killing / restoring the app. Unit tests would require executing in the background or mocking out background detection which is pretty contrived and will complicate engine initialization. The simple cases will be covered with integration tests like the wide gamut devicelab tests which loads an image at startup and grabs a screenshot of it. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
diff --git a/engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterEngine.mm b/engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterEngine.mm index 0390306..ad48363 100644 --- a/engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterEngine.mm +++ b/engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterEngine.mm
@@ -848,7 +848,11 @@ ); // Disable GPU if the app or scene is running in the background. - self.isGpuDisabled = self.viewController.stateIsBackground; + self.isGpuDisabled = self.viewController + ? self.viewController.stateIsBackground + : FlutterSharedApplication.application && + FlutterSharedApplication.application.applicationState == + UIApplicationStateBackground; // Create the shell. This is a blocking operation. std::unique_ptr<flutter::Shell> shell = flutter::Shell::Create(