commit 480342899e52d44ef504962e5fca02bf075d7992
author Jonah Williams <jonahwilliams@google.com> Wed Oct 09 18:58:27 2019 -0700
committer GitHub <noreply@github.com> Wed Oct 09 18:58:27 2019 -0700
tree 4bef050036686c825a15ea7149f4db917e339b52
parent 94515ba5907bebc303433f3bb9cff38bb0dad3bd

Switch desktop build commands to use process utils (#42373)

packages/flutter_tools/lib/src/windows/build_windows.dart

diff --git a/packages/flutter_tools/lib/src/windows/build_windows.dart b/packages/flutter_tools/lib/src/windows/build_windows.dart
index 7f2f41f..6536232 100644
--- a/packages/flutter_tools/lib/src/windows/build_windows.dart
+++ b/packages/flutter_tools/lib/src/windows/build_windows.dart
@@ -5,16 +5,13 @@
 import '../artifacts.dart';
 import '../base/common.dart';
 import '../base/file_system.dart';
-import '../base/io.dart';
 import '../base/logger.dart';
-import '../base/process_manager.dart';
+import '../base/process.dart';
 import '../build_info.dart';
 import '../cache.dart';
-import '../convert.dart';
 import '../globals.dart';
 import '../project.dart';
 import '../reporting/reporting.dart';
-
 import 'msbuild_utils.dart';
 import 'visual_studio.dart';
 
@@ -63,30 +60,21 @@
   final String configuration = buildInfo.isDebug ? 'Debug' : 'Release';
   final String solutionPath = windowsProject.solutionFile.path;
   final Stopwatch sw = Stopwatch()..start();
-  // Run the script with a relative path to the project using the enclosing
-  // directory as the workingDirectory, to avoid hitting the limit on command
-  // lengths in batch scripts if the absolute path to the project is long.
-  final Process process = await processManager.start(<String>[
-    buildScript,
-    vcvarsScript,
-    fs.path.basename(solutionPath),
-    configuration,
-  ], workingDirectory: fs.path.dirname(solutionPath));
   final Status status = logger.startProgress(
     'Building Windows application...',
     timeout: null,
   );
   int result;
   try {
-    process.stderr
-      .transform(utf8.decoder)
-      .transform(const LineSplitter())
-      .listen(printError);
-    process.stdout
-      .transform(utf8.decoder)
-      .transform(const LineSplitter())
-      .listen(printTrace);
-    result = await process.exitCode;
+    // Run the script with a relative path to the project using the enclosing
+    // directory as the workingDirectory, to avoid hitting the limit on command
+    // lengths in batch scripts if the absolute path to the project is long.
+    result = await processUtils.stream(<String>[
+      buildScript,
+      vcvarsScript,
+      fs.path.basename(solutionPath),
+      configuration,
+    ], workingDirectory: fs.path.dirname(solutionPath));
   } finally {
     status.cancel();
   }