commit 4814303bf7994cba86a262539fca6cd710b6b1eb
author Vyacheslav Egorov <me@mrale.ph> Thu Feb 08 17:00:18 2018 +0100
committer GitHub <noreply@github.com> Thu Feb 08 17:00:18 2018 +0100
tree 0b9ec05f2ace019e590807ffe7a49eff903a1bcd
parent 0556e14f189ffd43ca6a948b074deea0281be4e3

Partially fix Dart 2 issues in animated_icons.test. (#14531)

Use mockito in the Dart 2 compliant way:

* use typed(...) in appropriate places to wrap matchers like any;
* don't pass matcher directly into the calls - use `argThat(matcher)`.

Also rename paintColorMatcher to hasColor to match how other similar
functions are named and how the code reads.

packages/flutter/test/material/animated_icons_test.dart

diff --git a/packages/flutter/test/material/animated_icons_test.dart b/packages/flutter/test/material/animated_icons_test.dart
index 20a15ff..8849cfe 100644
--- a/packages/flutter/test/material/animated_icons_test.dart
+++ b/packages/flutter/test/material/animated_icons_test.dart
@@ -31,7 +31,7 @@
     final CustomPaint customPaint = tester.widget(find.byType(CustomPaint));
     final MockCanvas canvas = new MockCanvas();
     customPaint.painter.paint(canvas, const Size(48.0, 48.0));
-    verify(canvas.drawPath(any, paintColorMatcher(0xFF666666)));
+    verify(canvas.drawPath(typed(any), typed(argThat(hasColor(0xFF666666)))));
   });
 
   testWidgets('IconTheme opacity', (WidgetTester tester) async {
@@ -53,7 +53,7 @@
     final CustomPaint customPaint = tester.widget(find.byType(CustomPaint));
     final MockCanvas canvas = new MockCanvas();
     customPaint.painter.paint(canvas, const Size(48.0, 48.0));
-    verify(canvas.drawPath(any, paintColorMatcher(0x80666666)));
+    verify(canvas.drawPath(typed(any), typed(argThat(hasColor(0x80666666)))));
   });
 
   testWidgets('color overrides IconTheme color', (WidgetTester tester) async {
@@ -75,7 +75,7 @@
     final CustomPaint customPaint = tester.widget(find.byType(CustomPaint));
     final MockCanvas canvas = new MockCanvas();
     customPaint.painter.paint(canvas, const Size(48.0, 48.0));
-    verify(canvas.drawPath(any, paintColorMatcher(0xFF0000FF)));
+    verify(canvas.drawPath(typed(any), typed(argThat(hasColor(0xFF0000FF)))));
   });
 
   testWidgets('IconTheme size', (WidgetTester tester) async {
@@ -185,8 +185,8 @@
     final CustomPaint customPaint = tester.widget(find.byType(CustomPaint));
     final MockCanvas canvas = new MockCanvas();
     customPaint.painter.paint(canvas, const Size(48.0, 48.0));
-    verifyNever(canvas.rotate(any));
-    verifyNever(canvas.translate(any, any));
+    verifyNever(canvas.rotate(typed(any)));
+    verifyNever(canvas.translate(typed(any), typed(any)));
   });
 
   testWidgets('Inherited text direction overridden', (WidgetTester tester) async {
@@ -215,7 +215,7 @@
   });
 }
 
-dynamic paintColorMatcher(int color) {
+PaintColorMatcher hasColor(int color) {
   return new PaintColorMatcher(color);
 }