upgrade to linter-0.1.30 (#9297)
* upgrade to linter-0.1.30
* add prefer_is_empty lint
* add directives_ordering lint
* add no_adjacent_strings_in_list lint
* add no_duplicate_case_values lint
* add prefer_collection_literals lint
* add prefer_const_constructors lint
* add prefer_contains lint
* add prefer_initializing_formals lint
* add unnecessary_null_aware_assignments lint
* add unnecessary_null_in_if_null_operators lint
diff --git a/packages/flutter/lib/rendering.dart b/packages/flutter/lib/rendering.dart
index 47900e5..a37bd24 100644
--- a/packages/flutter/lib/rendering.dart
+++ b/packages/flutter/lib/rendering.dart
@@ -22,6 +22,13 @@
/// initialized with those features.
library rendering;
+export 'package:flutter/foundation.dart' show
+ VoidCallback,
+ ValueChanged,
+ ValueGetter,
+ ValueSetter;
+export 'package:vector_math/vector_math_64.dart' show Matrix4;
+
export 'src/rendering/animated_size.dart';
export 'src/rendering/binding.dart';
export 'src/rendering/block.dart';
@@ -57,10 +64,3 @@
export 'src/rendering/viewport.dart';
export 'src/rendering/viewport_offset.dart';
export 'src/rendering/wrap.dart';
-
-export 'package:flutter/foundation.dart' show
- VoidCallback,
- ValueChanged,
- ValueGetter,
- ValueSetter;
-export 'package:vector_math/vector_math_64.dart' show Matrix4;
diff --git a/packages/flutter/lib/src/material/date_picker.dart b/packages/flutter/lib/src/material/date_picker.dart
index f95b769..1d51fe3 100644
--- a/packages/flutter/lib/src/material/date_picker.dart
+++ b/packages/flutter/lib/src/material/date_picker.dart
@@ -467,7 +467,7 @@
top: 0.0,
left: 8.0,
child: new IconButton(
- icon: new Icon(Icons.chevron_left),
+ icon: const Icon(Icons.chevron_left),
tooltip: 'Previous month',
onPressed: _isDisplayingFirstMonth ? null : _handlePreviousMonth,
),
@@ -476,7 +476,7 @@
top: 0.0,
right: 8.0,
child: new IconButton(
- icon: new Icon(Icons.chevron_right),
+ icon: const Icon(Icons.chevron_right),
tooltip: 'Next month',
onPressed: _isDisplayingLastMonth ? null : _handleNextMonth,
),
diff --git a/packages/flutter/lib/src/services/asset_bundle.dart b/packages/flutter/lib/src/services/asset_bundle.dart
index d649952..3b9aa44 100644
--- a/packages/flutter/lib/src/services/asset_bundle.dart
+++ b/packages/flutter/lib/src/services/asset_bundle.dart
@@ -9,8 +9,8 @@
import 'package:flutter/foundation.dart';
import 'package:http/http.dart' as http;
-import 'platform_messages.dart';
import 'http_client.dart';
+import 'platform_messages.dart';
/// A collection of resources used by the application.
///
diff --git a/packages/flutter/lib/src/services/system_channels.dart b/packages/flutter/lib/src/services/system_channels.dart
index 23c3936..6cef21a 100644
--- a/packages/flutter/lib/src/services/system_channels.dart
+++ b/packages/flutter/lib/src/services/system_channels.dart
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-import 'platform_channel.dart';
import 'message_codecs.dart';
+import 'platform_channel.dart';
/// Platform channels used by the Flutter system.
class SystemChannels {
diff --git a/packages/flutter/lib/src/services/text_input.dart b/packages/flutter/lib/src/services/text_input.dart
index 581c7af..ea5efab 100644
--- a/packages/flutter/lib/src/services/text_input.dart
+++ b/packages/flutter/lib/src/services/text_input.dart
@@ -7,9 +7,9 @@
import 'package:flutter/foundation.dart';
+import 'message_codec.dart';
import 'system_channels.dart';
import 'text_editing.dart';
-import 'message_codec.dart';
export 'dart:ui' show TextAffinity;
diff --git a/packages/flutter/test/foundation/serialization_test.dart b/packages/flutter/test/foundation/serialization_test.dart
index 7a8b1eb..cdb1380 100644
--- a/packages/flutter/test/foundation/serialization_test.dart
+++ b/packages/flutter/test/foundation/serialization_test.dart
@@ -2,11 +2,11 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+import 'dart:typed_data';
+
import 'package:flutter/foundation.dart';
import 'package:test/test.dart';
-import 'dart:typed_data';
-
void main() {
group('Write and read buffer round-trip', () {
test('of single byte', () {
@@ -77,4 +77,4 @@
expect(readDoubles[1], isNaN);
});
});
-}
\ No newline at end of file
+}
diff --git a/packages/flutter_tools/lib/src/android/android_workflow.dart b/packages/flutter_tools/lib/src/android/android_workflow.dart
index 8ac011d..f102519 100644
--- a/packages/flutter_tools/lib/src/android/android_workflow.dart
+++ b/packages/flutter_tools/lib/src/android/android_workflow.dart
@@ -4,8 +4,8 @@
import 'dart:async';
-import '../base/io.dart';
import '../base/file_system.dart';
+import '../base/io.dart';
import '../base/os.dart';
import '../base/platform.dart';
import '../base/process.dart';
@@ -50,7 +50,7 @@
final String javaHomeOutput = runCheckedSync(<String>['/usr/libexec/java_home'], hideStdout: true);
if (javaHomeOutput != null) {
final List<String> javaHomeOutputSplit = javaHomeOutput.split('\n');
- if ((javaHomeOutputSplit != null) && (javaHomeOutputSplit.length > 0)) {
+ if ((javaHomeOutputSplit != null) && (javaHomeOutputSplit.isNotEmpty)) {
final String javaHome = javaHomeOutputSplit[0].trim();
return fs.path.join(javaHome, 'bin', 'java');
}
diff --git a/packages/flutter_tools/lib/src/commands/fuchsia_reload.dart b/packages/flutter_tools/lib/src/commands/fuchsia_reload.dart
index aae488d..dcce29e 100644
--- a/packages/flutter_tools/lib/src/commands/fuchsia_reload.dart
+++ b/packages/flutter_tools/lib/src/commands/fuchsia_reload.dart
@@ -74,7 +74,7 @@
// Find the network ports used on the device by VM service instances.
final List<int> servicePorts = await _getServicePorts();
- if (servicePorts.length == 0) {
+ if (servicePorts.isEmpty) {
throwToolExit("Couldn't find any running Observatory instances.");
}
for (int port in servicePorts) {
@@ -85,7 +85,7 @@
// ports, and find the Isolates that are running the target app.
final String isolateName = "$_binaryName\$main";
final List<int> targetPorts = await _filterPorts(servicePorts, isolateName);
- if (targetPorts.length == 0) {
+ if (targetPorts.isEmpty) {
throwToolExit("No VMs found running $_binaryName");
}
for (int port in targetPorts) {
@@ -110,7 +110,7 @@
// Find ports where there is a view isolate with the given name
Future<List<int>> _filterPorts(List<int> ports, String isolateFilter) async {
- final List<int> result = new List<int>();
+ final List<int> result = <int>[];
for (int port in ports) {
final String addr = "http://$_address:$port";
final Uri uri = Uri.parse(addr);
@@ -206,7 +206,7 @@
final FuchsiaDeviceCommandRunner runner =
new FuchsiaDeviceCommandRunner(_fuchsiaRoot);
final List<String> lsOutput = await runner.run("ls /tmp/dart.services");
- final List<int> ports = new List<int>();
+ final List<int> ports = <int>[];
for (String s in lsOutput) {
final String trimmed = s.trim();
final int lastSpace = trimmed.lastIndexOf(' ');
diff --git a/packages/flutter_tools/lib/src/ios/mac.dart b/packages/flutter_tools/lib/src/ios/mac.dart
index 3c31e07..545fc3b 100644
--- a/packages/flutter_tools/lib/src/ios/mac.dart
+++ b/packages/flutter_tools/lib/src/ios/mac.dart
@@ -8,11 +8,11 @@
import 'package:meta/meta.dart';
import '../application_package.dart';
-import '../base/context.dart';
import '../base/common.dart';
+import '../base/context.dart';
import '../base/file_system.dart';
-import '../base/logger.dart';
import '../base/io.dart';
+import '../base/logger.dart';
import '../base/platform.dart';
import '../base/process.dart';
import '../base/process_manager.dart';
diff --git a/packages/flutter_tools/pubspec.yaml b/packages/flutter_tools/pubspec.yaml
index bd30ea2..7a2e085e 100644
--- a/packages/flutter_tools/pubspec.yaml
+++ b/packages/flutter_tools/pubspec.yaml
@@ -18,7 +18,7 @@
intl: '>=0.14.0 <0.15.0'
json_rpc_2: ^2.0.0
json_schema: 1.0.6
- linter: 0.1.30-alpha.1
+ linter: 0.1.30
meta: ^1.0.4
mustache: ^0.2.5
package_config: '>=0.1.5 <2.0.0'
diff --git a/packages/flutter_tools/test/src/runner/flutter_command_runner_test.dart b/packages/flutter_tools/test/src/runner/flutter_command_runner_test.dart
index b3d9932..d5b17fd 100644
--- a/packages/flutter_tools/test/src/runner/flutter_command_runner_test.dart
+++ b/packages/flutter_tools/test/src/runner/flutter_command_runner_test.dart
@@ -2,13 +2,12 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+import 'package:flutter_tools/src/version.dart';
import 'package:mockito/mockito.dart';
import 'package:test/test.dart';
-import 'package:flutter_tools/src/version.dart';
-
-import '../context.dart';
import '../common.dart';
+import '../context.dart';
import 'flutter_command_test.dart';
void main() {
