Double all timeouts on flutter_tools integration tests (#20872)
Due to CPU contention we've seen these go really slow on Cirrus (see https://github.com/flutter/flutter/issues/19542#issuecomment-414265152), and there's also a chance our flakes are timeouts due to running slow rather than hanging.
diff --git a/packages/flutter_tools/test/integration/expression_evaluation_test.dart b/packages/flutter_tools/test/integration/expression_evaluation_test.dart
index e68b7c2..ed0979f 100644
--- a/packages/flutter_tools/test/integration/expression_evaluation_test.dart
+++ b/packages/flutter_tools/test/integration/expression_evaluation_test.dart
@@ -110,5 +110,5 @@
// https://github.com/flutter/flutter/issues/17833
// The test appears to be flaky and time out some times, skipping while
// investigation is ongoing: https://github.com/flutter/flutter/issues/19542
- }, timeout: const Timeout.factor(3), skip: true);
+ }, timeout: const Timeout.factor(6), skip: true);
}
diff --git a/packages/flutter_tools/test/integration/flutter_attach_test.dart b/packages/flutter_tools/test/integration/flutter_attach_test.dart
index 68fb836..28d208d 100644
--- a/packages/flutter_tools/test/integration/flutter_attach_test.dart
+++ b/packages/flutter_tools/test/integration/flutter_attach_test.dart
@@ -36,5 +36,5 @@
await _flutterAttach.hotReload();
});
// TODO(dantup): Unskip after https://github.com/flutter/flutter/issues/17833.
- }, timeout: const Timeout.factor(3), skip: platform.isWindows);
+ }, timeout: const Timeout.factor(6), skip: platform.isWindows);
}
diff --git a/packages/flutter_tools/test/integration/hot_reload_test.dart b/packages/flutter_tools/test/integration/hot_reload_test.dart
index 7d721ca..57b2ce8 100644
--- a/packages/flutter_tools/test/integration/hot_reload_test.dart
+++ b/packages/flutter_tools/test/integration/hot_reload_test.dart
@@ -45,5 +45,5 @@
expect(isolate.pauseEvent, isInstanceOf<VMPauseBreakpointEvent>());
// TODO(dantup): Unskip after https://github.com/flutter/flutter/issues/18441.
}, skip: !platform.isLinux);
- }, timeout: const Timeout.factor(3));
+ }, timeout: const Timeout.factor(6));
}
diff --git a/packages/flutter_tools/test/integration/lifetime_test.dart b/packages/flutter_tools/test/integration/lifetime_test.dart
index 79576da..141223d 100644
--- a/packages/flutter_tools/test/integration/lifetime_test.dart
+++ b/packages/flutter_tools/test/integration/lifetime_test.dart
@@ -46,5 +46,5 @@
expect(_flutter.hasExited, equals(false));
});
// TODO(dantup): Unskip after https://github.com/flutter/flutter/issues/17833.
- }, timeout: const Timeout.factor(3), skip: platform.isWindows);
+ }, timeout: const Timeout.factor(6), skip: platform.isWindows);
}
diff --git a/packages/flutter_tools/test/integration/test_driver.dart b/packages/flutter_tools/test/integration/test_driver.dart
index 078d3fa..8eb1f06 100644
--- a/packages/flutter_tools/test/integration/test_driver.dart
+++ b/packages/flutter_tools/test/integration/test_driver.dart
@@ -18,9 +18,9 @@
// Set this to true for debugging to get JSON written to stdout.
const bool _printJsonAndStderr = false;
-const Duration defaultTimeout = Duration(seconds: 20);
-const Duration appStartTimeout = Duration(seconds: 60);
-const Duration quitTimeout = Duration(seconds: 5);
+const Duration defaultTimeout = Duration(seconds: 40);
+const Duration appStartTimeout = Duration(seconds: 120);
+const Duration quitTimeout = Duration(seconds: 10);
class FlutterTestDriver {
FlutterTestDriver(this._projectFolder);
