)]}'
{
  "commit": "67cfcfb6d4e93c9abd75711ea18cc4d677633d8a",
  "tree": "8a9e8e3a6dd02c840366ae92a7a577d0f6862fa7",
  "parents": [
    "7820e78090390805756acb8906fd472cc4a790da"
  ],
  "author": {
    "name": "Chris Bracken",
    "email": "chris@bracken.jp",
    "time": "Wed Aug 05 17:06:18 2026 +0900"
  },
  "committer": {
    "name": "GitHub",
    "email": "noreply@github.com",
    "time": "Wed Aug 05 08:06:18 2026 +0000"
  },
  "message": "iOS: Remove software renderer/headless fallback (#190590)\n\niOS is Impeller-only and requires iOS 15, so there is no software\nrenderer. The `IOSRenderingAPI::kSoftware` path doesn\u0027t actually render\nin software: on a simulator whose host exposed no Metal device it\nselects a no-op context and surface that draw nothing.\n\n\nThis removes that fallback and instead fails immediately when Metal is\nunavailable. This matches the existing runtime behaviour (which already\n`FML_CHECK`ed) and the macOS embedder, which refuses to start without a\nMetal device.\n\nThe no-op path was added in flutter/engine#54856 to stop\nImpeller-enabled simulators from exiting when no Metal context was\navailable. That goes back way before we bumped the minimum supported iOS\nversion to 15. Every device capable of running iOS 15 has a\nMetal-capable GPU, and a simulator requires a host with Metal support,\nso the fallback isn\u0027t necessary and a source of additional complexity\nand possibly bugs from misconfigured environments.\n\n`GPUSurfaceNoop` is now unused and `IOSRenderingAPI` is down to just one\nenum value. I\u0027ll remove both in followups.\n\nThis also fixes a lint in `IOSSurface::Create()` that was revealed by\nremoving `IOSSurfaceNoop`. `IOSSurfaceMetalImpeller` constructor takes a\n`const std::shared_ptr\u003cIOSContext\u003e\u0026`, so in this code, the move was\ndoing nothing.\n```cc\nstd::unique_ptr\u003cIOSSurface\u003e IOSSurface::Create(std::shared_ptr\u003cIOSContext\u003e context,\nreturn std::make_unique\u003cIOSSurfaceMetalImpeller\u003e(\n    static_cast\u003cCAMetalLayer*\u003e(layer),  // Metal layer\n    std::move(context)                  // context\n);\n```\nThe lint wasn\u0027t triggering before because in the same method, we were\nconstructing a fallback `IOSSurfaceNoop`, whose ctor takes a\n`std::shared_ptr\u003cIOSContext\u003e` by value, not by const ref. That move WAS\ndoing real work, but effectively covered prevented the lint from firing.\n\nIssue: https://github.com/flutter/flutter/issues/190041\n\n\u003c!--\nThanks for filing a pull request!\nReviewers are typically assigned within a week of filing a request.\nTo learn more about code review, see our documentation on Tree Hygiene:\nhttps://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md\n--\u003e\n\n\n## Pre-launch Checklist\n\n- [X] I read the [Contributor Guide] and followed the process outlined\nthere for submitting PRs.\n- [X] I read the [AI contribution guidelines] and understand my\nresponsibilities, or I am not using AI tools.\n- [X] I read the [Tree Hygiene] wiki page, which explains my\nresponsibilities.\n- [X] I read and followed the [Flutter Style Guide], including [Features\nwe expect every widget to implement].\n- [X] I signed the [CLA].\n- [X] I listed at least one issue that this PR fixes in the description\nabove.\n- [X] I updated/added relevant documentation (doc comments with `///`).\n- [X] I added new tests to check the change I am making, or this PR is\n[test-exempt].\n- [X] I followed the [breaking change policy] and added [Data Driven\nFixes] where supported.\n- [X] All existing and new tests are passing.\n\nIf you need help, consider asking for advice on the #hackers-new channel\non [Discord].\n\nIf this change needs to override an active code freeze, provide a\ncomment explaining why. The code freeze workflow can be overridden by\ncode reviewers. See pinned issues for any active code freezes with\nguidance.\n\n**Note**: The Flutter team is currently trialing the use of [Gemini Code\nAssist for\nGitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).\nComments from the `gemini-code-assist` bot should not be taken as\nauthoritative feedback from the Flutter team. If you find its comments\nuseful you can update your code accordingly, but if you are unsure or\ndisagree with the feedback, please feel free to wait for a Flutter team\nmember\u0027s review for guidance on which automated comments should be\naddressed.\n\n\u003c!-- Links --\u003e\n[Contributor Guide]:\nhttps://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview\n[AI contribution guidelines]:\nhttps://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines\n[Tree Hygiene]:\nhttps://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md\n[test-exempt]:\nhttps://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests\n[Flutter Style Guide]:\nhttps://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md\n[Features we expect every widget to implement]:\nhttps://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement\n[CLA]: https://cla.developers.google.com/\n[flutter/tests]: https://github.com/flutter/tests\n[breaking change policy]:\nhttps://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes\n[Discord]:\nhttps://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md\n[Data Driven Fixes]:\nhttps://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "52f3054d9d8af9d33a82c1051aac47747cbef88b",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/shell/platform/darwin/ios/BUILD.gn",
      "new_id": "90a1f9ac5936c79ebb6dd2ed7af24016526352a6",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/shell/platform/darwin/ios/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "25db4909ed6fa2617de31cde5c271cc42ec91ef0",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/shell/platform/darwin/ios/ios_context.mm",
      "new_id": "4b7304b4a444ab58a947b68ef979b9e2b490d29c",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/shell/platform/darwin/ios/ios_context.mm"
    },
    {
      "type": "delete",
      "old_id": "912b69ba1e48bdeeae42fe30ba70e64d5fe485f0",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/shell/platform/darwin/ios/ios_context_noop.h",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "delete",
      "old_id": "f5d2b64d07a8fa3eda5ccbac015c188a169fef60",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/shell/platform/darwin/ios/ios_context_noop.mm",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "delete",
      "old_id": "2878bea423b1701a08d97144dcd9370f75f2353a",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/shell/platform/darwin/ios/ios_context_noop_unittests.mm",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "modify",
      "old_id": "a9fd3f5f5d250b9336acea5aeea20170ff36634a",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/shell/platform/darwin/ios/ios_surface.h",
      "new_id": "5185fef8fb5c90f611cfb3067fc26e56ef4ba0ce",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/shell/platform/darwin/ios/ios_surface.h"
    },
    {
      "type": "modify",
      "old_id": "647fb77b9f9a3fbc8afed273f4be2b7c7f1fbb31",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/shell/platform/darwin/ios/ios_surface.mm",
      "new_id": "37e9cf6b41f40be75c927fab7f08dc3e7f3fdbda",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/shell/platform/darwin/ios/ios_surface.mm"
    },
    {
      "type": "delete",
      "old_id": "c97c80c356d1705fde22ff5de4ff58e0488edae5",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/shell/platform/darwin/ios/ios_surface_noop.h",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "delete",
      "old_id": "a41c5e53cd5d14482cab93982a83576625dac4aa",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/shell/platform/darwin/ios/ios_surface_noop.mm",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "delete",
      "old_id": "b85dbfedcc0102d8b53450319c96a13b0b97adbd",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/shell/platform/darwin/ios/ios_surface_noop_unittests.mm",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "modify",
      "old_id": "8af497b41212d379179a6035f875491b7b04c4ce",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/shell/platform/darwin/ios/rendering_api_selection.h",
      "new_id": "67af7a65bcc059c29b748d6642d2ff9be873f69c",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/shell/platform/darwin/ios/rendering_api_selection.h"
    },
    {
      "type": "modify",
      "old_id": "60e623475e4112750bdd3d3bcb995e136f82e3ec",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/shell/platform/darwin/ios/rendering_api_selection.mm",
      "new_id": "68fdd21278cb081619f002fc7f7fbbb0310b645e",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/shell/platform/darwin/ios/rendering_api_selection.mm"
    }
  ]
}
