commit 75c50da5f620f7b73c2ff4dea1e58bf01c0798ac
author Jonah Williams <jonahwilliams@google.com> Mon Mar 18 10:51:24 2019 -0700
committer GitHub <noreply@github.com> Mon Mar 18 10:51:24 2019 -0700
tree 9ae12ba2bc95a2e350d233f0dc4c5b6ca34264c7
parent bd697d4b5ab71c9ca94d9e0ff0850a5aa3a13448

Ensure that different formatting of ndk properties file does not crash tool (#29528)

packages/flutter_tools/lib/src/android/android_sdk.dart

diff --git a/packages/flutter_tools/lib/src/android/android_sdk.dart b/packages/flutter_tools/lib/src/android/android_sdk.dart
index 99bba9f..754b31a 100644
--- a/packages/flutter_tools/lib/src/android/android_sdk.dart
+++ b/packages/flutter_tools/lib/src/android/android_sdk.dart
@@ -216,10 +216,15 @@
           .split('\n')
           .map<String>((String line) => line.trim())
           .where((String line) => line.isNotEmpty);
-      final Map<String, String> properties = Map<String, String>.fromIterable(
-          propertiesFileLines.map<List<String>>((String line) => line.split(' = ')),
-          key: (dynamic split) => split[0],
-          value: (dynamic split) => split[1]);
+      final Map<String, String> properties = <String, String>{};
+      for (String line in propertiesFileLines) {
+        final List<String> parts = line.split(' = ');
+        if (parts.length == 2) {
+          properties[parts[0]] = parts[1];
+        } else {
+          printError('Malformed line in ndk source.properties: "$line".');
+        }
+      }
 
       if (!properties.containsKey('Pkg.Revision')) {
         throw AndroidNdkSearchError('Can not establish ndk-bundle version: $propertiesFile does not contain Pkg.Revision');