Add missing lints (#24381) * update lint list * enable sort_pub_dependencies * enable avoid_returning_null_for_void * enable flutter_style_todos
diff --git a/packages/flutter_tools/lib/src/commands/run.dart b/packages/flutter_tools/lib/src/commands/run.dart index 145e668..cb2efb9 100644 --- a/packages/flutter_tools/lib/src/commands/run.dart +++ b/packages/flutter_tools/lib/src/commands/run.dart
@@ -19,7 +19,7 @@ import '../runner/flutter_command.dart'; import 'daemon.dart'; -// TODO(flutter/flutter#23031): Test this. +// TODO(mklim): Test this, flutter/flutter#23031. abstract class RunCommandBase extends FlutterCommand { // Used by run and drive commands. RunCommandBase({ bool verboseHelp = false }) {
diff --git a/packages/flutter_tools/lib/src/commands/update_packages.dart b/packages/flutter_tools/lib/src/commands/update_packages.dart index 54594dd..b0e6cad 100644 --- a/packages/flutter_tools/lib/src/commands/update_packages.dart +++ b/packages/flutter_tools/lib/src/commands/update_packages.dart
@@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// ignore_for_file: flutter_style_todos + import 'dart:async'; import 'dart:collection';
diff --git a/packages/flutter_tools/lib/src/ios/mac.dart b/packages/flutter_tools/lib/src/ios/mac.dart index bfa1247..1847f78 100644 --- a/packages/flutter_tools/lib/src/ios/mac.dart +++ b/packages/flutter_tools/lib/src/ios/mac.dart
@@ -297,7 +297,7 @@ if (!_checkXcodeVersion()) return XcodeBuildResult(success: false); - // TODO(cbracken) remove when https://github.com/flutter/flutter/issues/20685 is fixed. + // TODO(cbracken): remove when https://github.com/flutter/flutter/issues/20685 is fixed. await setXcodeWorkspaceBuildSystem( workspaceDirectory: app.project.xcodeWorkspace, workspaceSettings: app.project.xcodeWorkspaceSharedSettings, @@ -458,7 +458,7 @@ if (line == 'all done') { // Free pipe file. tempDir?.deleteSync(recursive: true); - return null; + return; } } else { initialBuildStatus.cancel(); @@ -469,7 +469,7 @@ ); } } - return listenToScriptOutputLine(); + await listenToScriptOutputLine(); } // Trigger the start of the pipe -> stdout loop. Ignore exceptions.
diff --git a/packages/flutter_tools/lib/src/run_cold.dart b/packages/flutter_tools/lib/src/run_cold.dart index 9d301de..12e3478 100644 --- a/packages/flutter_tools/lib/src/run_cold.dart +++ b/packages/flutter_tools/lib/src/run_cold.dart
@@ -12,7 +12,7 @@ import 'resident_runner.dart'; import 'tracing.dart'; -// TODO(flutter/flutter#23031): Test this. +// TODO(mklim): Test this, flutter/flutter#23031. class ColdRunner extends ResidentRunner { ColdRunner( List<FlutterDevice> devices, {
diff --git a/packages/flutter_tools/lib/src/run_hot.dart b/packages/flutter_tools/lib/src/run_hot.dart index ded7a25..07484de 100644 --- a/packages/flutter_tools/lib/src/run_hot.dart +++ b/packages/flutter_tools/lib/src/run_hot.dart
@@ -48,7 +48,7 @@ List<Map<String, dynamic>> reports; // List has one report per Flutter view. } -// TODO(flutter/flutter#23031): Test this. +// TODO(mklim): Test this, flutter/flutter#23031. class HotRunner extends ResidentRunner { HotRunner( List<FlutterDevice> devices, {
diff --git a/packages/flutter_tools/lib/src/vmservice.dart b/packages/flutter_tools/lib/src/vmservice.dart index 633fc9d..4e355bf 100644 --- a/packages/flutter_tools/lib/src/vmservice.dart +++ b/packages/flutter_tools/lib/src/vmservice.dart
@@ -102,7 +102,7 @@ /// Used for RPC requests that should never take a long time. const Duration kShortRequestTimeout = Duration(seconds: 5); -// TODO(flutter/flutter#23031): Test this. +// TODO(mklim): Test this, flutter/flutter#23031. /// A connection to the Dart VM Service. class VMService { VMService(