[Impeller][Vulkan] Always reset per-surface host buffers on frame submit (#194827)

Fixes https://github.com/flutter/flutter/issues/194406

`GPUSurfaceVulkanImpeller` constructs its own private `AiksContext` (and
`HostBuffer` ring) per surface, rather than sharing an `AiksContext`
across surfaces like `GPUSurfaceMetalImpeller` does via `IOSContext`.
Because `GPUSurfaceVulkanImpeller::AcquireFrame` previously passed
`surface_frame.submit_info().frame_boundary` as `reset_host_buffer` on
its `SurfaceContextVK` path, any surface submitted with `frame_boundary
= false` (such as Android HCPP overlay surfaces in
`AndroidExternalViewEmbedder2`) never called `HostBuffer::Reset()`, so
it never advanced its ring index (`frame_index_`) and kept appending new
blocks to `device_buffers_[frame_index_]` without bound while the other
ring entries stayed unused.

***------------------AI pr description------------------***:

### Why fix `GPUSurfaceVulkanImpeller` instead of
`AndroidExternalViewEmbedder2`?

A `HostBuffer` ring is owned by an `AiksContext` and must be advanced
once per `(AiksContext, frame)`:
- **Shared `AiksContext`** (`GPUSurfaceMetalImpeller` via `IOSContext`,
`EmbedderExternalViewEmbedder`): multiple surfaces in a single frame
encode into the same `AiksContext` and `HostBuffer`, so
`reset_host_buffer` must be gated on `submit_info().frame_boundary` to
reset only after the final surface in the frame group is submitted.
- **Per-surface `AiksContext`** (`GPUSurfaceGLImpeller`,
`GPUSurfaceVulkanImpeller`): each `Surface` owns a dedicated
`AiksContext` and `HostBuffer` that only receives one `RenderToTarget`
call per frame, so `reset_host_buffer` must always be `true` regardless
of whether other surfaces follow in the frame.
- **Consistency across per-surface paths**: Both `GPUSurfaceGLImpeller`
(`gpu_surface_gl_impeller.cc:123`) and `GPUSurfaceVulkanImpeller`'s own
non-swapchain codepath (`gpu_surface_vulkan_impeller.cc:203`) already
hardcode `/*reset_host_buffer=*/true` for this exact reason; only the
`SurfaceContextVK` swapchain branch at line 122 was still forwarding
`surface_frame.submit_info().frame_boundary`.

Keeping `overlay_frame->set_submit_info({.frame_boundary = false})` in
`AndroidExternalViewEmbedder2` preserves accurate frame-group boundary
semantics (the overlay surface is not the final surface submitted in the
frame), while fixing `GPUSurfaceVulkanImpeller` ensures any non-boundary
surface backed by `GPUSurfaceVulkanImpeller` properly rotates its
private `HostBuffer` ring.

### Safety

- **No buffer is reused while the GPU may still read it.** `HostBuffer`
only reuses a ring entry 4 resets after it was written. Each swapchain
`AcquireNextDrawable()` first waits on the fence of the frame submitted
2 frames earlier (`kMaxPendingPresents = 2`), so with one reset per
frame, that entry's GPU work has already completed. This is the same
guarantee the root surface already relies on, since it resets every
frame.
- **Performance (zero steady-state allocations):** `HostBuffer`
pre-allocates one 1 MB `DeviceBuffer` per ring slot
(`device_buffers_[0..3]`), and `Reset()` retains the blocks used by that
frame (`size() <= current_buffer_ + 1`) while rewinding `offset_ = 0`
and advancing `frame_index_`. With `Reset()` called once per frame, the
overlay reuses its pre-allocated 1 MB blocks in place with zero new
allocations, instead of calling `CreateBuffer()` for a new 1 MB block
every time cumulative draws across frames exceed 1 MB.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

---------

Co-authored-by: Gray Mackall <mackall@google.com>
2 files changed
tree: e4a576bd1732e49bf66b59f5997fdd9797ba81e5
  1. .agents/
  2. .claude/
  3. .gemini/
  4. .github/
  5. .vscode/
  6. agent-artifacts/
  7. bin/
  8. buildtools/
  9. dev/
  10. docs/
  11. engine/
  12. examples/
  13. packages/
  14. third_party/
  15. .autoroller-preupload.sh
  16. .ci.yaml
  17. .direnv
  18. .gitattributes
  19. .gitignore
  20. analysis_options.yaml
  21. analysis_options_common.yaml
  22. AUTHORS
  23. CHANGELOG.md
  24. CODE_OF_CONDUCT.md
  25. CODEOWNERS
  26. CONTRIBUTING.ai.md
  27. CONTRIBUTING.md
  28. dartdoc_options.yaml
  29. DEPS
  30. flutter_console.bat
  31. LICENSE
  32. PATENT_GRANT
  33. pubspec.lock
  34. pubspec.yaml
  35. README.md
  36. TESTOWNERS
README.md

Flutter CI Status Discord badge Twitter handle BlueSky badge LFX Health Score CII Best Practices SLSA 1

Flutter is Google's SDK for crafting beautiful, fast user experiences for mobile, web, and desktop from a single codebase. Flutter works with existing code, is used by developers and organizations around the world, and is free and open source.

Documentation

For release and other announcements, join the flutter-announce mailing list. Our documentation also tracks breaking changes across releases.

Terms of service

The Flutter tool may occasionally download resources from Google servers. By downloading or using the Flutter SDK, you agree to the Google Terms of Service: https://policies.google.com/terms

For example, when installed from GitHub (as opposed to from a prepackaged archive), the Flutter tool will download the Dart SDK from Google servers immediately when first run, as it is used to execute the flutter tool itself. This will also occur when Flutter is upgraded (e.g. by running the flutter upgrade command).

About Flutter

We think Flutter will help you create beautiful, fast apps, with a productive, extensible and open development model, whether you're targeting iOS or Android, web, Windows, macOS, Linux or embedding it as the UI toolkit for a platform of your choice.

Beautiful user experiences

We want to enable designers to deliver their full creative vision without being forced to water it down due to limitations of the underlying framework. Flutter‘s layered architecture gives you control over every pixel on the screen and its powerful compositing capabilities let you overlay and animate graphics, video, text, and controls without limitation. Flutter includes a full set of widgets that deliver pixel-perfect experiences whether you’re building for iOS (Cupertino) or other platforms (Material), along with support for customizing or creating entirely new visual components.

Fast results

Flutter is fast. It's powered by hardware-accelerated 2D graphics libraries like Skia (which underpins Chrome and Android) and Impeller. We architected Flutter to support glitch-free, jank-free graphics at the native speed of your device.

Flutter code is powered by the world-class Dart programming language, which enables compilation to 32-bit and 64-bit ARM machine code for iOS and Android, JavaScript and WebAssembly for the web, as well as Intel x64 and ARM for desktop devices.

Productive development

Flutter offers stateful hot reload, allowing you to make changes to your code and see the results instantly without restarting your app or losing its state.

Hot reload animation

Extensible and open model

Flutter works with any development tool (or none at all), and also includes editor plug-ins for both Visual Studio Code and IntelliJ / Android Studio. Flutter provides tens of thousands of packages to speed your development, regardless of your target platform. And accessing other native code is easy, with support for both FFI (on Android, on iOS, on macOS, on Linux, and on Windows) as well as platform-specific APIs.

Flutter is a fully open-source project, and we welcome contributions. Information on how to get started can be found in our contributor guide.