commit 7c47837c2732051c99eb3c3f2d5bf13574519b8b
author Devon Carew <devoncarew@google.com> Sun May 29 15:07:41 2016 -0700
committer Devon Carew <devoncarew@google.com> Sun May 29 15:07:41 2016 -0700
tree 7f97c697320f35bfe2f42f9a3cb9b40d77f8af94
parent 26a4d7bbad417fe0c267008f527c857cfbc00bd1

show build progress; print app sizes (#4263)

* show build progress; print app sizes

* add todo

* review comments

* remove unused import

packages/flutter_tools/lib/src/ios/mac.dart

diff --git a/packages/flutter_tools/lib/src/ios/mac.dart b/packages/flutter_tools/lib/src/ios/mac.dart
index d6db90d..03ca717 100644
--- a/packages/flutter_tools/lib/src/ios/mac.dart
+++ b/packages/flutter_tools/lib/src/ios/mac.dart
@@ -97,7 +97,7 @@
   return false;
 }
 
-Future<bool> buildIOSXcodeProject(ApplicationPackage app, BuildMode mode,
+Future<XcodeBuildResult> buildXcodeProject(ApplicationPackage app, BuildMode mode,
     { bool buildForDevice, bool codesign: true }) async {
   String flutterProjectPath = Directory.current.path;
 
@@ -105,17 +105,17 @@
     printTrace('Initializing the Xcode project.');
     if ((await setupXcodeProjectHarness(flutterProjectPath, mode)) != 0) {
       printError('Could not initialize the Xcode project.');
-      return false;
+      return new XcodeBuildResult(false);
     }
   } else {
    updateXcodeLocalProperties(flutterProjectPath);
   }
 
   if (!_validateEngineRevision(app))
-    return false;
+    return new XcodeBuildResult(false);
 
   if (!_checkXcodeVersion())
-    return false;
+    return new XcodeBuildResult(false);
 
   // Before the build, all service definitions must be updated and the dylibs
   // copied over to a location that is suitable for Xcodebuild to find them.
@@ -148,20 +148,30 @@
     commands.addAll(<String>['-sdk', 'iphonesimulator', '-arch', 'x86_64']);
   }
 
-  printTrace(commands.join(' '));
-
-  ProcessResult result = Process.runSync(
-    commands.first, commands.sublist(1), workingDirectory: app.rootPath
-  );
+  RunResult result = await runAsync(commands, workingDirectory: app.rootPath);
 
   if (result.exitCode != 0) {
     if (result.stderr.isNotEmpty)
       printStatus(result.stderr);
     if (result.stdout.isNotEmpty)
       printStatus(result.stdout);
+    return new XcodeBuildResult(false);
+  } else {
+    // Look for 'clean build/Release-iphoneos/Runner.app'.
+    RegExp regexp = new RegExp(r' clean (\S*\.app)$', multiLine: true);
+    Match match = regexp.firstMatch(result.stdout);
+    String outputDir;
+    if (match != null)
+      outputDir = path.join(app.rootPath, match.group(1));
+    return new XcodeBuildResult(true, outputDir);
   }
+}
 
-  return result.exitCode == 0;
+class XcodeBuildResult {
+  XcodeBuildResult(this.success, [this.output]);
+
+  final bool success;
+  final String output;
 }
 
 final RegExp _xcodeVersionRegExp = new RegExp(r'Xcode (\d+)\..*');