Address issues raised in PR #2047
diff --git a/packages/flutter_tools/lib/src/ios/ios_workflow.dart b/packages/flutter_tools/lib/src/ios/ios_workflow.dart index 6c2026c..87fd043 100644 --- a/packages/flutter_tools/lib/src/ios/ios_workflow.dart +++ b/packages/flutter_tools/lib/src/ios/ios_workflow.dart
@@ -32,11 +32,7 @@ }; Function _xcodeVersionSatisfactory = () { - if (xcode.isInstalledAndMeetsVersionCheck) { - return ValidationType.installed; - } - - return ValidationType.missing; + return xcode.isInstalledAndMeetsVersionCheck ? ValidationType.installed : ValidationType.missing; }; Function _xcodeEulaSigned = () {
diff --git a/packages/flutter_tools/lib/src/ios/mac.dart b/packages/flutter_tools/lib/src/ios/mac.dart index e17cec5..d31160b 100644 --- a/packages/flutter_tools/lib/src/ios/mac.dart +++ b/packages/flutter_tools/lib/src/ios/mac.dart
@@ -73,17 +73,25 @@ int major = int.parse(components[0]); int minor = components.length == 1 ? 0 : int.parse(components[1]); - _xcodeVersionSatisfactory = major >= kXcodeRequiredVersionMajor && minor >= kXcodeRequiredVersionMinor; - return _xcodeVersionSatisfactory; + _xcodeVersionSatisfactory = _xcodeVersionCheckValid(major, minor); } catch (error) { _xcodeVersionSatisfactory = false; - return false; } - return false; + return _xcodeVersionSatisfactory; } } +bool _xcodeVersionCheckValid(int major, int minor) { + if (major > kXcodeRequiredVersionMajor) + return true; + + if (major == kXcodeRequiredVersionMajor) + return minor >= kXcodeRequiredVersionMinor; + + return false; +} + Future<bool> buildIOSXcodeProject(ApplicationPackage app, { bool buildForDevice }) async { String flutterProjectPath = Directory.current.path;