More const immutable classes (#9544)
* more widget const constructors
* prefer const constructors
* address review comments
diff --git a/examples/flutter_gallery/lib/demo/material/buttons_demo.dart b/examples/flutter_gallery/lib/demo/material/buttons_demo.dart
index 92fdadc..249b245 100644
--- a/examples/flutter_gallery/lib/demo/material/buttons_demo.dart
+++ b/examples/flutter_gallery/lib/demo/material/buttons_demo.dart
@@ -121,7 +121,7 @@
// Perform some action
},
),
- new FlatButton(
+ const FlatButton(
child: const Text('DISABLED'),
onPressed: null,
)
diff --git a/examples/flutter_gallery/lib/demo/material/drawer_demo.dart b/examples/flutter_gallery/lib/demo/material/drawer_demo.dart
index b922355..2647c77 100644
--- a/examples/flutter_gallery/lib/demo/material/drawer_demo.dart
+++ b/examples/flutter_gallery/lib/demo/material/drawer_demo.dart
@@ -67,7 +67,7 @@
void _showNotImplementedMessage() {
Navigator.of(context).pop(); // Dismiss the drawer.
- _scaffoldKey.currentState.showSnackBar(new SnackBar(
+ _scaffoldKey.currentState.showSnackBar(const SnackBar(
content: const Text("The drawer's items don't do anything")
));
}
diff --git a/examples/flutter_gallery/lib/demo/material/expansion_panels_demo.dart b/examples/flutter_gallery/lib/demo/material/expansion_panels_demo.dart
index e08d2da..2a0e339 100644
--- a/examples/flutter_gallery/lib/demo/material/expansion_panels_demo.dart
+++ b/examples/flutter_gallery/lib/demo/material/expansion_panels_demo.dart
@@ -108,7 +108,7 @@
)
)
),
- new Divider(height: 1.0),
+ const Divider(height: 1.0),
new Container(
padding: const EdgeInsets.symmetric(vertical: 16.0),
child: new Row(
diff --git a/examples/flutter_gallery/lib/demo/material/leave_behind_demo.dart b/examples/flutter_gallery/lib/demo/material/leave_behind_demo.dart
index d616a06..925ce96 100644
--- a/examples/flutter_gallery/lib/demo/material/leave_behind_demo.dart
+++ b/examples/flutter_gallery/lib/demo/material/leave_behind_demo.dart
@@ -103,13 +103,13 @@
},
background: new Container(
color: theme.primaryColor,
- child: new ListTile(
+ child: const ListTile(
leading: const Icon(Icons.delete, color: Colors.white, size: 36.0)
)
),
secondaryBackground: new Container(
color: theme.primaryColor,
- child: new ListTile(
+ child: const ListTile(
trailing: const Icon(Icons.archive, color: Colors.white, size: 36.0)
)
),
diff --git a/examples/flutter_gallery/lib/demo/material/menu_demo.dart b/examples/flutter_gallery/lib/demo/material/menu_demo.dart
index 44035fc..6c49b84 100644
--- a/examples/flutter_gallery/lib/demo/material/menu_demo.dart
+++ b/examples/flutter_gallery/lib/demo/material/menu_demo.dart
@@ -119,31 +119,31 @@
padding: EdgeInsets.zero,
onSelected: showMenuSelection,
itemBuilder: (BuildContext context) => <PopupMenuEntry<String>>[
- new PopupMenuItem<String>(
+ const PopupMenuItem<String>(
value: 'Preview',
- child: new ListTile(
+ child: const ListTile(
leading: const Icon(Icons.visibility),
title: const Text('Preview')
)
),
- new PopupMenuItem<String>(
+ const PopupMenuItem<String>(
value: 'Share',
- child: new ListTile(
+ child: const ListTile(
leading: const Icon(Icons.person_add),
title: const Text('Share')
)
),
- new PopupMenuItem<String>(
+ const PopupMenuItem<String>(
value: 'Get Link',
- child: new ListTile(
+ child: const ListTile(
leading: const Icon(Icons.link),
title: const Text('Get link')
)
),
const PopupMenuDivider(), // ignore: list_element_type_not_assignable, https://github.com/flutter/flutter/issues/5771
- new PopupMenuItem<String>(
+ const PopupMenuItem<String>(
value: 'Remove',
- child: new ListTile(
+ child: const ListTile(
leading: const Icon(Icons.delete),
title: const Text('Remove')
)
diff --git a/examples/flutter_gallery/lib/demo/material/slider_demo.dart b/examples/flutter_gallery/lib/demo/material/slider_demo.dart
index acd8d00..7441d67 100644
--- a/examples/flutter_gallery/lib/demo/material/slider_demo.dart
+++ b/examples/flutter_gallery/lib/demo/material/slider_demo.dart
@@ -43,7 +43,7 @@
new Column(
mainAxisSize: MainAxisSize.min,
children: <Widget> [
- new Slider(value: 0.25, thumbOpenAtMin: true, onChanged: null),
+ const Slider(value: 0.25, thumbOpenAtMin: true, onChanged: null),
const Text('Disabled'),
]
),
diff --git a/examples/flutter_gallery/lib/demo/material/tooltip_demo.dart b/examples/flutter_gallery/lib/demo/material/tooltip_demo.dart
index a6d025d..c7bd7f3 100644
--- a/examples/flutter_gallery/lib/demo/material/tooltip_demo.dart
+++ b/examples/flutter_gallery/lib/demo/material/tooltip_demo.dart
@@ -46,7 +46,7 @@
color: theme.iconTheme.color,
tooltip: 'Place a phone call',
onPressed: () {
- Scaffold.of(context).showSnackBar(new SnackBar(
+ Scaffold.of(context).showSnackBar(const SnackBar(
content: const Text('That was an ordinary tap.')
));
}
diff --git a/examples/flutter_gallery/lib/demo/material/two_level_list_demo.dart b/examples/flutter_gallery/lib/demo/material/two_level_list_demo.dart
index d152173..cc22f96 100644
--- a/examples/flutter_gallery/lib/demo/material/two_level_list_demo.dart
+++ b/examples/flutter_gallery/lib/demo/material/two_level_list_demo.dart
@@ -14,19 +14,19 @@
body: new TwoLevelList(
type: MaterialListType.oneLine,
children: <Widget>[
- new TwoLevelListItem(title: const Text('Top')),
+ const TwoLevelListItem(title: const Text('Top')),
new TwoLevelSublist(
title: const Text('Sublist'),
backgroundColor: Theme.of(context).accentColor.withOpacity(0.025),
children: <Widget>[
- new TwoLevelListItem(title: const Text('One')),
- new TwoLevelListItem(title: const Text('Two')),
+ const TwoLevelListItem(title: const Text('One')),
+ const TwoLevelListItem(title: const Text('Two')),
// https://en.wikipedia.org/wiki/Free_Four
- new TwoLevelListItem(title: const Text('Free')),
- new TwoLevelListItem(title: const Text('Four'))
+ const TwoLevelListItem(title: const Text('Free')),
+ const TwoLevelListItem(title: const Text('Four'))
]
),
- new TwoLevelListItem(title: const Text('Bottom'))
+ const TwoLevelListItem(title: const Text('Bottom'))
]
)
);
