[Android] Fix use-after-free of SurfaceControl.Transaction in HCPP (#192969)

Fixes a native `SIGABRT` in `SurfaceComposerClient::Transaction` that we
were seeing with HCPP under heavy platform view churn.

`createTransaction()` was adding the transaction to
`pendingRasterTransactions` before handing it back to native, but
`AHBSwapchainImplVK::Present()` keeps writing into it after that
(`setBuffer`, `setOnComplete`). So the platform thread could merge or
close it mid-write. Separately, nothing was holding a reference to the
Java object (`ASurfaceTransaction_fromJava` doesn't take one), so it
could also just get GC'd out from under us.

This splits creation from publication. Native now gets an unpublished
transaction, holds a global ref to it while writing, and calls
`publishTransaction` from `SurfaceTransaction::Apply()` after its last
write. If publishing fails for whatever reason (`FlutterJNI` is gone,
Java throws), we apply the transaction natively instead of dropping it,
so the completion callback still fires and we don't leak the buffer. I
don't think those paths are reachable today, but they're easy to just
handle.

On a stress test that cycles ~2,900 `SurfaceView`s per run on a low-core
emulator, this went from 24 aborts in 100 runs to 0 in 75.

It's a little awkward that the NDK only goes one direction here: there's
`ASurfaceTransaction_fromJava`, but no `toJava`. If we could create the
transaction natively and hand it to Java at the end, most of this
wouldn't be needed, might be feedback that is worth filing.

---------

Co-authored-by: Gray Mackall <mackall@google.com>
15 files changed
tree: d680b1a74252543225d7ab8bfb0f97074ca3eaa6
  1. .agents/
  2. .claude/
  3. .gemini/
  4. .github/
  5. .vscode/
  6. agent-artifacts/
  7. bin/
  8. buildtools/
  9. dev/
  10. docs/
  11. engine/
  12. examples/
  13. packages/
  14. third_party/
  15. .autoroller-preupload.sh
  16. .ci.yaml
  17. .direnv
  18. .gitattributes
  19. .gitignore
  20. analysis_options.yaml
  21. analysis_options_common.yaml
  22. AUTHORS
  23. CHANGELOG.md
  24. CODE_OF_CONDUCT.md
  25. CODEOWNERS
  26. CONTRIBUTING.ai.md
  27. CONTRIBUTING.md
  28. dartdoc_options.yaml
  29. DEPS
  30. flutter_console.bat
  31. LICENSE
  32. PATENT_GRANT
  33. pubspec.lock
  34. pubspec.yaml
  35. README.md
  36. TESTOWNERS
README.md

Flutter CI Status Discord badge Twitter handle BlueSky badge LFX Health Score CII Best Practices SLSA 1

Flutter is Google's SDK for crafting beautiful, fast user experiences for mobile, web, and desktop from a single codebase. Flutter works with existing code, is used by developers and organizations around the world, and is free and open source.

Documentation

For release and other announcements, join the flutter-announce mailing list. Our documentation also tracks breaking changes across releases.

Terms of service

The Flutter tool may occasionally download resources from Google servers. By downloading or using the Flutter SDK, you agree to the Google Terms of Service: https://policies.google.com/terms

For example, when installed from GitHub (as opposed to from a prepackaged archive), the Flutter tool will download the Dart SDK from Google servers immediately when first run, as it is used to execute the flutter tool itself. This will also occur when Flutter is upgraded (e.g. by running the flutter upgrade command).

About Flutter

We think Flutter will help you create beautiful, fast apps, with a productive, extensible and open development model, whether you're targeting iOS or Android, web, Windows, macOS, Linux or embedding it as the UI toolkit for a platform of your choice.

Beautiful user experiences

We want to enable designers to deliver their full creative vision without being forced to water it down due to limitations of the underlying framework. Flutter‘s layered architecture gives you control over every pixel on the screen and its powerful compositing capabilities let you overlay and animate graphics, video, text, and controls without limitation. Flutter includes a full set of widgets that deliver pixel-perfect experiences whether you’re building for iOS (Cupertino) or other platforms (Material), along with support for customizing or creating entirely new visual components.

Fast results

Flutter is fast. It's powered by hardware-accelerated 2D graphics libraries like Skia (which underpins Chrome and Android) and Impeller. We architected Flutter to support glitch-free, jank-free graphics at the native speed of your device.

Flutter code is powered by the world-class Dart programming language, which enables compilation to 32-bit and 64-bit ARM machine code for iOS and Android, JavaScript and WebAssembly for the web, as well as Intel x64 and ARM for desktop devices.

Productive development

Flutter offers stateful hot reload, allowing you to make changes to your code and see the results instantly without restarting your app or losing its state.

Hot reload animation

Extensible and open model

Flutter works with any development tool (or none at all), and also includes editor plug-ins for both Visual Studio Code and IntelliJ / Android Studio. Flutter provides tens of thousands of packages to speed your development, regardless of your target platform. And accessing other native code is easy, with support for both FFI (on Android, on iOS, on macOS, on Linux, and on Windows) as well as platform-specific APIs.

Flutter is a fully open-source project, and we welcome contributions. Information on how to get started can be found in our contributor guide.