commit 980f14e0c5c4979de63d1b1f568ed536706de2ad
author Alexandre Ardhuin <alexandre.ardhuin@gmail.com> Sun Nov 24 06:54:43 2019 +0100
committer GitHub <noreply@github.com> Sun Nov 24 06:54:43 2019 +0100
tree 1bd621a8534e4f4042b1da361f6fe18ae6578419
parent 033b897be5d69bd93c5eb4bb36105788caf0d3b8

implicit-casts:false on flutter_tools (#45153)

* implicit-casts:false on flutter_tools

* use castStringKeyedMap

* address review comments

* address review comments

* fix issues after rebase

packages/flutter_tools/test/general.shard/android/gradle_test.dart

diff --git a/packages/flutter_tools/test/general.shard/android/gradle_test.dart b/packages/flutter_tools/test/general.shard/android/gradle_test.dart
index 3e18716..dd0455a 100644
--- a/packages/flutter_tools/test/general.shard/android/gradle_test.dart
+++ b/packages/flutter_tools/test/general.shard/android/gradle_test.dart
@@ -1604,9 +1604,8 @@
         localGradleErrors: const <GradleHandledError>[],
       );
 
-      final BufferLogger logger = context.get<Logger>();
       expect(
-        logger.statusText,
+        testLogger.statusText,
         contains('Built build/app/outputs/apk/release/app-release.apk (0.0MB)'),
       );
 
@@ -1652,13 +1651,12 @@
         target: '',
       );
 
-      final BufferLogger logger = context.get<Logger>();
       expect(
-        logger.statusText,
+        testLogger.statusText,
         contains('Built build/outputs/repo'),
       );
       expect(
-        logger.statusText.contains('Consuming the Module'),
+        testLogger.statusText.contains('Consuming the Module'),
         isFalse,
       );
 
@@ -1745,7 +1743,7 @@
           environment: anyNamed('environment'),
           workingDirectory: anyNamed('workingDirectory')
         ),
-      ).captured.last;
+      ).captured.last as List<String>;
 
       expect(actualGradlewCall, contains('/android/gradlew'));
       expect(actualGradlewCall, contains('-Plocal-engine-out=out/android_arm'));
@@ -1821,7 +1819,7 @@
           environment: anyNamed('environment'),
           workingDirectory: anyNamed('workingDirectory'),
         ),
-      ).captured.last;
+      ).captured.last as List<String>;
 
       expect(actualGradlewCall, contains('/.android/gradlew'));
       expect(actualGradlewCall, contains('-Plocal-engine-out=out/android_arm'));
@@ -1847,9 +1845,8 @@
         repoDirectory: fs.directory('build/'),
       );
 
-      final BufferLogger logger = context.get<Logger>();
       expect(
-        logger.statusText,
+        testLogger.statusText,
         contains(
           '\n'
           'Consuming the Module\n'
@@ -1900,9 +1897,8 @@
         repoDirectory: fs.directory('build/'),
       );
 
-      final BufferLogger logger = context.get<Logger>();
       expect(
-        logger.statusText,
+        testLogger.statusText,
         contains(
           '\n'
           'Consuming the Module\n'
@@ -1940,9 +1936,8 @@
         repoDirectory: fs.directory('build/'),
       );
 
-      final BufferLogger logger = context.get<Logger>();
       expect(
-        logger.statusText,
+        testLogger.statusText,
         contains(
           '\n'
           'Consuming the Module\n'
@@ -1980,9 +1975,8 @@
         repoDirectory: fs.directory('build/'),
       );
 
-      final BufferLogger logger = context.get<Logger>();
       expect(
-        logger.statusText,
+        testLogger.statusText,
         contains(
           '\n'
           'Consuming the Module\n'
@@ -2047,7 +2041,7 @@
   return project;
 }
 
-Platform fakePlatform(String name) {
+FakePlatform fakePlatform(String name) {
   return FakePlatform.fromPlatform(const LocalPlatform())
     ..operatingSystem = name
     ..stdoutSupportsAnsi = false;