commit abba2ebc4e731246f5ec7947d0ef8c1caddbc328
author Dan Rubel <danrubel@google.com> Thu Oct 27 22:52:59 2016 +0100
committer GitHub <noreply@github.com> Thu Oct 27 22:52:59 2016 +0100
tree f22442623b0cf651fa151a0b8dcf4fb30c17ddcd
parent 311d371a973cef68324b813c3a5dcb67c5711278

cleanup test logger usage (#6560)

packages/flutter_tools/test/android_device_test.dart

diff --git a/packages/flutter_tools/test/android_device_test.dart b/packages/flutter_tools/test/android_device_test.dart
index da0e012..e5840e9 100644
--- a/packages/flutter_tools/test/android_device_test.dart
+++ b/packages/flutter_tools/test/android_device_test.dart
@@ -3,7 +3,6 @@
 // found in the LICENSE file.
 
 import 'package:flutter_tools/src/android/android_device.dart';
-import 'package:flutter_tools/src/base/logger.dart';
 import 'package:test/test.dart';
 
 import 'src/context.dart';
@@ -49,7 +48,6 @@
       expect(devices.first.name, 'Nexus 6');
     });
 
-    BufferLogger logger = new BufferLogger();
     testUsingContext('adb error message', () {
       List<AndroidDevice> devices = getAdbDevices(mockAdbOutput: '''
 It appears you do not have 'Android SDK Platform-tools' installed.
@@ -57,9 +55,7 @@
     android update sdk --no-ui --filter 'platform-tools'
 ''');
       expect(devices, hasLength(0));
-      expect(logger.errorText, contains('you do not have'));
-    }, overrides: <Type, dynamic>{
-      Logger : logger,
+      expect(testLogger.errorText, contains('you do not have'));
     });
   });
 

packages/flutter_tools/test/create_test.dart

diff --git a/packages/flutter_tools/test/create_test.dart b/packages/flutter_tools/test/create_test.dart
index dc7ad25..86ed1d4 100644
--- a/packages/flutter_tools/test/create_test.dart
+++ b/packages/flutter_tools/test/create_test.dart
@@ -7,7 +7,6 @@
 import 'dart:io';
 
 import 'package:args/command_runner.dart';
-import 'package:flutter_tools/src/base/logger.dart';
 import 'package:flutter_tools/src/cache.dart';
 import 'package:flutter_tools/src/commands/create.dart';
 import 'package:flutter_tools/src/dart/sdk.dart';
@@ -84,7 +83,6 @@
     });
 
     // Verify that we help the user correct an option ordering issue
-    BufferLogger logger = new BufferLogger();
     testUsingContext('produces sensible error message', () async {
       Cache.flutterRoot = '../..';
 
@@ -93,9 +91,7 @@
 
       int code = await runner.run(<String>['create', temp.path, '--pub']);
       expect(code, 2);
-      expect(logger.errorText, contains('Try moving --pub'));
-    }, overrides:  <Type, dynamic>{
-      Logger: logger,
+      expect(testLogger.errorText, contains('Try moving --pub'));
     });
 
     // Verify that we fail with an error code when the file exists.