)]}'
{
  "commit": "bd103b835f2fc72d16ac0658808cf545e66ebb55",
  "tree": "e31437182473cd0ca753d8ec324869b4e9cc2a70",
  "parents": [
    "d39d51c90992b0f9b5e4e00f3bf29d035a3df80c"
  ],
  "author": {
    "name": "David Bebawy",
    "email": "dbebawy@users.noreply.github.com",
    "time": "Tue Sep 29 22:30:29 2026 +0000"
  },
  "committer": {
    "name": "GitHub",
    "email": "noreply@github.com",
    "time": "Tue Sep 29 22:30:29 2026 +0000"
  },
  "message": "Remove vestigial `download_jdk` gclient var (#188571)\n\n## Summary\n\nRemoves the vestigial `download_jdk` gclient var. Closes #187627.\n\n`download_jdk` was declared in\n[DEPS:97](https://github.com/flutter/flutter/blob/master/DEPS#L97) with\ndefault `True` but **no DEPS entry ever referenced it as a condition**.\nThe only OpenJDK CIPD entry\n(`engine/src/flutter/third_party/java/openjdk`) gates only on\n`host_os`/`host_cpu`:\n\n```python\n\u0027condition\u0027: \u0027not (host_os \u003d\u003d \"linux\" and host_cpu \u003d\u003d \"arm64\")\u0027,\n```\n\nSo setting `\"download_jdk\": false` in builder configs was a no-op —\nOpenJDK was downloaded anyway on every host except linux-arm64 (which is\ncorrectly excluded by the host_cpu condition, not by `download_jdk`).\n\n## Changes\n\n- Remove the unused `download_jdk` declaration from `DEPS` (lines 91-92,\nincluding the now-misleading comment \"Checkout Java dependencies only on\nplatforms that do not have java installed on path.\")\n- Remove `\"download_jdk\": false` from 22 builder JSONs in\n`engine/src/flutter/ci/builders/`. **108 occurrences total.** None of\nthem did anything; their removal has no behavioral effect.\n\nThe OpenJDK download condition itself is unchanged. Builds that don\u0027t\nactually need the JDK (e.g. `linux_arm64_android_aot_engine`,\n`mac_clang_tidy`) still get it on linux-x64/mac hosts — if that becomes\nworth optimizing, the OpenJDK condition itself is the right place to add\na gate, not a separate variable that doesn\u0027t propagate.\n\n## Context\n\nFound while running validation builds for #187591. Filed #187627 noting\n`download_jdk: false` was being ignored. @reidbaker on the issue:\n\n\u003e \"I don\u0027t actually recall working on this. If it is not used feel free\nto delete it.\"\n\nDoing that here.\n\n## Pre-launch Checklist\n\n- [x] I read the [Contributor\nGuide](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview).\n- [x] I read the [Tree\nHygiene](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md)\nwiki page.\n- [x] I read and followed the [Flutter Style\nGuide](https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md).\n- [x] I signed the [CLA](https://cla.developers.google.com/).\n- [x] I listed at least one issue that this PR fixes in the description\nabove.\n- [x] All existing and new tests are passing.\n\n## Test plan\n\n- No behavior change. The OpenJDK package is gated only on\n`host_os/host_cpu` (unchanged); removing the unreferenced `download_jdk`\nvar and the no-op `\"download_jdk\": false` lines from builder configs\ncannot change what gets synced.\n- `python3 -c \"import json; ...\"` confirms all 22 modified JSONs still\nparse.\n- `grep -rn download_jdk DEPS engine/src/flutter/ci/` after the diff\nreturns empty.\n\nCo-authored-by: Reid Baker \u003c1063596+reidbaker@users.noreply.github.com\u003e",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "2396f98b55df6e7a7520a99796fcc20b05c49ab5",
      "old_mode": 33188,
      "old_path": "DEPS",
      "new_id": "95fb2a0ce21d5032a8a818c5d9ad3d60c8805f23",
      "new_mode": 33188,
      "new_path": "DEPS"
    },
    {
      "type": "modify",
      "old_id": "0bd5dd58eb474d5ef11422657ec3871c42899f0c",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/ci/builders/linux_arm_host_desktop_engine.json",
      "new_id": "7c03a7f847c7f7299ccc9aa197a2092a3417065d",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/ci/builders/linux_arm_host_desktop_engine.json"
    },
    {
      "type": "modify",
      "old_id": "30c551b2858d3ea71a94dd9eed188a05ac19b1e2",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/ci/builders/linux_arm_host_engine.json",
      "new_id": "8465a63a476979fd40ac229ca87dbc30d5b28e7f",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/ci/builders/linux_arm_host_engine.json"
    },
    {
      "type": "modify",
      "old_id": "78908ad8ae3f91bd897f6c99efac4bcacf758b83",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/ci/builders/linux_clang_tidy.json",
      "new_id": "a9803463e8d848e51dd802efffdcafe44904fd4d",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/ci/builders/linux_clang_tidy.json"
    },
    {
      "type": "modify",
      "old_id": "1a5856c63bd707fe384af2617305f904be388b79",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/ci/builders/linux_fuchsia.json",
      "new_id": "b4a43e2cb54adb2abf4ad777c3d49353d27478b2",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/ci/builders/linux_fuchsia.json"
    },
    {
      "type": "modify",
      "old_id": "adf1f260d5e6d5dd2d9647d47abbaeefaa2f41b4",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/ci/builders/linux_host_desktop_engine.json",
      "new_id": "6bed87d5ecc8a646b8f517372bb464e307a513f7",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/ci/builders/linux_host_desktop_engine.json"
    },
    {
      "type": "modify",
      "old_id": "5c1a5a072805389d157f0aa1b41d570a8e604b21",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/ci/builders/linux_host_engine.json",
      "new_id": "f055d1ed6102fbda57b93f6e62307396110a0b39",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/ci/builders/linux_host_engine.json"
    },
    {
      "type": "modify",
      "old_id": "fe403f19acdbee0459e7d613de5fb4f96d8ada54",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/ci/builders/linux_host_engine_ddm.json",
      "new_id": "d6833c21911edbb5111a13ed21a0e2cd69db397a",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/ci/builders/linux_host_engine_ddm.json"
    },
    {
      "type": "modify",
      "old_id": "41d3d466c621fc3cc1d5ac50aa3b753f95e2033a",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/ci/builders/linux_host_engine_test.json",
      "new_id": "1224bec1d7d9ceec254b1ffbf37ed79b7d61ef7a",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/ci/builders/linux_host_engine_test.json"
    },
    {
      "type": "modify",
      "old_id": "59ba15e12f9847493fed10918e3e7d5c8897e717",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/ci/builders/linux_unopt.json",
      "new_id": "12705c3dc96a52f00ac6e252e46fe10ae98b9882",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/ci/builders/linux_unopt.json"
    },
    {
      "type": "modify",
      "old_id": "c02a5aa8b2273201f0445ca7078c2a42deb20113",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/ci/builders/linux_web_engine_build.json",
      "new_id": "b7b2f4b04f4b451028f9b2a875833bd8be7d090a",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/ci/builders/linux_web_engine_build.json"
    },
    {
      "type": "modify",
      "old_id": "906fe1a2e0a18016bcee6efb0b83d72ee9be082d",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/ci/builders/linux_web_engine_test.json",
      "new_id": "1ce76a9da09137784ad437d5b5493908bce51769",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/ci/builders/linux_web_engine_test.json"
    },
    {
      "type": "modify",
      "old_id": "7d27bbbd15e3ef6a4426deeb4d729768667c0c25",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/ci/builders/local_engine.json",
      "new_id": "04d10624f4697d172f15b55e0334d6bf345d024a",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/ci/builders/local_engine.json"
    },
    {
      "type": "modify",
      "old_id": "86170d5d1627690ebfe695fa77251cf0862240ff",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/ci/builders/mac_android_aot_engine.json",
      "new_id": "8515aebc3b0d593ade0076a1dc4e6b5d07d3bc26",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/ci/builders/mac_android_aot_engine.json"
    },
    {
      "type": "modify",
      "old_id": "83b45574d85fbd45f08d8a27f9e9b73d187e4efa",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/ci/builders/mac_clang_tidy.json",
      "new_id": "eea18af87babb5d33ceb335fdb09bef487acc323",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/ci/builders/mac_clang_tidy.json"
    },
    {
      "type": "modify",
      "old_id": "37af67dea7561fcfbe604dff69aa9ed020012277",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/ci/builders/mac_host_engine.json",
      "new_id": "f7e48f07014cfa21b4ed253134f027a912e80a86",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/ci/builders/mac_host_engine.json"
    },
    {
      "type": "modify",
      "old_id": "770ab69212e8d2b272740a4d4e47556bb8a849cd",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/ci/builders/mac_ios_engine.json",
      "new_id": "d4ef6caaeef6814c2988f026ceb8615dbcb38539",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/ci/builders/mac_ios_engine.json"
    },
    {
      "type": "modify",
      "old_id": "f772e929d9e1172c01d2e25395ce5838af93d233",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/ci/builders/mac_ios_engine_ddm.json",
      "new_id": "c94a4a4a683ad91cb1590b25284c8ed5bbef4bfe",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/ci/builders/mac_ios_engine_ddm.json"
    },
    {
      "type": "modify",
      "old_id": "d8ca00466eb138365c3da299c2ab463a7703f13c",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/ci/builders/mac_unopt.json",
      "new_id": "4d45bda00bb49f76e9ae7fa0676006408fda7fab",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/ci/builders/mac_unopt.json"
    },
    {
      "type": "modify",
      "old_id": "d077c6ee909fbd0d20a2ca97bd6d775e4fba00e5",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/ci/builders/standalone/linux_benchmarks.json",
      "new_id": "9d80faa748a3cec7edc331b266f74a093d6c90f5",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/ci/builders/standalone/linux_benchmarks.json"
    },
    {
      "type": "modify",
      "old_id": "720bba71eeb43abc259e5cf780a474cd51ccd119",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/ci/builders/standalone/windows_unopt.json",
      "new_id": "5a4d2c24f2d21c6a777836469dd10e3329d59623",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/ci/builders/standalone/windows_unopt.json"
    },
    {
      "type": "modify",
      "old_id": "2031e1d131fc734dfd4c83d35d4abbf584fdad94",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/ci/builders/windows_arm_host_engine.json",
      "new_id": "f86deb754f3548b10cd29528945a2445e7684e78",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/ci/builders/windows_arm_host_engine.json"
    },
    {
      "type": "modify",
      "old_id": "ae9d426228d768478eade45e1494001e3e264310",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/ci/builders/windows_host_engine.json",
      "new_id": "a227043fefc64eb856da721637b9c1e531c22884",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/ci/builders/windows_host_engine.json"
    },
    {
      "type": "modify",
      "old_id": "84b40d3d093d697425ec2cf1fba1e948c985b194",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/ci/builders/windows_host_engine_test.json",
      "new_id": "52c7647c2221b02176c065f4c5266a818c0f5084",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/ci/builders/windows_host_engine_test.json"
    }
  ]
}