)]}' { "commit": "c0c75a5bc6c2de07f642d067faeba49f09e79bfd", "tree": "19ced9953a0bc9da8bef1455ef0f1f5ad89414c9", "parents": [ "49234bc0e0a6d07c1ada32b8b140d47a18b5b3cb" ], "author": { "name": "Chris Bracken", "email": "chris@bracken.jp", "time": "Tue Jul 21 23:06:45 2026 +0000" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Tue Jul 21 23:06:45 2026 +0000" }, "message": "[iOS] Remove dead parameters and no-op overrides (#189754)\n\nThis is dead-code removal now that iOS no longer offers an opt-out for\nthread-merged operation.\n\nGetRenderingAPIForProcess()\u0027s force_software parameter is false at both\ncall sites (FlutterEngine.mm, FlutterView.mm). This removes the\nparameter and its branches. The actual no-Metal-simulator software\nfallback is unchanged.\n\nPlatformViewIOS\u0027s second constructor accepts a worker_task_runner that\nit never uses. This removes the parameter.\n\nPlatformViewIOS::SetSemanticsEnabled and ::SetAccessibilityFeatures only\ncall the base-class implementation. This removes the overrides.\n\nThis is pre-work that makes an eventual embedder API migration easier.\n\nNo semantic changes, so no test semantic changes; just cleanup.\n\nIssue: https://github.com/flutter/flutter/issues/112232\n\n\u003c!--\nThanks for filing a pull request!\nReviewers are typically assigned within a week of filing a request.\nTo learn more about code review, see our documentation on Tree Hygiene:\nhttps://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md\n--\u003e\n\n\n## Pre-launch Checklist\n\n- [X] I read the [Contributor Guide] and followed the process outlined\nthere for submitting PRs.\n- [X] I read the [AI contribution guidelines] and understand my\nresponsibilities, or I am not using AI tools.\n- [X] I read the [Tree Hygiene] wiki page, which explains my\nresponsibilities.\n- [X] I read and followed the [Flutter Style Guide], including [Features\nwe expect every widget to implement].\n- [X] I signed the [CLA].\n- [X] I listed at least one issue that this PR fixes in the description\nabove.\n- [X] I updated/added relevant documentation (doc comments with `///`).\n- [X] I added new tests to check the change I am making, or this PR is\n[test-exempt].\n- [X] I followed the [breaking change policy] and added [Data Driven\nFixes] where supported.\n- [X] All existing and new tests are passing.\n\nIf you need help, consider asking for advice on the #hackers-new channel\non [Discord].\n\nIf this change needs to override an active code freeze, provide a\ncomment explaining why. The code freeze workflow can be overridden by\ncode reviewers. See pinned issues for any active code freezes with\nguidance.\n\n**Note**: The Flutter team is currently trialing the use of [Gemini Code\nAssist for\nGitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).\nComments from the `gemini-code-assist` bot should not be taken as\nauthoritative feedback from the Flutter team. If you find its comments\nuseful you can update your code accordingly, but if you are unsure or\ndisagree with the feedback, please feel free to wait for a Flutter team\nmember\u0027s review for guidance on which automated comments should be\naddressed.\n\n\u003c!-- Links --\u003e\n[Contributor Guide]:\nhttps://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview\n[AI contribution guidelines]:\nhttps://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines\n[Tree Hygiene]:\nhttps://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md\n[test-exempt]:\nhttps://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests\n[Flutter Style Guide]:\nhttps://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md\n[Features we expect every widget to implement]:\nhttps://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement\n[CLA]: https://cla.developers.google.com/\n[flutter/tests]: https://github.com/flutter/tests\n[breaking change policy]:\nhttps://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes\n[Discord]:\nhttps://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md\n[Data Driven Fixes]:\nhttps://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md", "tree_diff": [ { "type": "modify", "old_id": "3d31797785a8b914562d4a2df5bef02d41da07ae", "old_mode": 33188, "old_path": "engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterEngine.mm", "new_id": "1bf55855a7ff8848d6e63dc3908211b5dffe8cb6", "new_mode": 33188, "new_path": "engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterEngine.mm" }, { "type": "modify", "old_id": "f0d7498d2d3ae7f0f0a74fb6c72c82df81efd613", "old_mode": 33188, "old_path": "engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterEnginePlatformViewTest.mm", "new_id": "7cc1366bac68bf71fcea9ec956014a21a982da97", "new_mode": 33188, "new_path": "engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterEnginePlatformViewTest.mm" }, { "type": "modify", "old_id": "517f923e8309d44b61f47cfe3cfbcdcba2c0e430", "old_mode": 33188, "old_path": "engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterPlatformViewsTest.mm", "new_id": "e9f822223f9399578d5363b75fe1eecbfd39d191", "new_mode": 33188, "new_path": "engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterPlatformViewsTest.mm" }, { "type": "modify", "old_id": "4b942fe9e19c033da1860485c0c24fa416050840", "old_mode": 33188, "old_path": "engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterTextInputPluginTest.mm", "new_id": "8f00a4a449f5ddf9d29fec64fc6de6e82f4ee88d", "new_mode": 33188, "new_path": "engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterTextInputPluginTest.mm" }, { "type": "modify", "old_id": "a3756745694c593baa88dc4fb4cccede1b21394c", "old_mode": 33188, "old_path": "engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterView.mm", "new_id": "4e93dd30b57d38de5b2dcac58c3f6ab923de72d1", "new_mode": 33188, "new_path": "engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterView.mm" }, { "type": "modify", "old_id": "1074e0246df0115db88d2cbdf20dd7ca4545002e", "old_mode": 33188, "old_path": "engine/src/flutter/shell/platform/darwin/ios/framework/Source/accessibility_bridge_test.mm", "new_id": "40be0c6eff884a56ab2fa7d24df650b7637b8b30", "new_mode": 33188, "new_path": "engine/src/flutter/shell/platform/darwin/ios/framework/Source/accessibility_bridge_test.mm" }, { "type": "modify", "old_id": "29a154e06e91139bdc76bbc6e82f717f8f123931", "old_mode": 33188, "old_path": "engine/src/flutter/shell/platform/darwin/ios/platform_view_ios.h", "new_id": "51a387032cb7eabdbbbddad878134b4f6783b7a8", "new_mode": 33188, "new_path": "engine/src/flutter/shell/platform/darwin/ios/platform_view_ios.h" }, { "type": "modify", "old_id": "fbe96a544a9c4b5eb582cdea4495bacd2cf8f810", "old_mode": 33188, "old_path": "engine/src/flutter/shell/platform/darwin/ios/platform_view_ios.mm", "new_id": "814b380f0e213f99da4cd1af4242a38f080c7cd2", "new_mode": 33188, "new_path": "engine/src/flutter/shell/platform/darwin/ios/platform_view_ios.mm" }, { "type": "modify", "old_id": "7bc52a28598b5ac51fb353b16cb737eb70a3de30", "old_mode": 33188, "old_path": "engine/src/flutter/shell/platform/darwin/ios/platform_view_ios_test.mm", "new_id": "87cb679e7babb5770d92cd49f02004f2cb9d5ffa", "new_mode": 33188, "new_path": "engine/src/flutter/shell/platform/darwin/ios/platform_view_ios_test.mm" }, { "type": "modify", "old_id": "54c4b9049944cda27e2eeae597523e62c40260f0", "old_mode": 33188, "old_path": "engine/src/flutter/shell/platform/darwin/ios/rendering_api_selection.h", "new_id": "a285657dca883b1ac804944ee39d71b2e237059f", "new_mode": 33188, "new_path": "engine/src/flutter/shell/platform/darwin/ios/rendering_api_selection.h" }, { "type": "modify", "old_id": "5c77f93c117dcc85f48ac65875e8f703a1c11a63", "old_mode": 33188, "old_path": "engine/src/flutter/shell/platform/darwin/ios/rendering_api_selection.mm", "new_id": "60e623475e4112750bdd3d3bcb995e136f82e3ec", "new_mode": 33188, "new_path": "engine/src/flutter/shell/platform/darwin/ios/rendering_api_selection.mm" } ] }