)]}'
{
  "commit": "c60e5ba00e14188a0c11b5527f42f1fa4c42ca7b",
  "tree": "5cf83399e344cba5aec2f12b0856160f43fc1ad8",
  "parents": [
    "9308c50b8969e3d4a3bf0f6e07fd3dd6aaa510ab"
  ],
  "author": {
    "name": "Jim Graham",
    "email": "flar@google.com",
    "time": "Tue May 05 19:49:38 2026 -0700"
  },
  "committer": {
    "name": "GitHub",
    "email": "noreply@github.com",
    "time": "Wed May 06 02:49:38 2026 +0000"
  },
  "message": "[Impeller] Clarify CoversArea behavior and change arg to IRect (#186094)\n\nWhile reviewing https://github.com/flutter/flutter/pull/185760 it became\nclear that callers of the `Geometry::CoversArea` method were\nconstructing floating point rectangles when their query related to a\nsimple whole-integer region of pixels and that implementations might\ncomplicate themselves in order to verify containment of arbitrary\nfloating point regions due to a lack of clarity in the method\u0027s\ndocumentation and argument types.\n\nThis PR updates the method signature to take an `IRect` instead of a\n`Rect` and clarifies that the argument will (implicitly) contain a\nregion of whole pixels to be covered by the geometry.\n\nA new `Rect::Contains(IRect)` method enables the containment tests\nwithout having to convert the argument. Tests are included for this new\nmethod.\n\nFixes: https://github.com/flutter/flutter/issues/186014\n\n## Pre-launch Checklist\n\n- [x] I read the [Contributor Guide] and followed the process outlined\nthere for submitting PRs.\n- [x] I read the [AI contribution guidelines] and understand my\nresponsibilities, or I am not using AI tools.\n- [x] I read the [Tree Hygiene] wiki page, which explains my\nresponsibilities.\n- [x] I read and followed the [Flutter Style Guide], including [Features\nwe expect every widget to implement].\n- [x] I signed the [CLA].\n- [x] I listed at least one issue that this PR fixes in the description\nabove.\n- [x] I updated/added relevant documentation (doc comments with `///`).\n- [x] I added new tests to check the change I am making, or this PR is\n[test-exempt].\n- [x] I followed the [breaking change policy] and added [Data Driven\nFixes] where supported.\n- [x] All existing and new tests are passing.\n\nIf you need help, consider asking for advice on the #hackers-new channel\non [Discord].\n\nIf this change needs to override an active code freeze, provide a\ncomment explaining why. The code freeze workflow can be overridden by\ncode reviewers. See pinned issues for any active code freezes with\nguidance.\n\n**Note**: The Flutter team is currently trialing the use of [Gemini Code\nAssist for\nGitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).\nComments from the `gemini-code-assist` bot should not be taken as\nauthoritative feedback from the Flutter team. If you find its comments\nuseful you can update your code accordingly, but if you are unsure or\ndisagree with the feedback, please feel free to wait for a Flutter team\nmember\u0027s review for guidance on which automated comments should be\naddressed.",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "5b79897c7fbc7ca7b61cddff53d93036a9212db9",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/impeller/entity/contents/solid_color_contents.cc",
      "new_id": "deee5cce806ae87e3e95c752cd80d5dd90f0cffa",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/impeller/entity/contents/solid_color_contents.cc"
    },
    {
      "type": "modify",
      "old_id": "f07c9f5da6c2673845760988db07feeecdcacfd5",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/impeller/entity/contents/uber_sdf_contents.cc",
      "new_id": "d4f56cccb6a291e1d0555667afa109e7afdb9b5e",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/impeller/entity/contents/uber_sdf_contents.cc"
    },
    {
      "type": "modify",
      "old_id": "926dda3035636055704529e63fe4e51fa43f7300",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/impeller/entity/geometry/arc_geometry.cc",
      "new_id": "ce426a8dba57d87fabfa406057ca6141d7e785bc",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/impeller/entity/geometry/arc_geometry.cc"
    },
    {
      "type": "modify",
      "old_id": "f1b02d6d027f3b141a4381cb25f66a7eafa3accb",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/impeller/entity/geometry/arc_geometry.h",
      "new_id": "9710b2701acd4fea2fccad4feda57cff99bb13b8",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/impeller/entity/geometry/arc_geometry.h"
    },
    {
      "type": "modify",
      "old_id": "665e79e20d6ac245953708247860706fa1faeef9",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/impeller/entity/geometry/circle_geometry.cc",
      "new_id": "f0296a52c9f7cb317841d56546b3855bdbb9de27",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/impeller/entity/geometry/circle_geometry.cc"
    },
    {
      "type": "modify",
      "old_id": "38eadff14a4f97f5d4c98b641a0480e6e1ed30ef",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/impeller/entity/geometry/circle_geometry.h",
      "new_id": "4e302c574893b15cf98f5b596777561c46ffaba4",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/impeller/entity/geometry/circle_geometry.h"
    },
    {
      "type": "modify",
      "old_id": "a31f459f56e599aaf4e42e3241ff54d6e4027b3f",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/impeller/entity/geometry/cover_geometry.cc",
      "new_id": "8a42256e34ffc811488488368556c76d0d27b598",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/impeller/entity/geometry/cover_geometry.cc"
    },
    {
      "type": "modify",
      "old_id": "4be6359acf9468d05498811f97551d5bdfb7da4e",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/impeller/entity/geometry/cover_geometry.h",
      "new_id": "3ba1ac2e1751c9541bbf379c52445507b85d27b7",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/impeller/entity/geometry/cover_geometry.h"
    },
    {
      "type": "modify",
      "old_id": "fd8d5290391afc4dfa4f400d6b00d0656d301e92",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/impeller/entity/geometry/ellipse_geometry.cc",
      "new_id": "c829a62214da38a5b3ba44f82c7c25c22c96a169",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/impeller/entity/geometry/ellipse_geometry.cc"
    },
    {
      "type": "modify",
      "old_id": "3333d265b7bef6708dfa8104f2398c99ec6a5609",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/impeller/entity/geometry/ellipse_geometry.h",
      "new_id": "11d77d83de377131708a3db2c05af3692e8752d0",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/impeller/entity/geometry/ellipse_geometry.h"
    },
    {
      "type": "modify",
      "old_id": "e2af972297a4e0b2dc3025e40479f81b66b540e3",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/impeller/entity/geometry/fill_path_geometry.cc",
      "new_id": "01612b5d13f3a7e62fad77e6de88ecd5214d2108",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/impeller/entity/geometry/fill_path_geometry.cc"
    },
    {
      "type": "modify",
      "old_id": "3a3346d18b358b53597659fe0fbc6fc2ec2c27eb",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/impeller/entity/geometry/fill_path_geometry.h",
      "new_id": "87e026dcdcd2cce0090a56aab38c05157f61c340",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/impeller/entity/geometry/fill_path_geometry.h"
    },
    {
      "type": "modify",
      "old_id": "eb43edd90e4b8d87e12a8fd1dad6e83dafc5013c",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/impeller/entity/geometry/geometry.cc",
      "new_id": "9b4d68a00016dc8a29e22b353b2a3d0e521107de",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/impeller/entity/geometry/geometry.cc"
    },
    {
      "type": "modify",
      "old_id": "f170c60c46bfdc47e4988dde09f36d87fdb17670",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/impeller/entity/geometry/geometry.h",
      "new_id": "966ec4bcfa162acab89f0e40c76418e3989f1783",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/impeller/entity/geometry/geometry.h"
    },
    {
      "type": "modify",
      "old_id": "3455b1c3ae95f2d6be874100b8d5b38cf8e1ed24",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/impeller/entity/geometry/geometry_unittests.cc",
      "new_id": "d4cc85168ae933d6c3589784250a1e99ef2604d2",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/impeller/entity/geometry/geometry_unittests.cc"
    },
    {
      "type": "modify",
      "old_id": "da07996fcaadbd3faa19c1e58f34f595dddbab7f",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/impeller/entity/geometry/line_geometry.cc",
      "new_id": "3664645b38f5400d095c000202dacc9f65fb2781",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/impeller/entity/geometry/line_geometry.cc"
    },
    {
      "type": "modify",
      "old_id": "1afa517e7342d7179a54107f5deae19e0652ada3",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/impeller/entity/geometry/line_geometry.h",
      "new_id": "595acea8e5ee721d7bb09f60ff763575e0054044",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/impeller/entity/geometry/line_geometry.h"
    },
    {
      "type": "modify",
      "old_id": "a1aaf0a1149ad9252ff2e9a5e338e12817ac9b81",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/impeller/entity/geometry/rect_geometry.cc",
      "new_id": "5a92b897a02bb58f33a3bc2e04e453824e44d2af",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/impeller/entity/geometry/rect_geometry.cc"
    },
    {
      "type": "modify",
      "old_id": "d73ed3b5ac5bbc244786b47c31a17233709670cb",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/impeller/entity/geometry/rect_geometry.h",
      "new_id": "e03fe2b8bdaeb62182b607069ab8f76da942b857",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/impeller/entity/geometry/rect_geometry.h"
    },
    {
      "type": "modify",
      "old_id": "61334d3460dd3122aa00d23b113c3c5d8620c99c",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/impeller/entity/geometry/round_rect_geometry.cc",
      "new_id": "7385c24dbccc064e0f730ecd66785a0a393459a2",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/impeller/entity/geometry/round_rect_geometry.cc"
    },
    {
      "type": "modify",
      "old_id": "6b4b612d67a85e783b053161e08a57853ff7ff93",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/impeller/entity/geometry/round_rect_geometry.h",
      "new_id": "08a809f46f71874655613e5767cc8ed5e603b0b3",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/impeller/entity/geometry/round_rect_geometry.h"
    },
    {
      "type": "modify",
      "old_id": "72dea467d2fa34048d55fcbb5a723f7302177e30",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/impeller/entity/geometry/round_superellipse_geometry.cc",
      "new_id": "0fb36bd7640833c511756c1a1d3442dc7b0d729f",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/impeller/entity/geometry/round_superellipse_geometry.cc"
    },
    {
      "type": "modify",
      "old_id": "9020d03adbef856575fa348d6a29a8bfccde6a17",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/impeller/entity/geometry/round_superellipse_geometry.h",
      "new_id": "fe14c687b813b2679122f702890699102a377241",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/impeller/entity/geometry/round_superellipse_geometry.h"
    },
    {
      "type": "modify",
      "old_id": "ebecab0a50fb5d644e5ed77ec2adde74cb5a33b1",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/impeller/entity/geometry/superellipse_geometry.cc",
      "new_id": "190f55a4c3ac4cf6b1a10af6d61ab09a33d6e6e5",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/impeller/entity/geometry/superellipse_geometry.cc"
    },
    {
      "type": "modify",
      "old_id": "b01845bac57b1f0ef25d546bfb6e98044f6af8f1",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/impeller/entity/geometry/superellipse_geometry.h",
      "new_id": "f290ee407782eb8d1d020574d636d58cdb7c3ce5",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/impeller/entity/geometry/superellipse_geometry.h"
    },
    {
      "type": "modify",
      "old_id": "855c4813950c3485abb3a532dd42aa5a5c420c4c",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/impeller/entity/geometry/uber_sdf_geometry.cc",
      "new_id": "6463fb90613005e9407ca399f810d58b33102d3e",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/impeller/entity/geometry/uber_sdf_geometry.cc"
    },
    {
      "type": "modify",
      "old_id": "afc6adadf4f51ef25ebb7aeeb401b5227557ac1d",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/impeller/entity/geometry/uber_sdf_geometry.h",
      "new_id": "badfb357dc415be7fbb52acc875cf3fb4e703216",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/impeller/entity/geometry/uber_sdf_geometry.h"
    },
    {
      "type": "modify",
      "old_id": "564d705b3229c7e91d8d92b8efffb72b11eff7b9",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/impeller/geometry/rect.h",
      "new_id": "9756130668491e8249c91a192e4bcf1d82ed8ba4",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/impeller/geometry/rect.h"
    },
    {
      "type": "modify",
      "old_id": "871cc4b919e1b2fc3a6eb89eb1d264b6f3a8eba0",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/impeller/geometry/rect_unittests.cc",
      "new_id": "cf99cbc20758d18d438232a95ae758ce5fcb66f7",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/impeller/geometry/rect_unittests.cc"
    }
  ]
}