)]}'
{
  "commit": "ca7bea93c72dfe9bde825a9f039ca994ff9bfa4a",
  "tree": "87ce11f67f163c8ecb7fdf66585d077ecbea033f",
  "parents": [
    "b29df1dcd1c064c2c0727cab610ae1dd733594e8"
  ],
  "author": {
    "name": "Chris Bracken",
    "email": "chris@bracken.jp",
    "time": "Tue Aug 04 07:18:34 2026 +0900"
  },
  "committer": {
    "name": "GitHub",
    "email": "noreply@github.com",
    "time": "Mon Aug 03 22:18:34 2026 +0000"
  },
  "message": "iOS: Eliminate use of IOSContextNoop in platform view tests (#190419)\n\n`FlutterPlatformViewsTest` used the internal engine class\n`flutter::IOSContextNoop` in a dozen places purely as a no-op context to\nhand to `submitFrame:withIosContext:`. This replaces those with a local\n`FakeIOSContext` that replicates the behaviour the tests rely on so that\nwe can delete `IOSContextNoop` in a follow-up.\n\nLike `IOSContextNoop` `FakeIOSContext` reports the Impeller backend and\nreturns no external texture, and inherits the null Impeller/Aiks\ncontexts from the base class. The one place that uses the engine\u0027s real\ncontext (`GetIosContext`) is left untouched. I suspect we can eventually\nmove this code to use the real Metal backend but for now, this is just\nrefactoring with no semantic change.\n\nBack in ancient times, before the simulator required Metal, and when iOS\nstill had a Skia software renderer, we ran that on the Simulator due to\nsome issues with our OpenGL implementation. Later, Flutter on iOS\nmigrated from Skia to Impeller. Skia supports a software backend but\nImpeller did not, and so when running on Impeller, we stubbed out the\nsoftware backend to no-op context/surfaces, hence IOSContextNoop and\nIOSSurfaceNoop. The Simulator now *requires* Metal and Flutter has\neliminated Skia support altogether so there\u0027s no longer a software mode\nat all, nor a need for a no-op path in case you\u0027re using Impeller and\nask for a software backend.\n\nThis is part of a series of changes to remove the dead no-op fallback.\n\nNo behavioural change; just a test refactoring.\n\nIssue: https://github.com/flutter/flutter/issues/190041\n\n\u003c!--\nThanks for filing a pull request!\nReviewers are typically assigned within a week of filing a request.\nTo learn more about code review, see our documentation on Tree Hygiene:\nhttps://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md\n--\u003e\n\n## Pre-launch Checklist\n\n- [X] I read the [Contributor Guide] and followed the process outlined\nthere for submitting PRs.\n- [X] I read the [AI contribution guidelines] and understand my\nresponsibilities, or I am not using AI tools.\n- [X] I read the [Tree Hygiene] wiki page, which explains my\nresponsibilities.\n- [X] I read and followed the [Flutter Style Guide], including [Features\nwe expect every widget to implement].\n- [X] I signed the [CLA].\n- [X] I listed at least one issue that this PR fixes in the description\nabove.\n- [X] I updated/added relevant documentation (doc comments with `///`).\n- [X] I added new tests to check the change I am making, or this PR is\n[test-exempt].\n- [X] I followed the [breaking change policy] and added [Data Driven\nFixes] where supported.\n- [X] All existing and new tests are passing.\n\nIf you need help, consider asking for advice on the #hackers-new channel\non [Discord].\n\nIf this change needs to override an active code freeze, provide a\ncomment explaining why. The code freeze workflow can be overridden by\ncode reviewers. See pinned issues for any active code freezes with\nguidance.\n\n**Note**: The Flutter team is currently trialing the use of [Gemini Code\nAssist for\nGitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).\nComments from the `gemini-code-assist` bot should not be taken as\nauthoritative feedback from the Flutter team. If you find its comments\nuseful you can update your code accordingly, but if you are unsure or\ndisagree with the feedback, please feel free to wait for a Flutter team\nmember\u0027s review for guidance on which automated comments should be\naddressed.\n\n\u003c!-- Links --\u003e\n[Contributor Guide]:\nhttps://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview\n[AI contribution guidelines]:\nhttps://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines\n[Tree Hygiene]:\nhttps://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md\n[test-exempt]:\nhttps://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests\n[Flutter Style Guide]:\nhttps://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md\n[Features we expect every widget to implement]:\nhttps://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement\n[CLA]: https://cla.developers.google.com/\n[flutter/tests]: https://github.com/flutter/tests\n[breaking change policy]:\nhttps://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes\n[Discord]:\nhttps://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md\n[Data Driven Fixes]:\nhttps://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "1fdcb42de2585e53d80d7bae60da28fe6afab353",
      "old_mode": 33188,
      "old_path": "engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterPlatformViewsTest.mm",
      "new_id": "aa676568e4ef0d13ebe8ef3e24ac43c80f233d5b",
      "new_mode": 33188,
      "new_path": "engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterPlatformViewsTest.mm"
    }
  ]
}
