commit cb867bbedc31c3be5796f9ebcdb7c147e97d2f17
author Michael Goderbauer <goderbauer@google.com> Fri Mar 05 18:38:15 2021 -0800
committer GitHub <noreply@github.com> Fri Mar 05 18:38:15 2021 -0800
tree 8c12a33603bf061f23f67a16a720e71e779a140d
parent 8a9042ba91697eda954e99fcec1f08166365ace2

Enable unnecessary_await_in_return lint (#77434)

dev/bots/analyze.dart

diff --git a/dev/bots/analyze.dart b/dev/bots/analyze.dart
index aeee35d..b31f040 100644
--- a/dev/bots/analyze.dart
+++ b/dev/bots/analyze.dart
@@ -1203,7 +1203,7 @@
 Future<void> _runFlutterAnalyze(String workingDirectory, {
   List<String> options = const <String>[],
 }) async {
-  return await runCommand(
+  return runCommand(
     flutter,
     <String>['analyze', '--dartdocs', ...options],
     workingDirectory: workingDirectory,
@@ -1214,7 +1214,7 @@
 final RegExp _importMetaPattern = RegExp(r'''^\s*import (['"])package:meta/meta\.dart\1''');
 
 Future<Set<String>> _findFlutterDependencies(String srcPath, List<String> errors, { bool checkForMeta = false }) async {
-  return await _allFiles(srcPath, 'dart', minimumMatches: 1)
+  return _allFiles(srcPath, 'dart', minimumMatches: 1)
     .map<Set<String>>((File file) {
       final Set<String> result = <String>{};
       for (final String line in file.readAsLinesSync()) {

dev/bots/prepare_package.dart

diff --git a/dev/bots/prepare_package.dart b/dev/bots/prepare_package.dart
index 8129efb..adf3344 100644
--- a/dev/bots/prepare_package.dart
+++ b/dev/bots/prepare_package.dart
@@ -669,7 +669,7 @@
     if (dest.endsWith('.json')) {
       mimeType = 'application/json';
     }
-    return await _runGsUtil(<String>[
+    return _runGsUtil(<String>[
       // Use our preferred MIME type for the files we care about
       // and let gsutil figure it out for anything else.
       if (mimeType != null) ...<String>['-h', 'Content-Type:$mimeType'],

dev/bots/test/prepare_package_test.dart

diff --git a/dev/bots/test/prepare_package_test.dart b/dev/bots/test/prepare_package_test.dart
index f1d55b9..d80b2f1 100644
--- a/dev/bots/test/prepare_package_test.dart
+++ b/dev/bots/test/prepare_package_test.dart
@@ -377,7 +377,7 @@
           '$gsutilCall -- stat $gsArchivePath': <ProcessResult>[ProcessResult(0, 0, '', '')],
         };
         processManager.fakeResults = calls;
-        expect(() async => await publisher.publishArchive(false), throwsException);
+        expect(() async => publisher.publishArchive(false), throwsException);
         processManager.verifyCalls(calls.keys.toList());
       });
 

dev/bots/unpublish_package.dart

diff --git a/dev/bots/unpublish_package.dart b/dev/bots/unpublish_package.dart
index 43ccc6e..799211d 100644
--- a/dev/bots/unpublish_package.dart
+++ b/dev/bots/unpublish_package.dart
@@ -383,7 +383,7 @@
       if (mimeType != null) ...<String>['-h', 'Content-Type:$mimeType'],
       ...<String>['cp', src, dest],
     ];
-    return await _runGsUtil(args, confirm: confirmed);
+    return _runGsUtil(args, confirm: confirmed);
   }
 }