ToDo Audit - Cupertino+ Library (#54798)
diff --git a/dev/tools/dartdoc.dart b/dev/tools/dartdoc.dart
index de2f59e..7c1099c 100644
--- a/dev/tools/dartdoc.dart
+++ b/dev/tools/dartdoc.dart
@@ -50,11 +50,7 @@
final StringBuffer buf = StringBuffer();
buf.writeln('name: Flutter');
buf.writeln('homepage: https://flutter.dev');
- // TODO(dnfield): We should make DartDoc able to avoid emitting this. If we
- // use the real value here, every file will get marked as new instead of only
- // files that have otherwise changed. Instead, we replace it dynamically using
- // JavaScript so that fewer files get marked as changed.
- // https://github.com/dart-lang/dartdoc/issues/1982
+ // TODO(dnfield): Re-factor for proper versioning, https://github.com/flutter/flutter/issues/55409
buf.writeln('version: 0.0.0');
buf.writeln('dependencies:');
for (final String package in findPackageNames()) {
diff --git a/dev/tracing_tests/test/image_cache_tracing_test.dart b/dev/tracing_tests/test/image_cache_tracing_test.dart
index 6eac376..e808dd0 100644
--- a/dev/tracing_tests/test/image_cache_tracing_test.dart
+++ b/dev/tracing_tests/test/image_cache_tracing_test.dart
@@ -99,7 +99,7 @@
return true;
}
-// TODO(dnfield): we can drop this in favor of vm_service when https://github.com/dart-lang/webdev/issues/899 is resolved.
+// TODO(dnfield): This can be removed in favor of using the vm_service package, https://github.com/flutter/flutter/issues/55411
class TimelineObtainer {
WebSocket _observatorySocket;
int _lastCallId = 0;
diff --git a/examples/catalog/test/custom_semantics_test.dart b/examples/catalog/test/custom_semantics_test.dart
index 329117b..dd82176 100644
--- a/examples/catalog/test/custom_semantics_test.dart
+++ b/examples/catalog/test/custom_semantics_test.dart
@@ -18,10 +18,7 @@
await tester.pump();
// Verify it correctly exposes its semantics.
- // TODO(goderbauer): Use `SemanticsTester` after https://github.com/flutter/flutter/issues/12286.
- final SemanticsNode semantics = tester
- .renderObject(find.byType(AdjustableDropdownListTile))
- .debugSemantics;
+ final SemanticsNode semantics = tester.getSemantics(find.byType(AdjustableDropdownListTile));
expectAdjustable(semantics,
hasIncreaseAction: true,
diff --git a/packages/flutter/lib/src/cupertino/action_sheet.dart b/packages/flutter/lib/src/cupertino/action_sheet.dart
index bb57b25..c025812 100644
--- a/packages/flutter/lib/src/cupertino/action_sheet.dart
+++ b/packages/flutter/lib/src/cupertino/action_sheet.dart
@@ -937,13 +937,15 @@
Widget build(BuildContext context) {
return _ActionButtonParentDataWidget(
isPressed: _isPressed,
- // TODO(mattcarroll): Button press dynamics need overhaul for iOS: https://github.com/flutter/flutter/issues/19786
+ // TODO(mattcarroll): Button press dynamics need overhaul for iOS:
+ // https://github.com/flutter/flutter/issues/19786
child: GestureDetector(
excludeFromSemantics: true,
behavior: HitTestBehavior.opaque,
onTapDown: (TapDownDetails details) => setState(() => _isPressed = true),
onTapUp: (TapUpDetails details) => setState(() => _isPressed = false),
- // TODO(mattcarroll): Cancel is currently triggered when user moves past slop instead of off button: https://github.com/flutter/flutter/issues/19783
+ // TODO(mattcarroll): Cancel is currently triggered when user moves past
+ // slop instead of off button: https://github.com/flutter/flutter/issues/19783
onTapCancel: () => setState(() => _isPressed = false),
child: widget.child,
),
diff --git a/packages/flutter/lib/src/cupertino/context_menu.dart b/packages/flutter/lib/src/cupertino/context_menu.dart
index 68d462e..68f3089 100644
--- a/packages/flutter/lib/src/cupertino/context_menu.dart
+++ b/packages/flutter/lib/src/cupertino/context_menu.dart
@@ -378,8 +378,8 @@
// decoy will pop on top of the AppBar if the child is partially behind it,
// such as a top item in a partially scrolled view. However, if we don't use
// an overlay, then the decoy will appear behind its neighboring widget when
- // it expands. This may be solveable by adding a widget to Scaffold that's
- // undernearth the AppBar.
+ // it expands. This may be solvable by adding a widget to Scaffold that's
+ // underneath the AppBar.
_lastOverlayEntry = OverlayEntry(
opaque: false,
builder: (BuildContext context) {
diff --git a/packages/flutter/lib/src/cupertino/dialog.dart b/packages/flutter/lib/src/cupertino/dialog.dart
index 3623fc0..1585460 100644
--- a/packages/flutter/lib/src/cupertino/dialog.dart
+++ b/packages/flutter/lib/src/cupertino/dialog.dart
@@ -995,7 +995,8 @@
return _ActionButtonParentDataWidget(
isPressed: _isPressed,
child: MergeSemantics(
- // TODO(mattcarroll): Button press dynamics need overhaul for iOS: https://github.com/flutter/flutter/issues/19786
+ // TODO(mattcarroll): Button press dynamics need overhaul for iOS:
+ // https://github.com/flutter/flutter/issues/19786
child: GestureDetector(
excludeFromSemantics: true,
behavior: HitTestBehavior.opaque,
@@ -1005,7 +1006,8 @@
onTapUp: (TapUpDetails details) => setState(() {
_isPressed = false;
}),
- // TODO(mattcarroll): Cancel is currently triggered when user moves past slop instead of off button: https://github.com/flutter/flutter/issues/19783
+ // TODO(mattcarroll): Cancel is currently triggered when user moves
+ // past slop instead of off button: https://github.com/flutter/flutter/issues/19783
onTapCancel: () => setState(() => _isPressed = false),
child: widget.child,
),
