commit cdc2d9901d1fb42c7f506b9413d12aec1b1abee8
author Ian Hickson <ian@hixie.ch> Mon Oct 07 16:43:04 2019 -0700
committer GitHub <noreply@github.com> Mon Oct 07 16:43:04 2019 -0700
tree a027538e7a4a552f59bb24697a82f45dbc9cbded
parent 9529d678faa9fa1442180adad0215a08f4ad29a7

More consistent temp directory naming (#42063)

Applying our style guide:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#have-good-hygiene-when-using-temporary-directories

packages/flutter_tools/test/general.shard/android/gradle_test.dart

diff --git a/packages/flutter_tools/test/general.shard/android/gradle_test.dart b/packages/flutter_tools/test/general.shard/android/gradle_test.dart
index f8afc24..5c6434d 100644
--- a/packages/flutter_tools/test/general.shard/android/gradle_test.dart
+++ b/packages/flutter_tools/test/general.shard/android/gradle_test.dart
@@ -444,7 +444,7 @@
 
     setUp(() {
       mockLogger = BufferLogger();
-      tempDir = fs.systemTempDirectory.createTempSync('settings_aar_test.');
+      tempDir = fs.systemTempDirectory.createTempSync('flutter_settings_aar_test.');
 
     });
 
@@ -852,7 +852,7 @@
 
     setUp(() {
       fs = MemoryFileSystem();
-      tempDir = fs.systemTempDirectory.createTempSync('artifacts_test.');
+      tempDir = fs.systemTempDirectory.createTempSync('flutter_artifacts_test.');
       gradleBinary = platform.isWindows ? 'gradlew.bat' : 'gradlew';
       gradleWrapperDirectory = fs.directory(
         fs.path.join(tempDir.path, 'bin', 'cache', 'artifacts', 'gradle_wrapper'));
@@ -960,7 +960,7 @@
 
     setUp(() {
       memoryFileSystem = MemoryFileSystem();
-      tempDir = memoryFileSystem.systemTempDirectory.createTempSync('artifacts_test.');
+      tempDir = memoryFileSystem.systemTempDirectory.createTempSync('flutter_artifacts_test.');
       gradleWrapperDirectory = memoryFileSystem.directory(
           memoryFileSystem.path.join(tempDir.path, 'bin', 'cache', 'artifacts', 'gradle_wrapper'));
       gradleWrapperDirectory.createSync(recursive: true);
@@ -1157,7 +1157,7 @@
     });
 
     testUsingContext('returns true when the project is using AndroidX', () async {
-      final Directory androidDirectory = fs.systemTempDirectory.createTempSync('android.');
+      final Directory androidDirectory = fs.systemTempDirectory.createTempSync('flutter_android.');
 
       androidDirectory
         .childFile('gradle.properties')
@@ -1170,7 +1170,7 @@
     });
 
     testUsingContext('returns false when the project is not using AndroidX', () async {
-      final Directory androidDirectory = fs.systemTempDirectory.createTempSync('android.');
+      final Directory androidDirectory = fs.systemTempDirectory.createTempSync('flutter_android.');
 
       androidDirectory
         .childFile('gradle.properties')
@@ -1183,7 +1183,7 @@
     });
 
     testUsingContext('returns false when gradle.properties does not exist', () async {
-      final Directory androidDirectory = fs.systemTempDirectory.createTempSync('android.');
+      final Directory androidDirectory = fs.systemTempDirectory.createTempSync('flutter_android.');
 
       expect(isAppUsingAndroidX(androidDirectory), isFalse);
 
@@ -1313,7 +1313,7 @@
       mockProcessManager = MockProcessManager();
       android = fakePlatform('android');
 
-      final Directory tempDir = fs.systemTempDirectory.createTempSync('artifacts_test.');
+      final Directory tempDir = fs.systemTempDirectory.createTempSync('flutter_artifacts_test.');
       cache = Cache(rootOverride: tempDir);
 
       final Directory gradleWrapperDirectory = tempDir