tree 79b4df66a62b104019b543eeeae8b4050b178976
parent 67d07a6de414dac56ed454f8b91a0c31dacbdac7
author Chris Bracken <chris@bracken.jp> 1675186666 -0800
committer GitHub <noreply@github.com> 1675186666 +0000
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJj2VHqCRBK7hj4Ov3rIwAA1aIIAINIWpRdK5Fa94XrNHK0F+mJ
 flFOQW4momfNBKrSf2bttFZBvg0LXVILXlv0IScDa58VRaGtKTKkS6tYEbJt17NP
 j81gD6YnxfHKIXbU3bnGEIiIfIf5HVMmuy/Cqmj3/YmJWtvlm9ZD1NpW824DxPbA
 hdmfuSdadUeydbfVQ9wHnhuGvd67eu3nEeMkNY1Ubyb4yfpGtoTXQFMdhwo6pEhm
 rrGwxZDqtGOpAk7WmEdLBVIwVTO9tGSXWGf/jN3xSx2qClXslevZuOAuHJSovPyk
 pJvMZfo+6HloUZ8N9D2cdUgLg24kDphSt9NKRwSbR+vg3N57UkiS2GJGZY8MoR8=
 =gF1K
 -----END PGP SIGNATURE-----
 

Reland: [macos] add flavor options to tool commands (#119564)

* Reland: [macos] add flavor options to tool commands

Adds --flavor option to flutter run and flutter build. Running against
preexisting devicelab flavor tests for feature parity between macOS,
iOS, and Android.

This relands #118421 by alex-wallen which was reverted in #118858 due to
the following test failures:

The bail-out with "Host and target are the same. Nothing to install."
added in `packages/flutter_tools/lib/src/commands/install.dart`
triggered failures in the following tests, which unconditionally attempt
to install the built app, which is unsupported on desktop since the
host and target are the same:

* https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8791495589540422465/+/u/run_flutter_view_macos__start_up/test_stdout
* https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8791496218824259121/+/u/run_complex_layout_win_desktop__start_up/test_stdout
* https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8791496218165602641/+/u/run_flutter_gallery_win_desktop__start_up/test_stdout

Fixes #64088

* Partial revert: eliminate install check on desktop

The original flavour support patch included a check that triggered a
failure when flutter install is run on desktop OSes. This was
intentional, since the host and target devices are the same and
installation is unnecessary to launch the app on currently-supported
desktop OSes.

Note that Windows UWP apps *do* require installation to run, and we used
to have an install command for those apps, though UWP is no longer
supported.

Since that part of the change was orthogonal to flavour support itself,
I'm reverting that component of the change and we can deal with it
separately if so desired.