commit d927c9331005f81157fa39dff7b5dab415ad330b
author Alexandre Ardhuin <alexandre.ardhuin@gmail.com> Wed Sep 12 08:29:29 2018 +0200
committer GitHub <noreply@github.com> Wed Sep 12 08:29:29 2018 +0200
tree 2a7787f66a707df8e8ebd7eede42c598125980d2
parent d7a0dcaa4af2a0bcd9025e8ecf55eae209460d40

Unnecessary new (#20138)

* enable lint unnecessary_new

* fix tests

* fix tests

* fix tests

packages/flutter_tools/test/commands/packages_test.dart

diff --git a/packages/flutter_tools/test/commands/packages_test.dart b/packages/flutter_tools/test/commands/packages_test.dart
index efa71dd..95c7f46 100644
--- a/packages/flutter_tools/test/commands/packages_test.dart
+++ b/packages/flutter_tools/test/commands/packages_test.dart
@@ -58,7 +58,7 @@
     }
 
     Future<Null> runCommandIn(String projectPath, String verb, { List<String> args }) async {
-      final PackagesCommand command = new PackagesCommand();
+      final PackagesCommand command = PackagesCommand();
       final CommandRunner<Null> runner = createTestCommandRunner(command);
 
       final List<String> commandArgs = <String>['packages', verb];
@@ -233,12 +233,12 @@
     MockStdio mockStdio;
 
     setUp(() {
-      mockProcessManager = new MockProcessManager();
-      mockStdio = new MockStdio();
+      mockProcessManager = MockProcessManager();
+      mockStdio = MockStdio();
     });
 
     testUsingContext('test without bot', () async {
-      await createTestCommandRunner(new PackagesCommand()).run(<String>['packages', 'test']);
+      await createTestCommandRunner(PackagesCommand()).run(<String>['packages', 'test']);
       final List<String> commands = mockProcessManager.commands;
       expect(commands, hasLength(3));
       expect(commands[0], matches(r'dart-sdk[\\/]bin[\\/]pub'));
@@ -251,7 +251,7 @@
     });
 
     testUsingContext('test with bot', () async {
-      await createTestCommandRunner(new PackagesCommand()).run(<String>['packages', 'test']);
+      await createTestCommandRunner(PackagesCommand()).run(<String>['packages', 'test']);
       final List<String> commands = mockProcessManager.commands;
       expect(commands, hasLength(4));
       expect(commands[0], matches(r'dart-sdk[\\/]bin[\\/]pub'));
@@ -265,7 +265,7 @@
     });
 
     testUsingContext('run', () async {
-      await createTestCommandRunner(new PackagesCommand()).run(<String>['packages', '--verbose', 'pub', 'run', '--foo', 'bar']);
+      await createTestCommandRunner(PackagesCommand()).run(<String>['packages', '--verbose', 'pub', 'run', '--foo', 'bar']);
       final List<String> commands = mockProcessManager.commands;
       expect(commands, hasLength(4));
       expect(commands[0], matches(r'dart-sdk[\\/]bin[\\/]pub'));
@@ -278,11 +278,11 @@
     });
 
     testUsingContext('publish', () async {
-      final PromptingProcess process = new PromptingProcess();
+      final PromptingProcess process = PromptingProcess();
       mockProcessManager.processFactory = (List<String> commands) => process;
-      final Future<Null> runPackages = createTestCommandRunner(new PackagesCommand()).run(<String>['packages', 'pub', 'publish']);
+      final Future<Null> runPackages = createTestCommandRunner(PackagesCommand()).run(<String>['packages', 'pub', 'publish']);
       final Future<Null> runPrompt = process.showPrompt('Proceed (y/n)? ', <String>['hello', 'world']);
-      final Future<Null> simulateUserInput = new Future<Null>(() {
+      final Future<Null> simulateUserInput = Future<Null>(() {
         mockStdio.simulateStdin('y');
       });
       await Future.wait(<Future<Null>>[runPackages, runPrompt, simulateUserInput]);