Made `FlutterWindowControllerSizeTest.SizedToContentNotResizable` more robust (#195845) Made `FlutterWindowControllerSizeTest.SizedToContentNotResizable` more robust to timing failures where `onBeginFrame` is called before the window is created. This test used to flake because the `onBeginFrame` callback was being called before the window was created so the frame was getting sent to the wrong view. The testing logic is also made more robust by hooking into the notification center events instead of assuming that only one update will happen per run of the event loop. The actual fix is in the dart testing code `flutter_desktop_test.dart`. I've tested this locally where I could reproduce the flake 1/300 times, now the tests runs 1000/1000. fixes https://github.com/flutter/flutter/issues/194780 gemini output: <details> > I've found the real cause, fixed it, and staged the fix. It's different from my first diagnosis: the test wasn't missing a size change, the first frame was going to the wrong view. > > **Cause:** the Dart fixture [`testRenderSizedToContent`](file:///Users/aaclarke/dev/flutter/engine/src/flutter/shell/platform/darwin/macos/framework/Source/fixtures/flutter_desktop_test.dart#L124-L153) draws into `PlatformDispatcher.instance.views.last` and assumes its first frame lands in the test's window. > - Sometimes a frame starts before the test's `CreateRegularWindow` call has run. At that moment `views.last` is the implicit view (id 0), which has no window in this test. > - The 300×300 frame goes to view 0. Creating its render surface fails (`Could not create the embedder backing store`), so it's dropped. > - The frame counter has already moved past 0, so the new window only ever gets the 200×200 frame. The test then waits for 300×300 until its 30 s timeout, which matches the CI log. > > The temporary logging confirmed this directly: the failing 300×300 frame was for view id 0, and the test created view 1 a few ms later. > > **Staged changes (2 files):** > 1. **Fix**, in `flutter_desktop_test.dart`: `onBeginFrame` now skips any frame where `views.last` is the implicit view, then renders into the test's window. A later frame is triggered when the window's view is added, so nothing hangs. > 2. **Test hardening**, in [FlutterWindowControllerTest.mm](file:///Users/aaclarke/dev/flutter/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterWindowControllerTest.mm#L781-L826): the resize-notification version from before. On failure it now also lists every size the window went through; that list is what pointed to the real cause here. > > The temporary logging in `FlutterCompositor.mm`, `FlutterViewEngineProvider.mm` and `FlutterWindowController.mm` is reverted. The `git checkout` I used for that printed a hook notice suggesting `gclient sync -D`; I didn't run it. > > **Verification:** > > | Run | Result | > |---|---| > | Test hardening only, before the fixture fix | 2 failures in 600 runs, both from the frame going to view 0 | > | Both changes, `FlutterWindowControllerSizeTest.*` × 1000 | **1000/1000 passed** | > | All `FlutterWindowController*` tests | 16/16 passed | > > `clang-format`, `dart format` and `dart analyze --fatal-infos` are all clean. > > `SizedToContentResizable` still sends its first frame to view 0 sometimes (14 of 1000 runs). It passes anyway because that fixture draws 300×300 on every frame, so a later frame fixes it. I can add the same implicit-view skip there for consistency if you'd like. > </details> ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant in-code documentation (doc comments with `///`). - [x] If this PR introduces a new feature or capability, I created and linked a website documentation issue or PR in [flutter/website] (or verified none is needed). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/CONTRIBUTING.ai.md [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [flutter/website]: https://github.com/flutter/website [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Flutter is Google's SDK for crafting beautiful, fast user experiences for mobile, web, and desktop from a single codebase. Flutter works with existing code, is used by developers and organizations around the world, and is free and open source.
For release and other announcements, join the flutter-announce mailing list. Our documentation also tracks breaking changes across releases.
The Flutter tool may occasionally download resources from Google servers. By downloading or using the Flutter SDK, you agree to the Google Terms of Service: https://policies.google.com/terms
For example, when installed from GitHub (as opposed to from a prepackaged archive), the Flutter tool will download the Dart SDK from Google servers immediately when first run, as it is used to execute the flutter tool itself. This will also occur when Flutter is upgraded (e.g. by running the flutter upgrade command).
We think Flutter will help you create beautiful, fast apps, with a productive, extensible and open development model, whether you're targeting iOS or Android, web, Windows, macOS, Linux or embedding it as the UI toolkit for a platform of your choice.
We want to enable designers to deliver their full creative vision without being forced to water it down due to limitations of the underlying framework. Flutter‘s layered architecture gives you control over every pixel on the screen and its powerful compositing capabilities let you overlay and animate graphics, video, text, and controls without limitation. Flutter includes a full set of widgets that deliver pixel-perfect experiences whether you’re building for iOS (Cupertino) or other platforms (Material), along with support for customizing or creating entirely new visual components.
Flutter is fast. It's powered by hardware-accelerated 2D graphics libraries like Skia (which underpins Chrome and Android) and Impeller. We architected Flutter to support glitch-free, jank-free graphics at the native speed of your device.
Flutter code is powered by the world-class Dart programming language, which enables compilation to 32-bit and 64-bit ARM machine code for iOS and Android, JavaScript and WebAssembly for the web, as well as Intel x64 and ARM for desktop devices.
Flutter offers stateful hot reload, allowing you to make changes to your code and see the results instantly without restarting your app or losing its state.
Flutter works with any development tool (or none at all), and also includes editor plug-ins for both Visual Studio Code and IntelliJ / Android Studio. Flutter provides tens of thousands of packages to speed your development, regardless of your target platform. And accessing other native code is easy, with support for both FFI (on Android, on iOS, on macOS, on Linux, and on Windows) as well as platform-specific APIs.
Flutter is a fully open-source project, and we welcome contributions. Information on how to get started can be found in our contributor guide.