Restore the original name of the velocity tracker microbenchmark (#64060)
diff --git a/dev/benchmarks/microbenchmarks/README.md b/dev/benchmarks/microbenchmarks/README.md
index 82f0ecb..42e45c1 100644
--- a/dev/benchmarks/microbenchmarks/README.md
+++ b/dev/benchmarks/microbenchmarks/README.md
@@ -13,3 +13,10 @@
```
The results should be in the device logs.
+
+### Avoid changing names of the benchmarks
+
+Each microbenchmark is identified by a name, for example,
+"catmullrom_transform_iteration". Changing the name of an existing
+microbenchmarks will effectively remove the old benchmark and create a new one,
+losing the historical data associated with the old benchmark in the process.
diff --git a/dev/benchmarks/microbenchmarks/lib/gestures/velocity_tracker_bench.dart b/dev/benchmarks/microbenchmarks/lib/gestures/velocity_tracker_bench.dart
index b4b7e06..fbce251 100644
--- a/dev/benchmarks/microbenchmarks/lib/gestures/velocity_tracker_bench.dart
+++ b/dev/benchmarks/microbenchmarks/lib/gestures/velocity_tracker_bench.dart
@@ -9,15 +9,25 @@
const int _kNumIters = 10000;
+class TrackerBenchmark {
+ TrackerBenchmark({ this.name, this.tracker });
+
+ final VelocityTracker tracker;
+ final String name;
+}
+
void main() {
assert(false, "Don't run benchmarks in checked mode! Use 'flutter run --release'.");
final BenchmarkResultPrinter printer = BenchmarkResultPrinter();
- final List<VelocityTracker> trackers = <VelocityTracker>[VelocityTracker(), IOSScrollViewFlingVelocityTracker()];
+ final List<TrackerBenchmark> benchmarks = <TrackerBenchmark>[
+ TrackerBenchmark(name: 'velocity_tracker_iteration', tracker: VelocityTracker()),
+ TrackerBenchmark(name: 'velocity_tracker_iteration_ios_fling', tracker: IOSScrollViewFlingVelocityTracker()),
+ ];
final Stopwatch watch = Stopwatch();
- for (final VelocityTracker tracker in trackers) {
- final String trackerType = tracker.runtimeType.toString();
- print('$trackerType benchmark...');
+ for (final TrackerBenchmark benchmark in benchmarks) {
+ print('${benchmark.name} benchmark...');
+ final VelocityTracker tracker = benchmark.tracker;
watch.reset();
watch.start();
for (int i = 0; i < _kNumIters; i += 1) {
@@ -30,10 +40,10 @@
}
watch.stop();
printer.addResult(
- description: 'Velocity tracker: $trackerType',
+ description: 'Velocity tracker: ${tracker.runtimeType}',
value: watch.elapsedMicroseconds / _kNumIters,
unit: 'µs per iteration',
- name: 'velocity_tracker_iteration_$trackerType',
+ name: benchmark.name,
);
}
