commit e6ae95c4ced11c6da0de4bb4fbb8172913be5163
author stuartmorgan <stuartmorgan@google.com> Wed Sep 11 07:46:57 2019 -0700
committer GitHub <noreply@github.com> Wed Sep 11 07:46:57 2019 -0700
tree fdaf623619ffecbcad06f1c44b9e5f7eaef79e00
parent ef97a69daba038d6c534e775e5bc1831b77e8b3e

Add an ephemeral directory to Windows projects (#40194)

Moves files generated in windows/flutter/ as part of the build to an ephemeral/ subdirectory, matching the approach used on macOS (and in the future, Windows).

Adds that directory to the generated properties file to minimize hard-coding of paths in the project.

packages/flutter_tools/lib/src/project.dart

diff --git a/packages/flutter_tools/lib/src/project.dart b/packages/flutter_tools/lib/src/project.dart
index e53d187..8322ab8 100644
--- a/packages/flutter_tools/lib/src/project.dart
+++ b/packages/flutter_tools/lib/src/project.dart
@@ -752,11 +752,19 @@
 
   Directory get _editableDirectory => project.directory.childDirectory('windows');
 
-  Directory get _cacheDirectory => _editableDirectory.childDirectory('flutter');
+  /// The directory in the project that is managed by Flutter. As much as
+  /// possible, files that are edited by Flutter tooling after initial project
+  /// creation should live here.
+  Directory get managedDirectory => _editableDirectory.childDirectory('flutter');
+
+  /// The subdirectory of [managedDirectory] that contains files that are
+  /// generated on the fly. All generated files that are not intended to be
+  /// checked in should live here.
+  Directory get ephemeralDirectory => managedDirectory.childDirectory('ephemeral');
 
   /// Contains definitions for FLUTTER_ROOT, LOCAL_ENGINE, and more flags for
   /// the build.
-  File get generatedPropertySheetFile => _cacheDirectory.childFile('Generated.props');
+  File get generatedPropertySheetFile => ephemeralDirectory.childFile('Generated.props');
 
   // The MSBuild project file.
   File get vcprojFile => _editableDirectory.childFile('Runner.vcxproj');
@@ -767,7 +775,7 @@
   /// The file where the VS build will write the name of the built app.
   ///
   /// Ideally this will be replaced in the future with inspection of the project.
-  File get nameFile => _cacheDirectory.childFile('exe_filename');
+  File get nameFile => ephemeralDirectory.childFile('exe_filename');
 }
 
 /// The Linux sub project.
@@ -778,6 +786,8 @@
 
   Directory get editableHostAppDirectory => project.directory.childDirectory('linux');
 
+  // TODO(stuartmorgan): Move to using an ephemeralDirectory to match the other
+  // desktop projects.
   Directory get cacheDirectory => editableHostAppDirectory.childDirectory('flutter');
 
   bool existsSync() => editableHostAppDirectory.existsSync();