)]}'
{
  "commit": "edd4547f9ebd51f93a2bbdc0bd7b156a4bb35217",
  "tree": "2a9b6d96d88203c2fc2f72b4363e9c8b7f899bc8",
  "parents": [
    "c3dbaab6f2b21e75a9da5990404b3ac1213c3f1b"
  ],
  "author": {
    "name": "Bui Anh Viet",
    "email": "57765714+Vi-debug@users.noreply.github.com",
    "time": "Wed Aug 26 22:13:11 2026 +0000"
  },
  "committer": {
    "name": "GitHub",
    "email": "noreply@github.com",
    "time": "Wed Aug 26 22:13:11 2026 +0000"
  },
  "message": "Add SliverAppBar showOnScreen semantics test coverage (#190410)\n\nIn https://github.com/flutter/flutter/pull/186611 the widgets test\n`showOnScreen works with pinned app bar and sliver list` was switched\nfrom `SliverAppBar` to a private `SliverPersistentHeader` delegate, as\npart of removing the `material` import from\n`scrollable_semantics_test.dart`. That was the only test exercising\n`SemanticsAction.showOnScreen` against a pinned `SliverAppBar`, so the\nMaterial path lost coverage and a TODO was left behind to track\nrestoring it.\n\nThis PR restores the coverage by adding an equivalent test to\n`packages/flutter/test/material/app_bar_sliver_test.dart`, which already\nimports `../widgets/semantics_tester.dart` and is where the other\n`SliverAppBar` semantics tests live. The test performs\n`SemanticsAction.showOnScreen` on the first list item and asserts it is\nrevealed *below* the pinned app bar (`dy \u003d\u003d expandedHeight`) rather than\nunderneath it.\n\nI also removed the TODO in\n`packages/flutter/test/widgets/scrollable_semantics_test.dart`, since it\npoints at the issue this PR fixes. Note that the TODO says \"in\nmaterial_ui package\" — that package does not exist in the repo yet, so\nthe test is placed in the existing Material test suite (which matches\nthe issue description) and will move along with\n`app_bar_sliver_test.dart` when the decoupling work lands. Happy to keep\nthe TODO instead if you\u0027d prefer to track the `material_ui` move\nseparately.\n\nVerification:\n- `flutter test packages/flutter/test/material/app_bar_sliver_test.dart`\n— 53 tests pass.\n- `flutter test\npackages/flutter/test/widgets/scrollable_semantics_test.dart` — 20 tests\npass.\n- To confirm the assertion is load-bearing, flipping `pinned` to `false`\nfails the new test with `Expected: \u003c56.0\u003e Actual: \u003c6.0\u003e`.\n\nFixes https://github.com/flutter/flutter/issues/189117\n\n## Pre-launch Checklist\n\n- [x] I read the [Contributor Guide] and followed the process outlined\nthere for submitting PRs.\n- [x] I read the [AI contribution guidelines] and understand my\nresponsibilities, or I am not using AI tools.\n- [x] I read the [Tree Hygiene] wiki page, which explains my\nresponsibilities.\n- [x] I read and followed the [Flutter Style Guide], including [Features\nwe expect every widget to implement].\n- [x] I signed the [CLA].\n- [x] I listed at least one issue that this PR fixes in the description\nabove.\n- [x] I updated/added relevant documentation (doc comments with `///`).\n- [x] I added new tests to check the change I am making, or this PR is\n[test-exempt].\n- [x] I followed the [breaking change policy] and added [Data Driven\nFixes] where supported.\n- [x] All existing and new tests are passing.\n\n\u003c!-- Links --\u003e\n[Contributor Guide]:\nhttps://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview\n[AI contribution guidelines]:\nhttps://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines\n[Tree Hygiene]:\nhttps://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md\n[test-exempt]:\nhttps://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests\n[Flutter Style Guide]:\nhttps://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md\n[Features we expect every widget to implement]:\nhttps://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement\n[CLA]: https://cla.developers.google.com/\n[flutter/tests]: https://github.com/flutter/tests\n[breaking change policy]:\nhttps://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes\n[Discord]:\nhttps://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md\n[Data Driven Fixes]:\nhttps://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "0bf5c643835da7447f69ccee13d143dd2806bcfd",
      "old_mode": 33188,
      "old_path": "packages/flutter/test/widgets/scrollable_semantics_test.dart",
      "new_id": "5fbec132da151fa5dca8029ab2e7279872dc19d9",
      "new_mode": 33188,
      "new_path": "packages/flutter/test/widgets/scrollable_semantics_test.dart"
    }
  ]
}
